- Wine-devel - list.winehq.org

Re: [PATCH v2 05/11] winmm/tests: Add tests for destination of video window.
by Marvin 31 Jul '22

31 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120238 Your paranoid android. === debian11 (32 bit report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Arabic:Morocco report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit German report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit French report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Hebrew:Israel report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Hindi:India report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Japanese:Japan report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Chinese:China report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(113,52), got (0,0)-(113,52) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(113,52), got (0,0)-(113,52) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(113,52), got (0,0)-(113,52) === debian11 (32 bit WoW report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (64 bit WoW report) === winmm: mci.c:1606: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1606: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1606: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51)

1 0

Re: [PATCH v2 04/11] winmm/tests: Add tests for dimensions of video window.
by Marvin 31 Jul '22

31 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120237 Your paranoid android. === debian11 (32 bit report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Arabic:Morocco report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit German report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit French report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Hebrew:Israel report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Hindi:India report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Japanese:Japan report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,10)-(112,61), got (0,10)-(112,61) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (32 bit Chinese:China report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(113,52), got (0,0)-(113,52) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(113,52), got (0,0)-(113,52) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(113,52), got (0,0)-(113,52) === debian11 (32 bit WoW report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) === debian11 (64 bit WoW report) === winmm: mci.c:1601: Test succeeded inside todo block: 0: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 2: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51) mci.c:1601: Test succeeded inside todo block: 3: window rectangle doesn't match, expected (0,0)-(112,51), got (0,0)-(112,51)

1 0

Re: [PATCH v2 7/7] xactengine3_7: Return error on invalid notification value.
by Marvin 31 Jul '22

31 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120222 Your paranoid android. === debian11 (32 bit report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received === debian11 (32 bit Arabic:Morocco report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received === debian11 (32 bit German report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received === debian11 (32 bit French report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received === debian11 (32 bit Hebrew:Israel report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received === debian11 (32 bit Hindi:India report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received === debian11 (32 bit Japanese:Japan report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received === debian11 (32 bit Chinese:China report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received === debian11 (32 bit WoW report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received === debian11 (64 bit WoW report) === xactengine3_7: xact3.c:215: Test failed: got hr 0 xact3.c:218: Test failed: got hr 0 xact3.c:224: Test failed: got hr 0 xact3.c:227: Test failed: got hr 0 xact3.c:272: Test failed: The 'wave bank prepared' notification was never received xact3.c:276: Test failed: The 'wave bank destroyed' notification was never received

1 0

[PATCH] fltlib: Add fixme stub for FilterSendMessage.
by Chao Long 31 Jul '22

31 Jul '22

Signed-off-by: Chao Long <longchao(a)uniontech.com> --- dlls/fltlib/fltlib.c | 11 +++++++++++ dlls/fltlib/fltlib.spec | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/dlls/fltlib/fltlib.c b/dlls/fltlib/fltlib.c index a6cf060b3d1..a322e7559de 100644 --- a/dlls/fltlib/fltlib.c +++ b/dlls/fltlib/fltlib.c @@ -80,3 +80,14 @@ HRESULT WINAPI FilterUnload(LPCWSTR filtername) return S_OK; } + +/********************************************************************** + * FilterSendMessage (FLTLIB.@) + */ +HRESULT WINAPI FilterSendMessage(HANDLE port, LPVOID in_buffer, DWORD in_size, LPVOID out_buffer, + DWORD out_size, LPDWORD returned) +{ + FIXME("(%p, %p, %d, %p, %d, %p) stub\n", port,in_buffer,in_size,out_buffer,out_size,returned); + + return S_OK; +} \ No newline at end of file diff --git a/dlls/fltlib/fltlib.spec b/dlls/fltlib/fltlib.spec index 226a61519d1..48caa505a28 100644 --- a/dlls/fltlib/fltlib.spec +++ b/dlls/fltlib/fltlib.spec @@ -18,7 +18,7 @@ @ stub FilterInstanceGetInformation @ stdcall FilterLoad(wstr) @ stub FilterReplyMessage -@ stub FilterSendMessage +@ stdcall FilterSendMessage(ptr ptr long ptr long ptr) @ stdcall FilterUnload(wstr) @ stub FilterVolumeClose @ stub FilterVolumeFindClose -- 2.20.1

2 1

Wine staging 7.14 release
by Alistair Leslie-Hughes 30 Jul '22

30 Jul '22

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 7.14 (537 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * xactengine3.7: Delay Notication for WAVEBANKPREPARED * ntdll: Check return parameter before use * ntdll: RtlFirstFreeAce only return FALSE on error * xactengine3_7: Remove Entry after FAudio Destroyed call Added: * None Updated: * xactengine3_7-Notification * xactengine3_7-callbacks Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Re: [PATCH v2 3/5] mshtml: Implement document.doctype.
by Marvin 29 Jul '22

29 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120190 Your paranoid android. === w10pro64_en_AE_u8 (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:350: Test failed: expected Exec_SETTITLE htmldoc.c:2859: Test failed: unexpected call Exec_SETTITLE

1 0

Re: [PATCH 4/5] mshtml: Implement DocumentType node's name prop.
by Marvin 29 Jul '22

29 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120170 Your paranoid android. === w10pro64_ja (64 bit report) === mshtml: htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:2541: Test failed: unexpected call UpdateUI htmldoc.c:2853: Test failed: unexpected call Exec_UPDATECOMMANDS htmldoc.c:350: Test failed: expected Exec_SETTITLE htmldoc.c:2859: Test failed: unexpected call Exec_SETTITLE

1 0

Re: [PATCH 3/5] mshtml: Implement document.doctype.
by Marvin 29 Jul '22

29 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=120169 Your paranoid android. === w1064v1809 (testbot log) === WineRunTask.pl:error: The previous 1 run(s) terminated abnormally

1 0

[PATCH vkd3d 2/3] vkd3d-shader: Introduce a compile option to use Unknown format for typed UAV reads.
by Conor McCarthy 29 Jul '22

29 Jul '22

Specifying R32ui for UAVs created with a vector format, e.g. R32G32B32A32_FLOAT, results in only the red being loaded/stored, potentially causing images to contain only the red component. Signed-off-by: Conor McCarthy <cmccarthy(a)codeweavers.com> --- include/vkd3d_shader.h | 18 ++++++++++++++++++ libs/vkd3d-shader/spirv.c | 16 +++++++++++++++- 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/include/vkd3d_shader.h b/include/vkd3d_shader.h index ebddbba7..4175223f 100644 --- a/include/vkd3d_shader.h +++ b/include/vkd3d_shader.h @@ -99,6 +99,22 @@ enum vkd3d_shader_compile_option_buffer_uav VKD3D_FORCE_32_BIT_ENUM(VKD3D_SHADER_COMPILE_OPTION_BUFFER_UAV), }; +/** + * Determines how typed UAVs are declared. + */ +enum vkd3d_shader_compile_option_typed_uav +{ + /** Use R32ui format for UAVs which are read from. This is the default value. */ + VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV_READ_FORMAT_R32UI = 0x00000000, + /** + * Use Unknown format for UAVs which are read from. This should only be set if + * shaderStorageImageReadWithoutFormat is enabled in the target environment. + */ + VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV_READ_FORMAT_UNKNOWN = 0x00000001, + + VKD3D_FORCE_32_BIT_ENUM(VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV), +}; + enum vkd3d_shader_compile_option_formatting_flags { VKD3D_SHADER_COMPILE_OPTION_FORMATTING_NONE = 0x00000000, @@ -127,6 +143,8 @@ enum vkd3d_shader_compile_option_name VKD3D_SHADER_COMPILE_OPTION_FORMATTING = 0x00000003, /** \a value is a member of enum vkd3d_shader_api_version. \since 1.3 */ VKD3D_SHADER_COMPILE_OPTION_API_VERSION = 0x00000004, + /** \a value is a member of enum vkd3d_shader_compile_option_typed_uav. \since 1.5 */ + VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV = 0x00000005, VKD3D_FORCE_32_BIT_ENUM(VKD3D_SHADER_COMPILE_OPTION_NAME), }; diff --git a/libs/vkd3d-shader/spirv.c b/libs/vkd3d-shader/spirv.c index 776533cb..6450f818 100644 --- a/libs/vkd3d-shader/spirv.c +++ b/libs/vkd3d-shader/spirv.c @@ -2228,6 +2228,7 @@ struct vkd3d_dxbc_compiler bool strip_debug; bool ssbo_uavs; + bool uav_read_without_format; struct rb_tree symbol_table; uint32_t temp_id; @@ -2379,6 +2380,15 @@ struct vkd3d_dxbc_compiler *vkd3d_dxbc_compiler_create(const struct vkd3d_shader case VKD3D_SHADER_COMPILE_OPTION_API_VERSION: break; + + case VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV: + if (option->value == VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV_READ_FORMAT_R32UI) + compiler->uav_read_without_format = false; + else if (option->value == VKD3D_SHADER_COMPILE_OPTION_TYPED_UAV_READ_FORMAT_UNKNOWN) + compiler->uav_read_without_format = true; + else + WARN("Ignoring unrecognised value %#x for option %#x.\n", option->value, option->name); + break; } } @@ -5856,14 +5866,18 @@ static uint32_t vkd3d_dxbc_compiler_get_image_type_id(struct vkd3d_dxbc_compiler const struct vkd3d_shader_descriptor_info *d; uint32_t sampled_type_id; SpvImageFormat format; + bool uav_read; format = SpvImageFormatUnknown; if (reg->type == VKD3DSPR_UAV) { d = vkd3d_dxbc_compiler_get_descriptor_info(compiler, VKD3D_SHADER_DESCRIPTOR_TYPE_UAV, range); - if (raw_structured || (d->flags & VKD3D_SHADER_DESCRIPTOR_INFO_FLAG_UAV_READ)) + uav_read = !!(d->flags & VKD3D_SHADER_DESCRIPTOR_INFO_FLAG_UAV_READ); + if (raw_structured || (uav_read && !compiler->uav_read_without_format)) format = image_format_for_image_read(data_type); + else if (uav_read) + vkd3d_spirv_enable_capability(builder, SpvCapabilityStorageImageReadWithoutFormat); } sampled_type_id = vkd3d_spirv_get_type_id(builder, data_type, 1); -- 2.36.1

3 10

[PATCH v2] ntdll/signalx86_64: Add CFI for __wine_syscall_dispatcher
by Keno Fischer 29 Jul '22

29 Jul '22

In a debugger that is capable of loading both PE and ELF libraries (e.g. the wine-enhanced GDB version at [1]), this unwind information will allow proper unwind across the __wine_syscall_dispatcher. The CFI itself is relatively straightforward, though the implementation looks a little complex, because support for proper CFI encoding is somewhat limitied in the GNU toolchain. Essentially, as registers are stored in the rcx buffer in this function, we switch their cfi description to point at that rcx buffer, so the registers may be freely used thereafter without affecting the unwind. Eventually the rcx buffer is tracked in rbp instead at which point we pivot the CFI information as well and keep it there for most of the rest of the function. [1] https://github.com/JuliaComputing/gdb-solib-wine Signed-off-by: Keno Fischer <keno(a)juliacomputing.com> --- v2: Fix accidental build issues introduced during cleanup. (And missed in my build test, because I forgot to enable win64, sigh). dlls/ntdll/unix/signal_x86_64.c | 181 ++++++++++++++++++++++++++++++++ 1 file changed, 181 insertions(+) diff --git a/dlls/ntdll/unix/signal_x86_64.c b/dlls/ntdll/unix/signal_x86_64.c index d6f19dbfa84..2d33df8bccd 100644 --- a/dlls/ntdll/unix/signal_x86_64.c +++ b/dlls/ntdll/unix/signal_x86_64.c @@ -442,6 +442,10 @@ static USHORT fs32_sel; /* selector for %fs in 32-bit mode */ * Definitions for Dwarf unwind tables */ +/* For use in inline-assembly and other contexts where C enums are unavailable */ +#define PP_DW_CFA_def_cfa_expression 0xf +#define PP_DW_CFA_expression 0x10 + enum dwarf_call_frame_info { DW_CFA_advance_loc = 0x40, @@ -472,6 +476,14 @@ enum dwarf_call_frame_info DW_CFA_val_expression = 0x16, }; +/* DWARF State machine ops */ +#define PP_DW_OP_const1u 0x08 +#define PP_DW_OP_breg_base 0x70 +#define PP_DW_OP_minus 0x1c +#define PP_DW_OP_deref 0x06 +#define PP_DW_OP_plus 0x22 +#define PP_DW_OP_plus_uconst 0x23 + enum dwarf_operation { DW_OP_addr = 0x03, @@ -3288,35 +3300,177 @@ __ASM_GLOBAL_FUNC( signal_exit_thread, __ASM_CFI(".cfi_rel_offset %r15,8\n\t") "call *%rsi" ) + +/*********************************************************************** + * CFI Utility definitions + * + * These utility definitions help encode CFI unwind information (for consumption + * in gdb and similar debuggers), improving the accuracy of backtraces. + */ + +/* DWARF Register ordering for x86_64 */ +#define X86_64_DWARF_RAX 0x00 +#define X86_64_DWARF_RDX 0x01 +#define X86_64_DWARF_RCX 0x02 +#define X86_64_DWARF_RBX 0x03 +#define X86_64_DWARF_RSI 0x04 +#define X86_64_DWARF_RDI 0x05 +#define X86_64_DWARF_RBP 0x06 +#define X86_64_DWARF_RSP 0x07 +#define X86_64_DWARF_R8 0x08 +#define X86_64_DWARF_R9 0x09 +#define X86_64_DWARF_R10 0x0a +#define X86_64_DWARF_R11 0x0b +#define X86_64_DWARF_R12 0x0c +#define X86_64_DWARF_R13 0x0d +#define X86_64_DWARF_R14 0x0e +#define X86_64_DWARF_R15 0x0f +#define X86_64_DWARF_RIP 0x10 + +/* __ASM_REG_IS_DEREF_REF_OFFSET(REG_SAVE, REG, OFFSET) + * + * Declare that the register with DWARF register number `REG` is + * saved at offset `OFFSET` from the register with DWARF register + * number `REG_SAVE`. I.e.: + * + * REG (in previous frame) = *(%REG_SAVE + OFFSET) + */ +#define _STR(R) #R +#define __STR(R) _STR(R) +#define __ASM_REG_IS_DEREF_REF_OFFSET(REG_SAVE, REG, OFFSET) \ + ".cfi_escape " __STR(PP_DW_CFA_expression) ", " \ + _STR(REG) "," /* The register being saved */ \ + " 0x02," /* 2 bytes follow */ \ + __STR(PP_DW_OP_breg_base) " + " _STR(REG_SAVE) ", " #OFFSET ";\n\t" + +/* __ASM_REG_IS_DEREF_REF_OFFSET2(REG_SAVE, REG, OFFSET1, OFFSET2) + * + * Like __ASM_REG_IS_DEREF_REF_OFFSET, expect for offsets of more than + * 7 bits. Takes an SLEB128 encoded offset as two bytes. Thus to e.g. + * encode an offset of 0x70, convert to SLEB128 first: + * + * HEX: 0x70 + * BINARY: 01110000 + * SLEB128: 11110000 00000000 + * |||||||| |||||||| + * |||||||| \------- High bits + * |\------ Low bits + * \- Continuation Bit + * + * SLEB128: 0xf0 0x00 + */ +#define __ASM_REG_IS_DEREF_REF_OFFSET2(REG_SAVE, REG, OFFSET1, OFFSET2) \ + ".cfi_escape " __STR(PP_DW_CFA_expression) ", " \ + _STR(REG) "," /* The register being saved */ \ + " 0x03," /* 3 bytes follow */ \ + __STR(PP_DW_OP_breg_base) " + " _STR(REG_SAVE) ", " #OFFSET1 ", " #OFFSET2 ";\n\t" + +/* __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, REG, OFFSET, OFFSET_SUB) + * + * Like __ASM_REG_IS_DEREF_REF_OFFSET, except encodes that the saved + * register value is at `*(%REG_SAVE + OFFSET - OFFSET_SUB). + */ +#define __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, REG, OFFSET, OFFSET_SUB) \ + ".cfi_escape " __STR(PP_DW_CFA_expression) ", " \ + _STR(REG) "," /* The register being saved */ \ + " 0x05," /* 5 bytes follow */ \ + __STR(PP_DW_OP_breg_base) " + " _STR(REG_SAVE) ", " #OFFSET "," \ + __STR(PP_DW_OP_const1u) ", " #OFFSET_SUB "," __STR(PP_DW_OP_minus) ";\n\t" + +/* __ASM_CFA_AT_REG_OFFSET(REG_SAVE, OFFSET) + * + * Declares the CFA of set frame to be stored at *(REG_SAVE + OFFSET). + * Note that the CFA is ordinarily the same as the stack pointer at the end + * of the previous frame, but these are technically separate concepts. + */ +#define __ASM_CFA_AT_REG_OFFSET(REG_SAVE, OFFSET) \ + ".cfi_escape " __STR(PP_DW_CFA_def_cfa_expression) "," \ + " 0x03," /* 3 bytes follow */ \ + __STR(PP_DW_OP_breg_base) " + " _STR(REG_SAVE) ", " #OFFSET ", " \ + __STR(PP_DW_OP_deref) ";\n\t" + +/* __ASM_CFA_AT_REG_OFFSET2(REG_SAVE, OFFSET_HIGH, OFFSET_LOW) + * + * Like __ASM_CFA_AT_REG_OFFSET, except used for larger offsets. `OFFSET_LOW` encodes + * the low 7 bits of the offset. `OFFSET_HIGH` the next 7 bits. + */ +#define __ASM_CFA_AT_REG_OFFSET2(REG_SAVE, OFFSET_HIGH, OFFSET_LOW) \ + ".cfi_escape " __STR(PP_DW_CFA_def_cfa_expression) "," \ + " 0x04," /* 4 bytes follow */ \ + __STR(PP_DW_OP_breg_base) " + " _STR(REG_SAVE) ", " #OFFSET_LOW " | 0x80 , " #OFFSET_HIGH ", " \ + __STR(PP_DW_OP_deref) ";\n\t" + +#define __ASM_REG_IS_DEREF_RCX_OFFSET(REG, OFFSET) \ + __ASM_REG_IS_DEREF_REF_OFFSET(X86_64_DWARF_RCX, REG, OFFSET) +#define __ASM_REG_IS_DEREF_RCX_OFFSET2(REG, OFFSET_HIGH, OFFSET_LOW) \ + __ASM_REG_IS_DEREF_REF_OFFSET2(X86_64_DWARF_RCX, REG, OFFSET_LOW | 0x80, OFFSET_HIGH) + +/* __ASM_REGSAVE_AT_DWARF_REG_MINUS(REG_SAVE, OFFSET_SUB) + * + * Declares that a `struct syscall_frame` containing the previous frame's registers may + * be found at `*(struct syscall_frame*)(%REG_SAVE - OFFSET_SUB)` and declares both the + * CFA and saved registers may be found in the corresponding offset. + */ +#define __ASM_REGSAVE_AT_DWARF_REG_MINUS(REG_SAVE, OFFSET_SUB) \ + /* N.B.: First argument is SLEB128 encoded, so move the high bit over \ + to the subtraction */ \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RIP, 0x00, OFFSET_SUB - 0x70) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RAX, 0x00, OFFSET_SUB) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RBX, 0x08, OFFSET_SUB) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RDX, 0x18, OFFSET_SUB) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RSI, 0x20, OFFSET_SUB) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RDI, 0x28, OFFSET_SUB) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_R12, 0x00, OFFSET_SUB - 0x50) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_R14, 0x10, OFFSET_SUB - 0x50) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RSP, 0x08, OFFSET_SUB - 0x80) \ + /* -0x10 in 7bit 2's complement */ \ + __ASM_CFA_AT_REG_OFFSET(REG_SAVE, 0x70) \ + __ASM_REG_IS_DEREF_REF_OFFSET_MINUS(REG_SAVE, X86_64_DWARF_RBP, 0x18, OFFSET_SUB - 0x80) + /*********************************************************************** * __wine_syscall_dispatcher */ __ASM_GLOBAL_FUNC( __wine_syscall_dispatcher, "movq %gs:0x30,%rcx\n\t" + __ASM_CFI(".cfi_undefined rcx\n\t") "movq 0x328(%rcx),%rcx\n\t" /* amd64_thread_data()->syscall_frame */ "popq 0x70(%rcx)\n\t" /* frame->rip */ + __ASM_CFI(".cfi_adjust_cfa_offset -8\n\t") + __ASM_REG_IS_DEREF_RCX_OFFSET2(X86_64_DWARF_RIP, 0x00, 0x70) "pushfq\n\t" + __ASM_CFI(".cfi_adjust_cfa_offset 8\n\t") "popq 0x80(%rcx)\n\t" + __ASM_CFI(".cfi_adjust_cfa_offset -8\n\t") "movl $0,0x94(%rcx)\n\t" /* frame->restore_flags */ ".globl " __ASM_NAME("__wine_syscall_dispatcher_prolog_end") "\n" __ASM_NAME("__wine_syscall_dispatcher_prolog_end") ":\n\t" "movq %rax,0x00(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET(X86_64_DWARF_RAX, 0x00) "movq %rbx,0x08(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET(X86_64_DWARF_RBX, 0x08) "movq %rdx,0x18(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET(X86_64_DWARF_RDX, 0x18) "movq %rsi,0x20(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET(X86_64_DWARF_RSI, 0x20) "movq %rdi,0x28(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET(X86_64_DWARF_RDI, 0x28) "movq %r12,0x50(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET2(X86_64_DWARF_R12, 0x00, 0x50) "movq %r13,0x58(%rcx)\n\t" "movq %r14,0x60(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET2(X86_64_DWARF_R14, 0x00, 0x60) "movq %r15,0x68(%rcx)\n\t" "movw %cs,0x78(%rcx)\n\t" "movw %ds,0x7a(%rcx)\n\t" "movw %es,0x7c(%rcx)\n\t" "movw %fs,0x7e(%rcx)\n\t" "movq %rsp,0x88(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET2(X86_64_DWARF_RSP, 0x01, 0x08) + __ASM_CFA_AT_REG_OFFSET2(X86_64_DWARF_RCX, 0x01, 0x08) "movw %ss,0x90(%rcx)\n\t" "movw %gs,0x92(%rcx)\n\t" "movq %rbp,0x98(%rcx)\n\t" + __ASM_REG_IS_DEREF_RCX_OFFSET2(X86_64_DWARF_RBP, 0x01, 0x18) /* Legends of Runeterra hooks the first system call return instruction, and * depends on us returning to it. Adjust the return address accordingly. */ "subq $0xb,0x70(%rcx)\n\t" @@ -3341,6 +3495,8 @@ __ASM_GLOBAL_FUNC( __wine_syscall_dispatcher, "jmp 3f\n" "2:\tfxsave64 0xc0(%rcx)\n" "3:\tleaq 0x98(%rcx),%rbp\n\t" + __ASM_CFI(".cfi_remember_state\n\t") + __ASM_REGSAVE_AT_DWARF_REG_MINUS(X86_64_DWARF_RBP, 0x98) #ifdef __linux__ "testl $12,%r14d\n\t" /* SYSCALL_HAVE_PTHREAD_TEB | SYSCALL_HAVE_WRFSGSBASE */ "jz 2f\n\t" @@ -3402,35 +3558,60 @@ __ASM_GLOBAL_FUNC( __wine_syscall_dispatcher, "jmp 4f\n" "3:\tfxrstor64 0xc0(%rcx)\n" "4:\tmovq 0x98(%rcx),%rbp\n\t" + __ASM_CFI(".cfi_restore_state\n\t") "movq 0x68(%rcx),%r15\n\t" + __ASM_CFI(".cfi_same_value r15\n\t") "movq 0x60(%rcx),%r14\n\t" + __ASM_CFI(".cfi_same_value r14\n\t") "movq 0x58(%rcx),%r13\n\t" + __ASM_CFI(".cfi_same_value r13\n\t") "movq 0x50(%rcx),%r12\n\t" + __ASM_CFI(".cfi_same_value r12\n\t") "movq 0x28(%rcx),%rdi\n\t" + __ASM_CFI(".cfi_same_value rdi\n\t") "movq 0x20(%rcx),%rsi\n\t" + __ASM_CFI(".cfi_same_value rsi\n\t") "movq 0x08(%rcx),%rbx\n\t" + __ASM_CFI(".cfi_same_value rbx\n\t") "testl $0x3,%edx\n\t" /* CONTEXT_CONTROL | CONTEXT_INTEGER */ "jnz 1f\n\t" + __ASM_CFI(".cfi_remember_state\n\t") "movq 0x80(%rcx),%r11\n\t" /* frame->eflags */ + __ASM_CFI(".cfi_same_value r11\n\t") "pushq %r11\n\t" "popfq\n\t" "movq 0x88(%rcx),%rsp\n\t" + __ASM_CFI(".cfi_same_value rsp\n\t") "movq 0x70(%rcx),%rcx\n\t" /* frame->rip */ + __ASM_CFI(".cfi_register rip, rcx\n\t") "jmpq *%rcx\n\t" "1:\tleaq 0x70(%rcx),%rsp\n\t" + __ASM_CFI(".cfi_restore_state\n\t") + __ASM_CFI(".cfi_remember_state\n\t") "testl $0x2,%edx\n\t" /* CONTEXT_INTEGER */ "jnz 1f\n\t" "movq 0x10(%rsp),%r11\n\t" /* frame->eflags */ + __ASM_CFI(".cfi_same_value r11\n\t") "movq (%rsp),%rcx\n\t" /* frame->rip */ + __ASM_CFI(".cfi_register rip, rcx\n\t") "iretq\n" "1:\tmovq 0x00(%rcx),%rax\n\t" + __ASM_CFI(".cfi_restore_state\n\t") + __ASM_CFI(".cfi_same_value rax\n\t") "movq 0x18(%rcx),%rdx\n\t" + __ASM_CFI(".cfi_same_value rdx\n\t") "movq 0x30(%rcx),%r8\n\t" + __ASM_CFI(".cfi_same_value r8\n\t") "movq 0x38(%rcx),%r9\n\t" + __ASM_CFI(".cfi_same_value r9\n\t") "movq 0x40(%rcx),%r10\n\t" + __ASM_CFI(".cfi_same_value r10\n\t") "movq 0x48(%rcx),%r11\n\t" + __ASM_CFI(".cfi_same_value r11\n\t") "movq 0x10(%rcx),%rcx\n" + __ASM_REG_IS_DEREF_REF_OFFSET(X86_64_DWARF_RSP, X86_64_DWARF_RIP, 0) "iretq\n" + __ASM_REGSAVE_AT_DWARF_REG_MINUS(X86_64_DWARF_RBP, 0x98) "5:\tmovl $0xc000000d,%edx\n\t" /* STATUS_INVALID_PARAMETER */ "movq %rsp,%rcx\n\t" ".globl " __ASM_NAME("__wine_syscall_dispatcher_return") "\n" -- 2.25.1

1 0