Re: [PATCH 3/4] dx8vb: Add Direct3D8 interface with stubs

[Nikolay Sivov]

> static HRESULT WINAPI directx8_QueryInterface(IDirectX8 *iface, REFIID
> riid, void **ppv)
> @@ -237,9 +440,11 @@ static HRESULT WINAPI directx8_
> DirectPlayAddressCreate(IDirectX8 *iface, DirectP
>
> static HRESULT WINAPI directx8_Direct3DCreate(IDirectX8 *iface,
> Direct3D8 **ret)
>  {
> -    FIXME("(%p): stub!\n", ret);
> +    HRESULT res = direct3d8_create(ret);
>
> -    return E_NOTIMPL;
> +    TRACE("(%p) -> (%x)\n", ret, res);
> +
> +    return res;
>  }

That's an unusual way to arrange things. Why don't you return as "return
direct3d8_create();" ?

[PATCH 3/4] dx8vb: Add Direct3D8 interface with stubs

[Fabian Maurer]

> > -    FIXME("(%p): stub!\n", ret);
> > +    HRESULT res = direct3d8_create(ret);
> >
> > -    return E_NOTIMPL;
> > +    TRACE("(%p) -> (%x)\n", ret, res);
> > +
> > +    return res;
> >
> > }
>
> That's an unusual way to arrange things. Why don't you return as "return
> direct3d8_create();" ?

I did this so I can trace the return value. Since it's a wrapper with nearly 
no own code I figured it makes sense. Is this unneeded? Because if so, I'll 
change that.

Regards,
Fabian Maurer