October 2022 - Wine-gitlab - list.winehq.org

[PATCH v2 0/1] MR1011: user32: Correctly detect and assign an int resource
by Alistair Leslie-Hughes (＠alesliehughes) 11 Oct '22

11 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53646 Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v2: user32: Correctly detect and assign an int resource https://gitlab.winehq.org/wine/wine/-/merge_requests/1011

3 3

[PATCH v25 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 11 Oct '22

11 Oct '22

this gets the YSDrv service to start successfully (with the MmAllocateContiguousMemorySpecifyCache semi-stub) this service is used by the nox android emulator -- v25: ntoskrnl.exe: KeInsertQueueDpc stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/778

3 2

[PATCH v22 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 11 Oct '22

11 Oct '22

this gets the YSDrv service to start successfully (with the MmAllocateContiguousMemorySpecifyCache semi-stub) this service is used by the nox android emulator -- v22: ntoskrnl: KeInsertQueueDpc stub https://gitlab.winehq.org/wine/wine/-/merge_requests/778

3 2

[PATCH 0/1] MR1028: nsi: Use the correct members for the error and discard counts.
by Huw Davies (＠huw) 11 Oct '22

11 Oct '22

This is instead of !984. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1028

3 2

[PATCH v2 0/2] MR1026: shell32: Handle drive letters properly when parsing MyComputer.
by Gabriel Ivăncescu 11 Oct '22

11 Oct '22

-- v2: shell32: Handle drive letters properly when parsing MyComputer. shell32/tests: Test drive letters parsing for My Computer. https://gitlab.winehq.org/wine/wine/-/merge_requests/1026

2 3

[PATCH v3 0/6] MR1025: ntdll: Support memory address requirements in NtAllocateVirtualMemoryEx()
by Paul Gofman (＠gofman) 11 Oct '22

11 Oct '22

Various notes: - LowestStartingAddress is still unsupported; - Patch 5 ("wow64: Set HighestEndingAddress in wow64_NtAllocateVirtualMemoryEx() if it is absent") is fixing existing WOW issue: NtAllocateVirtualMemoryEx() called from wow64 currently does not constraing the allocation to 32 bit address space (wow64_NtAllocateVirtualMemory() passes zero_bits for that). - I initially thought of using a single inter process APC but added a different one due to zero_bits handling which is easier to convert in the target process. -- v3: ntdll: Support specified alignment in NtAllocateVirtualMemoryEx(). wow64: Set HighestEndingAddress in wow64_NtAllocateVirtualMemoryEx() if it is absent. wow64: Support MEM_ADDRESS_REQUIREMENTS in wow64_NtAllocateVirtualMemoryEx(). ntdll/tests: Add tests for memory address requiements. https://gitlab.winehq.org/wine/wine/-/merge_requests/1025

3 11

[PATCH 0/2] MR1026: shell32: Handle drive letters properly when parsing MyComputer.
by Gabriel Ivăncescu 11 Oct '22

11 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1026

2 3

[PATCH v3 0/6] MR965: jscript/mshtml: Enumeration fixes.
by Gabriel Ivăncescu 11 Oct '22

11 Oct '22

-- v3: mshtml: Enumerate document elements with name. mshtml: Split the lookup for an element with name into a separate helper. mshtml: Do not enumerate internal dynamic props. mshtml: Fix enumerating first custom prop after builtins. jscript: Refill the props at end of enumeration in html mode and retry. jscript: Fill the builtin props for enumeration on prototypes as well. https://gitlab.winehq.org/wine/wine/-/merge_requests/965

3 13

[PATCH v2 0/4] MR980: wintrust: Support WSS_GET_SECONDARY_SIG_COUNT in singature settings in WinVerifyTrust().
by Paul Gofman (＠gofman) 11 Oct '22

11 Oct '22

Nvidia's Streamline library depends on that (https://github.com/NVIDIAGameWorks/Streamline/) -- v2: wintrust: Support WSS_GET_SECONDARY_SIG_COUNT in Softpub provider. wintrust: Load secondary signatures in SoftpubLoadSignature(). https://gitlab.winehq.org/wine/wine/-/merge_requests/980

3 5

Re: [PATCH v6 0/1] MR23: shell32: Sanitize Program Manager icon and group names
by Huw Davies (＠huw) 10 Oct '22

10 Oct '22

Huw Davies (@huw) commented about dlls/shell32/dde.c: > } > if (argc >= 2) > { > - len = lstrlenW(last_group) + 1 + lstrlenW(argv[1]) + 5; > - name = heap_alloc(len * sizeof(*name)); > - swprintf( name, len, L"%s/%s.lnk", last_group, argv[1] ); > + name = combine_path(last_group, argv[1], L".lnk", TRUE); > } > else > { > - const WCHAR *filename = PathFindFileNameW(argv[0]); > - len = PathFindExtensionW(filename) - filename; > - name = heap_alloc((lstrlenW(last_group) + 1 + len + 5) * sizeof(*name)); > - swprintf( name, lstrlenW(last_group) + 1 + len + 5, L"%s/%.*s.lnk", last_group, len, filename ); > + WCHAR *filename = PathFindFileNameW(argv[0]); > + *PathFindExtensionW(filename) = '\0'; You're modifying `argv[0]` here which is pretty ugly. More broadly, you might find things easier if you add the `combine_path()` helper without the `sanitize` param in a first commit and then turn on the sanitizing in a second commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/23#note_10235

1 0