October 2022 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR957: rpcrt4: MIDL_STUB_MESSAGE needs to keep a refcount on IRpcChannelBuffer.
by Kevin Puetz (＠puetzk) 10 Oct '22

10 Oct '22

On Mon Oct 10 21:33:57 2022 +0000, Huw Davies wrote: > This looks correct to me, however afaict, Windows also sets > `stubMessage.pRpcChannelBuffer` to `NULL` when it releases it, so it > would be good to have a test for that, as well as it added to the implementation. > It would be clearer to split this into two commits: the first commit > would contain just the tests with appropriate `todo_wine`s. A second > commit would then add the implementation changes and remove the > `todo_wine`s. That way it's clear what the new changes are fixing. Ok, easy to do -- https://gitlab.winehq.org/wine/wine/-/merge_requests/957#note_10232

1 0

[PATCH v5 0/1] MR745: ntdll: Improve stub of NtQueryEaFile.
by Joel Holdsworth (＠jhol) 10 Oct '22

10 Oct '22

Based on a patch by Qian Hong. -- v5: ntdll: Improve stub of NtQueryEaFile. https://gitlab.winehq.org/wine/wine/-/merge_requests/745

4 7

Re: [PATCH v2 0/1] MR957: rpcrt4: MIDL_STUB_MESSAGE needs to keep a refcount on IRpcChannelBuffer.
by Huw Davies (＠huw) 10 Oct '22

10 Oct '22

Huw Davies (@huw) commented about dlls/rpcrt4/tests/cstub.c: > + /* stubMessage doesn't add its own refcounts on proxy_if1 or proxy_buffer, > + * so it's possible these are freed out from under it. > + * E.g. an event sink might unadvise upon receiving the event it was waiting for; > + * this unadvise could be reentrant to Invoke because SendReceive pumps STA messages. > + * The source would then erase that conection point entry and Release the proxy. */ > + IRpcProxyBuffer_Disconnect(proxy_buffer); > + ok(test_chanbuf.RefCount == 1, "got %ld\n", test_chanbuf.RefCount); > + IRpcProxyBuffer_Release(proxy_buffer); > + refs = IUnknown_Release(proxy_if1); > + ok(refs == 0, "got %ld\n", refs); > + ok(test_chanbuf.RefCount == 1, "got %ld\n", test_chanbuf.RefCount); > + > + /* NdrProxyFreeBuffer must not dereference the the now-freed proxy_if1, > + * yet should still free the remaining reference on test_chanbuf */ > + NdrProxyFreeBuffer(proxy_if1, &stubMessage); > + ok(test_chanbuf.RefCount == 0, "got %ld\n", test_chanbuf.RefCount); This looks correct to me, however afaict, Windows also sets `stubMessage.pRpcChannelBuffer` to `NULL` when it releases it, so it would be good to have a test for that, as well as it added to the implementation. It would be clearer to split this into two commits: the first commit would contain just the tests with appropriate `todo_wine`s. A second commit would then add the implementation changes and remove the `todo_wine`s. That way it's clear what the new changes are fixing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/957#note_10221

1 0

Re: [PATCH v3 0/1] MR1005: ntdll: Fix GetTempPathW() call passing wrong unit for the buffer size
by Davide Beatrici (＠davidebeatrici) 10 Oct '22

10 Oct '22

@julliard Shouldn't the prefix have been `ntdll/tests`, for consistency with the other commits? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1005#note_10219

1 0

[PATCH 0/1] MR994: gdi32/tests: Mark tests failing randomly on Windows as flaky.
by Francois Gouget (＠fgouget) 10 Oct '22

10 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/994

4 4

[PATCH 0/1] MR1003: gdiplus: Use atomic write for releasing GpImage lock.
by Jinoh Kang (＠iamahuman) 10 Oct '22

10 Oct '22

This fixes data race in ARM/ARM64 platforms, and prevents potential memory access reordering by the compiler. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1003

6 13

Re: [PATCH v4 0/6] MR965: jscript/mshtml: Enumeration fixes. - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/965

1 0

Re: [PATCH v5 0/4] MR951: ntdll: Add initial support for DOS file attributes (attempt 3) - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/951

1 0

Re: [PATCH v2 0/1] MR1018: conhost: Fix tests on ReadConsole with CONSOLE_READCONSOLE_CONTROL. - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1018

1 0

Re: [PATCH v5 0/2] MR930: Add tests for GetConsoleTitle() and return correct title length - approved
by Alexandre Julliard (＠julliard) 10 Oct '22

10 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/930

1 0