October 2022 - Wine-gitlab - list.winehq.org

Re: [PATCH 0/1] MR182: winex11: Use XKB key names to map key codes to scan codes.
by Rémi Bernon 06 Oct '22

06 Oct '22

On Thu Oct 6 11:01:52 2022 +0000, Timo Zuccarello wrote: > After last day's discussion, I don't think anymore that it's necessary > to use XKB names to map to scancodes. @rbernon says the keycodes are > fixed across keyboard layouts and this seems to be the case for me as > well even with exotic and custom layouts. Rather something about the > keyboard layout detection may be broken and assigns incorrect scancodes. > I'll take another look at this and try to figure something out. Well, I believe it is not necessary in general when using standard X server, as I described in <https://www.winehq.org/pipermail/wine-devel/2020-October/175561.html>, but that doesn't cover more exotic use cases where the X scancodes aren't fixed. Like @julliard replied in that thread, when using VNC X server for instance the scancodes aren't fixed anymore and we need that logic to figure them out. The problem, in my opinion, comes from VNC simulating incorrect scancodes, as it recomputes them from the VKey it received (the protocol only sends VKey and and it then assumes its client keyboard layout is US), but I agree that nothing in the X specification guarantees that the scancodes are fixed and that it makes some sense to do that kind of detection. Maybe an acceptable solution would be to make that layout detection optional, and configurable through a `winecfg` option, so that by default we'd assume a standard X server with fixed scancodes, and optionally we'd keep support for layout detection (or the other way around but I think improving the most common case as a default would be better). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/182#note_10034

1 0

Re: [PATCH 0/1] MR182: winex11: Use XKB key names to map key codes to scan codes.
by Timo Zuccarello (＠timozuccarello) 06 Oct '22

06 Oct '22

After last day's discussion, I don't think anymore that it's necessary to use XKB names to map to scancodes. @rbernon says the keycodes are fixed across keyboard layouts and this seems to be the case for me as well even with exotic and custom layouts. Rather something about the keyboard layout detection may be broken and assigns incorrect scancodes. I'll take another look at this and try to figure something out. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/182#note_10032

1 0

Re: [PATCH 0/1] MR182: winex11: Use XKB key names to map key codes to scan codes. - closed
by Timo Zuccarello (＠timozuccarello) 06 Oct '22

06 Oct '22

This merge request was closed by Timo Zuccarello. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/182

1 0

[PATCH 0/1] MR1005: ntdll: fixed size passed to GetTempPathW
by Marcus Meissner (＠msmeissn) 06 Oct '22

06 Oct '22

Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1005

3 2

[PATCH 0/1] MR1009: winemenubuilder: Skip desktop integration for certain associations.
by Alex Henrie (＠alexhenrie) 05 Oct '22

05 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41275 A version of this patch has been in Wine Staging since March 2020. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1009

2 1

[PATCH 0/3] MR987: d3d9/tests: Mark tests failing randomly on Windows as flaky.
by Francois Gouget (＠fgouget) 05 Oct '22

05 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/987

4 5

[PATCH 0/2] MR981: dxgi/tests: Mark tests failing randomly on Windows as flaky.
by Francois Gouget (＠fgouget) 05 Oct '22

05 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/981

3 3

[PATCH 0/4] MR963: d3d8: Use a separate draw texture for managed resources.
by Zebediah Figura (＠zfigura) 05 Oct '22

05 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/963

3 5

[PATCH v5 0/2] MR1004: ntdll: Implement optional relative parameter of RtlDosPathNameToRelativeNtPathName_U_WithStatus
by Skryptonyte (＠Skryptonyte) 05 Oct '22

05 Oct '22

relative optional parameter will now be handled by setting the RelativeName of the relative struct to NT converted and collapsed relative path and the ContainingDirectory to an open handle of current working directory. CurDir is currently not implemented. -- v5: ntdll/tests: Tests for RtlDosPathNameToRelativeNtPathName_U_WithStatus ntdll: Implement handling of relative in RtlDosPathNameToRelativeNtPathName_U_WithStatus https://gitlab.winehq.org/wine/wine/-/merge_requests/1004

2 2

[PATCH v4 0/4] MR1004: ntdll: Implement optional relative parameter of RtlDosPathNameToRelativeNtPathName_U_WithStatus
by Skryptonyte (＠Skryptonyte) 05 Oct '22

05 Oct '22

relative optional parameter will now be handled by setting the RelativeName of the relative struct to NT converted and collapsed relative path and the ContainingDirectory to an open handle of current working directory. CurDir is currently not implemented. -- v4: ntdll/tests: Corrected and refactored tests https://gitlab.winehq.org/wine/wine/-/merge_requests/1004

4 8