November 2022 - Wine-gitlab

[PATCH v3 0/1] MR1551: SDL: Always make unique serial numbers
by Evan Tang (＠etang-cw) 29 Nov '22

29 Nov '22

Overcooked! All You Can Eat only adds new controllers if no existing controller has the same serial as it. SDL GUIDs mark the model of controller, but don't differentiate between multiple controllers of the same model. This is especially bad with Steam virtual controllers, which all have the same GUID. Switch to using SDL_JoystickGetSerial if available, and otherwise combining the GUID with the controller index -- v3: winebus.sys: Report unique serial numbers for SDL devices. https://gitlab.winehq.org/wine/wine/-/merge_requests/1551

2 1

[PATCH 0/4] MR1599: uiautomationcore: Add UI Automation event stubs.
by Connor McAdams (＠cmcadams) 29 Nov '22

29 Nov '22

Stub functions, no tests/implementation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1599

2 4

[PATCH v11 0/2] MR1268: wininet: Partially implement InternetSetFilePointer
by Jason Kuo (＠j20001970) 29 Nov '22

29 Nov '22

-- v11: wininet: Partially implement InternetSetFilePointer wininet/tests: Add InternetSetFilePointer tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1268

4 14

[PATCH v2 0/5] MR1597: localspl: More work toward moving code from winspool.drv
by Piotr Caban (＠piotr) 29 Nov '22

29 Nov '22

-- v2: localspl: Add lpr port extension. localspl: Add unixname port extension. localspl: Add pipe port extension. localspl: Fix parameters validation in FILE StartDocPort. localspl: Add printer port redirection extension. https://gitlab.winehq.org/wine/wine/-/merge_requests/1597

3 7

[PATCH 0/1] MR1587: wineps: Fix memory leaks on error paths in DrvDocumentPropertySheets (cppcheck).
by Alex Henrie (＠alexhenrie) 29 Nov '22

29 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1587

3 4

[PATCH 0/1] MR1326: winex11.drv: Don't ignore virtual EnterNotify events.
by Tim Clem (＠tclem) 29 Nov '22

29 Nov '22

I don't think we want to ignore virtual EnterNotify events. As per the spec, those happen when the cursor moves from an ancestor of the Wine window directly to one of its children. AFAICT, the only potential child of a Wine whole window is a drawable client for OpenGL or Vulkan. So I think we only get a virtual EnterNotify in two cases: 1. When using a window manager that adds decoration, we get one when moving from that decoration directly to the client window. 2. In situations where the cursor starts over an ancestor of a Wine window and moves directly to the client window. This can happen, e.g., when running without a window manager (or with one that doesn't create a desktop). In that case, moving the cursor from the root window to the client window will be a virtual EnterNotify. In both scenarios, ignoring the EnterNotify isn't usually a big deal, since there will be follow-up MotionNotify events. However, in case 2, if the window is mapped under the cursor and the user never moves the mouse, Wine is left very confused. (See MR !1250 for another attempted approach to that issue. There are other problems with the current approach, but I think this is correct regardless.) If there are potentially other child windows, we could limit this to cases where the event's `subwindow` is equal to the driver's window data's `client_window`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1326

3 3

[PATCH 0/5] MR1597: localspl: More work toward moving code from winspool.drv
by Piotr Caban (＠piotr) 29 Nov '22

29 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1597

2 6

[PATCH v2 0/1] MR1596: winspool: Don't tranlate port name to path in StartDocDlgW.
by Piotr Caban (＠piotr) 29 Nov '22

29 Nov '22

-- v2: winspool: Don't translate port name to path in StartDocDlgW. https://gitlab.winehq.org/wine/wine/-/merge_requests/1596

3 3

[PATCH 0/1] MR1595: gdi32: NULL terminate output string in CreateDCW.
by Piotr Caban (＠piotr) 29 Nov '22

29 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1595

4 3

[PATCH 0/1] MR1596: winspool: Don't tranlate port name to path in StartDocDlgW.
by Piotr Caban (＠piotr) 29 Nov '22

29 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1596

2 1