November 2022 - Wine-gitlab

[PATCH v2 0/1] MR1567: mountmgr: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) 30 Nov '22

30 Nov '22

-- v2: mountmgr: Use standard C functions for memory allocation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1567

2 1

[PATCH v4 0/4] MR1502: Draft: winevulkan: wow64 memory mapping using VK_EXT_external_memory_host
by Jacek Caban (＠jacek) 30 Nov '22

30 Nov '22

This MR implements memory mapping for wow64 using VK_EXT_external_memory_host. This has some problems (more below), but overall, it looks promising as a stopgap. It passes D3D tests and works fine in general. For proper solution, we'd need a new Vulkan extension. I experimented with a prototype extension https://github.com/KhronosGroup/Vulkan-Docs/pull/1906 and it looks like we can make it work, my WIP implementation is here https://gitlab.winehq.org/jacek/wine/-/tree/vulkan-map-placed. However, it would be nice to have a fallback working on existing drivers as well. The main problem of this MR is that it breaks Vulkan spec. The main rule it breaks is that according to spec, we should explicitly specify that we plan to use external memory when creating VkBuffer or VkImage. The problem is that we don't know if we will until we bind memory to the buffer. I tried some workarounds for that (delaying actual buffer creation, recreating buffer when needed). I got it mostly working and passing tests without validation errors, but it was more invasive than I'd like and still had other problems. I'd rather avoid that if possible. After looking at Mesa sources, I think that the way this MR breaks the spec should be harmless for its drivers. I don't have the hardware to test with Nvidia. If it works there, I'm tempted to ignore spec violation for now, given that the right path forward is VK_EXT_map_memory_placed anyway. Performance-wise, this MR is sub-optimal because we're limited in what memory types we can use. However, I ran Unigine benchmarks on radv and the difference was marginal. In case of Heaven, it was even slightly faster on wow64, which could be explained by 64-bit Vulkan driver being generally slightly faster, but the difference is too small to draw any conclusion. The last patch is not meant for (eventual) merge, but it's nice for testing the concept. It makes it possible to force using external memory in any kind of Wine build to experiment with its effects without need for wow64. To test that, just set `WINEVULKAN_EXTERNAL_MEMORY` environment variable. -- v4: winevulkan: Introduce debugging environment variables. winevulkan: Use VK_EXT_external_memory_host extension to map memory on wow64. https://gitlab.winehq.org/wine/wine/-/merge_requests/1502

3 5

[PATCH v2 0/1] MR1564: hhctrl: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) 30 Nov '22

30 Nov '22

-- v2: hhctrl: Use standard C functions for memory allocation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1564

2 2

[PATCH v6 0/5] MR1445: kernelbase: Fixes for the shared Software\Classes registry and Wow6432Node registry in general.
by Sven Baars (＠sbaars) 29 Nov '22

29 Nov '22

This reimplements all logic from the server in kernelbase, which is needed because Nt*Key ignores KEY_WOW64_32KEY. Unfortunately this requires a lot of server calls. The full branch can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-new The old approach that doesn't duplicate code to kernelbase can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-old I ran make_requests by the way, not sure if we should still leave that out with the gitlab workflow. -- v6: kernelbase: Recursively obtain the Wow6432Node parent. kernelbase: Add support for shared registry keys. kernelbase: Factor out the common parts of open_key() and create_key(). kernelbase: Reimplement create_key() using open_subkey(). kernelbase: Factor out opening a subkey. https://gitlab.winehq.org/wine/wine/-/merge_requests/1445

4 7

[PATCH 0/4] MR1601: dmstyle: Simplify parsing of a style track.
by Michael Stefaniuc (＠mstefani) 29 Nov '22

29 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53941 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1601

2 4

[PATCH v14 0/2] MR841: ntoskrnl.exe: processor change callback stubs
by Etaash Mathamsetty (＠etaash.mathamsetty) 29 Nov '22

29 Nov '22

required for mrac anti cheat -- v14: ntoskrnl.exe: Add KeDeregisterProcessorChangeCallback stub. ntoskrnl.exe: Add KeRegisterProcessorChangeCallback stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/841

2 2

Re: [PATCH v2 0/1] MR1556: d3dcompiler: Implement D3DDisassemble() using vkd3d-shader.
by Matteo Bruni (＠Mystral) 29 Nov '22

29 Nov '22

Looks good otherwise :thumbsup: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1556#note_17941

1 0

Re: [PATCH v2 0/1] MR1556: d3dcompiler: Implement D3DDisassemble() using vkd3d-shader.
by Matteo Bruni (＠Mystral) 29 Nov '22

29 Nov '22

Matteo Bruni (@Mystral) commented about dlls/d3dcompiler_43/compiler.c: > + { > + const char *ptr = messages; > + const char *line; > + > + ERR("Shader log:\n"); > + while ((line = get_line(&ptr))) > + { > + ERR(" %.*s", (int)(ptr - line), line); > + } > + ERR("\n"); > + } > + > + vkd3d_shader_free_messages(messages); > + } > + > + if (ret) return hresult_from_vkd3d_result(ret); Tiny nitpick: can you move the return to its own line? ```suggestion:-0+0 if (ret) return hresult_from_vkd3d_result(ret); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1556#note_17940

1 0

Re: [PATCH v2 0/3] MR1555: wshom.ocx: Add WShNetwork. - approved
by Alexandre Julliard (＠julliard) 29 Nov '22

29 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1555

1 0

Re: [PATCH v3 0/3] MR1575: include: Add __WINE_(DEALLOC|MALLOC) attributes to wine_get_(dos|unix)_file_name. - approved
by Alexandre Julliard (＠julliard) 29 Nov '22

29 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1575

1 0