December 2022 - Wine-gitlab

[PATCH v2 0/2] MR1851: winhttp: Only read server reply in send_request() if the whole request is available.
by Paul Gofman (＠gofman) 20 Dec '22

20 Dec '22

Fixes a regression introduced by aa8f97e8294b0618de0e8a45ff2adef0c4e516da. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54184 For the requests which involve additional data to be sent the application might use WinHttpWriteData() before WinHttpReceiveResponse() to pass the additional request data instead of providing the optional data to WinHttpSendRequest(). In that case server reply can't be read in send_request(). I believe the first patch straightens up state handling in receive_response() by introducing a single switch processing every incoming state and avoiding additional local variable (along with making WINHTTP_CALLBACK_STATUS_RECEIVING_RESPONSE notification handling less obscure). -- v2: winhttp: Only read server reply in send_request() if the whole request is available. https://gitlab.winehq.org/wine/wine/-/merge_requests/1851

3 5

[PATCH 0/3] MR1854: httpapi: Allow passing NULL size to request reading functions.
by Zebediah Figura (＠zfigura) 20 Dec '22

20 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1854

2 3

Re: [PATCH v3 0/1] MR1769: winecrt0: Avoid predefined BOOL in get_relocbase - closed
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

This merge request was closed by Gerald Pfeifer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1769

1 0

Re: [PATCH v3 0/1] MR1769: winecrt0: Avoid predefined BOOL in get_relocbase
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

Yes, this now builds -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1769#note_19905

1 0

Re: [PATCH v3 0/1] MR1769: winecrt0: Avoid predefined BOOL in get_relocbase
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

On Tue Dec 20 02:41:21 2022 +0000, Alexandre Julliard wrote: > This should be superseded by f69c11117ee56cb664bd0ade1392c5553ff2af30. Yes, after that commit this now builds fine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1769#note_19904

1 0

Re: [PATCH v4 0/66] MR1849: winebus.sys: Declare a variable only when used - closed
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

This merge request was closed by Gerald Pfeifer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1849

1 0

Re: [PATCH v2 0/0] MR1849: winebus.sys: Declare a variable only when used - closed
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

This merge request was closed by Gerald Pfeifer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1849

1 0

[PATCH 0/1] MR1849: winebus.sys: Declare a variable only when used
by Gerald Pfeifer (＠gerald) 20 Dec '22

20 Dec '22

udev_add_device declares a variable (product) even when it is not used on all platforms. Use the same condition for the declaration that already guards the code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1849

2 4

Re: [PATCH v3 0/1] MR1421: include: add c++ header guards in pathcch
by Zhiyi Zhang (＠zhiyi) 20 Dec '22

20 Dec '22

Zhiyi Zhang (@zhiyi) commented about include/pathcch.h: > HRESULT WINAPI PathCchStripPrefix(WCHAR *path, SIZE_T size); > HRESULT WINAPI PathCchStripToRoot(WCHAR *path, SIZE_T size); > BOOL WINAPI PathIsUNCEx(const WCHAR *path, const WCHAR **server); > + > +#ifdef __cplusplus > +} > +#endif Please add a new line here -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1421#note_19897

1 0

[PATCH 0/2] MR1851: winhttp: Only read server reply in send_request() if the whole request is available.
by Paul Gofman (＠gofman) 20 Dec '22

20 Dec '22

Fixes a regression introduced by aa8f97e8294b0618de0e8a45ff2adef0c4e516da. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54184 For the requests which involve additional data to be sent the application might use WinHttpWriteData() before WinHttpReceiveResponse() to pass the additional request data instead of providing the optional data to WinHttpSendRequest(). In that case server reply can't be read in send_request(). I believe the first patch straightens up state handling in receive_response() by introducing a single switch processing every incoming state and avoiding additional local variable (along with making WINHTTP_CALLBACK_STATUS_RECEIVING_RESPONSE notification handling less obscure). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1851

2 2