December 2022 - Wine-gitlab

Re: [PATCH v2 0/1] MR1831: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H - approved
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1831

1 0

[PATCH 0/1] MR1845: winhttp: Check for NULL lpszAutoConfigUrl in WinHttpGetProxyForUrl().
by Paul Gofman (＠gofman) 19 Dec '22

19 Dec '22

Fixes a regression introduced by cbfe940a1eaf5e158de3127b1265462bfbfb70af. Might be related to https://bugs.winehq.org/show_bug.cgi?id=54055, I don't yet have the confirmation but this is something probably worth fixing regardless. lpszAutoConfigUrl is used whenever WINHTTP_AUTOPROXY_CONFIG_URL is specified, regardless of WINHTTP_AUTOPROXY_AUTO_DETECT presence. Before cbfe940a1eaf5e158de3127b1265462bfbfb70af NULL lpszAutoConfigUrl went directly to GetAddrInfoW(). Now with the timeout it is relayed to aync name resolution thread and might be crashing in wcsdup(). It doesn't happen all the time as we might not be reaching download_script() at all due to prior WinHttpDetectAutoProxyConfigUrl() legitimate failure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1845

3 2

[PATCH v2 0/3] MR1824: Remove broken from some color tests that can also fail on Linux.
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

They fail on the Gitlab CI. An alternative would be to mark them todo_wine but it's not clear that there's anything we want to do here. -- v2: d3d9/tests: Mark some of the depth bias tests as todo. d3d9/tests: Mark a zero-size pixel test as todo. d3d8/tests: Mark a zero-size pixel test as todo. https://gitlab.winehq.org/wine/wine/-/merge_requests/1824

3 4

Re: [PATCH v3 0/1] MR1421: include: add c++ header guards in pathcch
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

Please use your full name in the git commit info, so that it matches your Gitlab account. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1421#note_19862

1 0

[PATCH 0/1] MR1837: wined3d: Recognize AMD as a vendor string
by Ryan Hendrickson (＠rhendric) 19 Dec '22

19 Dec '22

I have an AMD Ryzen 7 5700U, which when my system was running Mesa 22.0.4 identified itself in `glxinfo` as: ``` Vendor: AMD (0x1002) Device: AMD RENOIR (LLVM 13.0.1, DRM 3.47, 5.19.17) (0x164c) ``` After a recent system upgrade that took Mesa to 22.2.3, `glxinfo` now gives: ``` Vendor: AMD (0x1002) Device: RENOIR (renoir, LLVM 14.0.6, DRM 3.48, 6.0.12) (0x164c) ``` Wine programs also started reliably crashing on me, with the following message that did not appear before: ``` 0130:fixme:d3d:wined3d_guess_card_vendor Received unrecognized GL_VENDOR "AMD". Returning HW_VENDOR_NVIDIA. ``` I don't really know what I'm doing but that message suggested this patch to me, which does resolve the crashes and doesn't seem obviously wrong. Maybe there's some other table to which the new identifying information of this APU needs to be added, but keeping this check for future-proofing might still be a good idea in that case? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1837

4 5

[PATCH 0/2] MR1824: Remove broken from some color tests that can also fail on Linux.
by Alexandre Julliard (＠julliard) 19 Dec '22

19 Dec '22

They fail on the Gitlab CI. An alternative would be to mark them todo_wine but it's not clear that there's anything we want to do here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1824

4 6

[PATCH v3 0/8] MR1842: dinput/tests: Wait for each device interface to start / stop and misc test cleanup.
by Rémi Bernon 19 Dec '22

19 Dec '22

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53525 -- v3: dinput/tests: Remove unnecessary goto and label. dinput/tests: Wait for each device interface to start / stop. dinput/tests: Add a device count parameter to hid_device_(start|stop). dinput/tests: Use semaphores to count and notify rawinput messages. dinput/tests: Avoid using INFINITE timeouts. dinput/tests: Remove old physical joystick tests. dinput/tests: Unregister rawinput devices after tests. hidclass.sys: Make sure a desktop is created for the driver process. https://gitlab.winehq.org/wine/wine/-/merge_requests/1842

2 10

[PATCH 0/3] MR1844: win32u/tests: Add some pointer related syscall tests.
by Rémi Bernon 19 Dec '22

19 Dec '22

Pretty much the same as https://gitlab.winehq.org/wine/wine/-/merge_requests/1843, but on win32u side, to figure and validate the syscall entry signatures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1844

1 3

[PATCH v2 0/5] MR1843: user32: Add more EnableMouseInPointer / GetPointerType / GetPointerInfo tests.
by Rémi Bernon 19 Dec '22

19 Dec '22

Checking the expected basic behavior, for https://bugs.winehq.org/show_bug.cgi?id=51537 and https://bugs.winehq.org/show_bug.cgi?id=53847. -- v2: user32/tests: Test GetPointer(Frame)Info(History) behavior. user32/tests: Move old GetPointerType tests into test_GetPointerInfo. user32/tests: Test GetPointerInfo behavior with EnableMouseInPointer. user32/tests: Test IsMouseInPointerEnabled behavior. user32/tests: Test EnableMouseInPointer behavior. https://gitlab.winehq.org/wine/wine/-/merge_requests/1843

1 6

[PATCH v2 0/7] MR1842: dinput/tests: Wait for each device interface to start / stop and misc test cleanup.
by Rémi Bernon 19 Dec '22

19 Dec '22

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53525 -- v2: dinput/tests: Wait for each device interface to start / stop. dinput/tests: Add a device count parameter to hid_device_(start|stop). dinput/tests: Use semaphores to count and notify rawinput messages. dinput/tests: Avoid using INFINITE timeouts. dinput/tests: Remove old physical joystick tests. dinput/tests: Unregister rawinput devices after tests. hidclass.sys: Make sure a desktop is created for the driver process. https://gitlab.winehq.org/wine/wine/-/merge_requests/1842

2 10