December 2022 - Wine-gitlab

[PATCH v4 0/6] MR1682: d3dx9: Partially implement texture filling using texture shaders.
by Nikolay Sivov (＠nsivov) 16 Dec '22

16 Dec '22

-- v4: d3dx9: Partially implement D3DXFillCubeTextureTX(). d3dx9: Fix ARGB texture fills with negative component values. d3dx9/tests: Add a helper to compare filled cube textures. d3dx9: Partially implement D3DXFillTextureTX(). d3dx9: Create parameter evaluator for texture shaders. d3dx9/preshader: Set input table size for texture shaders. https://gitlab.winehq.org/wine/wine/-/merge_requests/1682

2 6

[PATCH 0/1] MR1828: winex11: Check pixel format flags in X11DRV_wglChoosePixelFormatARB.
by Rémi Bernon 16 Dec '22

16 Dec '22

The check was dropped in e392e0ac2846edc25610723c19d6a796372017e1, leaving the dwFlags variable unused. I have no idea if it was indeed unnecessary or if it was dropped by mistake but either we need to keep the check, or we should remove the variable. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1828

2 3

[PATCH 0/3] MR1830: Fixing some debugger tests when run on Windows.
by eric pouech (＠epo) 16 Dec '22

16 Dec '22

Since test errors reported in MR!1823, I gave a spin at scheding some light on these errors. This series shall fix a couple of them, even there are still a couple standing (eg. https://testbot.winehq.org/JobDetails.pl?Key=127712) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1830

2 3

[PATCH v2 0/2] MR1829: user32/tests: Don't expect WM_DISPLAYCHANGE with the default display mode.
by Rémi Bernon 16 Dec '22

16 Dec '22

It looks like the behavior changes when only this test is run vs when it is run as part of the winetest suite. This is probably because ChangeDisplaySettingsExW only sends the message the first time it is called (since boot?). Having other tests run before it, one of them probably changed display settings already and we're not getting the message anymore. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53894 -- v2: user32/tests: Use %d to print last_bpp instead of %u. user32/tests: Don't expect WM_DISPLAYCHANGE with the default display mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/1829

1 2

[PATCH 0/1] MR1829: user32/tests: Don't expect WM_DISPLAYCHANGE with the default display mode.
by Rémi Bernon 16 Dec '22

16 Dec '22

It looks like the behavior changes when only this test is run vs when it is run as part of the winetest suite. This is probably because ChangeDisplaySettingsExW only sends the message the first time it is called (since boot?). Having other tests run before it, one of them probably changed display settings already and we're not getting the message anymore. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53894 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1829

2 2

[PATCH v2 0/3] MR1826: shell32: Add partial ControlPanel GetAttributesOf implementation.
by Piotr Caban (＠piotr) 16 Dec '22

16 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52394 -- v2: shell32: Fix SHChangeNotify test failures. shell32: Add partial ControlPanel GetAttributesOf implementation. shell32: Store NameSpace registry path in global variable. https://gitlab.winehq.org/wine/wine/-/merge_requests/1826

2 3

[PATCH 0/9] MR895: msxml3/tests: Filter attributes tests by version.
by Daniel Lehman (＠dlehman25) 16 Dec '22

16 Dec '22

Based on patch from Damjan Jovanovic <damjan.jov(a)gmail.com> https://bugs.winehq.org/show_bug.cgi?id=53531 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/895

2 10

[PATCH 0/1] MR1827: ntdll: Add basic support for application configuration files
by Johnny Cai (＠jaihysc) 15 Dec '22

15 Dec '22

Some applications have a `<name>.exe.config` file with the element `<probing>` to specify additional directories to search for assemblies. As it is not handled in wine, these applications fail to load. To keep this commit simple, it only supports probing. The other parts of the application configuration file are unimplemented. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1827

2 1

[PATCH v2 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 15 Dec '22

15 Dec '22

## Summary Tests for UrlFixupW and semi stub function implementaion. ## Test results - Tests are 100% ok on my local WIN 10 pc. Wine test bot seems to be okay too. - Wine tests on debian machine | function type | result | | ------ | ------ | | stub | 0020:url: 69802 tests executed (0 marked as todo, 0 as flaky, **200** failures), 0 skipped. | | semi stub| 0020:url: 69802 tests executed (0 marked as todo, 0 as flaky, **100** failures), 0 skipped. | ## Todos For follow up merge request(s). - [ ] Add more tests for priority investigation, who url scheme fix up is working on windows. - [ ] Implement missing parts of fix up. ## Conclusion Semi stub implementation is an improvement to the existing solution. A grep showed that wine internals do not call this function, therefore it should not introduce any new bugs. Windows applications using/relying on the function should now work better, if not they may reveal already existing bugs. -- v2: shlwapi/tests: Mark tests as todo for UrlFixupW. https://gitlab.winehq.org/wine/wine/-/merge_requests/1825

2 3

Re: [PATCH v2 0/1] MR1823: dlls/kernel32/test: Fix a debugger test failing on Windows. - approved
by Alexandre Julliard (＠julliard) 15 Dec '22

15 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1823

1 0