December 2022 - Wine-gitlab

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Zebediah Figura (＠zfigura) 18 Dec '22

18 Dec '22

Hi Thomas, thanks for the patch! We want the tests to "pass" after every commit, i.e. have no failures. That may mean, in this case, introducing the tests marked as todo, and then later removing those todos. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19803

1 0

[PATCH 0/4] MR1755: refcount return voiding
by Max Figura (＠maxfigura) 18 Dec '22

18 Dec '22

Setting the return type of various wined3d refcounting functions to void These patches modify: - wined3d_incref - wined3d_decref - wined3d_resource_incref - wined3d_resource_decref -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1755

4 9

[PATCH 0/3] MR1836: DMusic: Implement the IDirectMusicSegment8_Clone() and semi-stub the IDirectMusicChordMap_ComposeSegmentFromTemplate() methods.
by Michael Stefaniuc (＠mstefani) 18 Dec '22

18 Dec '22

Fixes https://bugs.winehq.org/show_bug.cgi?id=53941 Should be a fairly safe change as both methods were returning S_OK without touching the return pointer. Also Chicken Tournament is the first application in my collection that uses those methods. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1836

2 3

[PATCH 0/1] MR1835: po: Update Japanese translation.
by Akihiro Sagawa (＠sgwaki) 18 Dec '22

18 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1835

2 1

[PATCH 0/1] MR1834: include: Add recent DirectWrite API changes.
by Nikolay Sivov (＠nsivov) 17 Dec '22

17 Dec '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1834

2 1

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 17 Dec '22

17 Dec '22

On Sat Dec 17 10:41:32 2022 +0000, Etaash Mathamsetty wrote: > I also think you should squash c4e27bd0483c0a1fb872111b6c03b9ad240d85da > (mark tests as todo) and d02be967f9cca0805b5eeaef6a74b3ec51a67619 (add > tests) into one commit I can do so, but before semi stub implementation even more tests are failing. See description. Should i squash mark all tests as todo and remove the markers with semi stub commit? Thanks for your help. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19792

1 0

[PATCH 0/1] MR1833: libs/wine: Only define exe_link when needed
by Gerald Pfeifer (＠gerald) 17 Dec '22

17 Dec '22

Revision 24b26f8bd6a49c855eec417a6585d44c9458e3ec changed FreeBSD (and DragonFly) not to use /proc any longer. Hence we also do not need the exe_link variable on those two platforms, either. Avoid declaring it there. (This avoids a compiler warning about an unused variable with GCC 12.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1833

2 1

[PATCH 0/1] MR1831: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H
by Gerald Pfeifer (＠gerald) 17 Dec '22

17 Dec '22

find_device_from_devnode was unnecessarily guarded by HAVE_SYS_INOTIFY_H, alas its use in process_monitor_event was not, so linking failed. Simply make find_device_from_devnode generally available. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1831

3 2

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 17 Dec '22

17 Dec '22

On Thu Dec 15 20:00:54 2022 +0000, Etaash Mathamsetty wrote: > you should mark them as todo in the code for the tests then I can do so, but before semi stub implementation even more tests are failing. See description. Should i squash mark all tests as todo and remove the markers with semi stub commit? Thanks for your help. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19782

1 0

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Etaash Mathamsetty (＠etaash.mathamsetty) 17 Dec '22

17 Dec '22

I also think you should squash c4e27bd0483c0a1fb872111b6c03b9ad240d85da (mark tests as todo) and d02be967f9cca0805b5eeaef6a74b3ec51a67619 (add tests) into one commit -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19781

1 0