December 2022 - Wine-gitlab

[PATCH 0/1] MR1580: winex11.drv: Hide invisible owner windows that have visible owned windows in pager.
by Zhiyi Zhang (＠zhiyi) 28 Feb '23

28 Feb '23

Manual tests on XP, Win7 and Win10 show that such windows are not shown in pager. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1580

3 3

[PATCH 0/1] MR1240: gitlab: Run related tests on every commit.
by Rémi Bernon 24 Feb '23

24 Feb '23

This restores the feature we had with the testbot running related on intermediate commits, though it only does it on Linux and it would be nice to have it on Windows too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1240

1 2

[PATCH 0/1] MR533: xactengine3_7/tests: Test wave bank pointer also when creating one.
by Giovanni Mascellani (＠giomasce) 20 Feb '23

20 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/533

3 3

[PATCH v10 0/1] MR1145: kernel32: Implement various transacted file APIs.
by Etaash Mathamsetty (＠etaash.mathamsetty) 11 Feb '23

11 Feb '23

a hotfix for the recent release of Persona 5 Royal. -- v10: kernel32: Implement various transacted file APIs https://gitlab.winehq.org/wine/wine/-/merge_requests/1145

4 3

[PATCH 0/1] MR997: win32u: fix Arabic-English mix texts missed chars
by Mosaab Alzoubi (＠moceap) 11 Feb '23

11 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/997

4 5

[PATCH 0/1] MR1665: kernelbase: Let GetFileInformationByHandle succeed on unix redirected handle.
by eric pouech (＠epo) 07 Feb '23

07 Feb '23

As these handles to a file don't have an unix-name attached, the FileAllInformation query fails. So only implement GetFileInformationByHandle() on top of queries which don't fail. I tested if the three ntdll calls instead of one did impact performance. On cached handles they don't: a simple x100000 loop even shows a ~10% improvement, likely because we don't grab the filename from wineserver. Note: that NtQueryInformationFile(FileAllInformation) (as other queries returning file's name) will still fail on these unix-redirected handles. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51813 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1665

7 15

[PATCH 0/1] MR1764: inetmib1: Get rid of GCC12 warning.
by eric pouech (＠epo) 06 Feb '23

06 Feb '23

Code assumes that tableIndex is never 0, while GCC cannot infer it. So include tableIndex=0 case into already handled error cases. GCC/Mingw complains with: /home/eric/work/wine/dlls/inetmib1/main.c: In function 'mib2IfEntryQuery': /home/eric/work/wine/dlls/inetmib1/main.c:646:25: warning: array subscript 4294967295 is above array bounds of 'MIB_IFROW[1]' {aka 'struct _MIB_IFROW[1]'} [-Warray-bounds] 646 | &ifTable->table[tableIndex - 1], item, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /home/eric/work/wine/include/ipmib.h:21, from /home/eric/work/wine/include/iprtrmib.h:24, from /home/eric/work/wine/include/iphlpapi.h:25, from /home/eric/work/wine/dlls/inetmib1/main.c:30: /home/eric/work/wine/include/ifmib.h:66:15: note: while referencing 'table' 66 | MIB_IFROW table[1]; Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1764

3 3

[PATCH 0/1] MR978: kernelbase: Fix uninitialized return value in GetModuleHandleA().
by eric pouech (＠epo) 06 Feb '23

06 Feb '23

GCC (MingW) 12.2 rightfully warns with: /home/eric/work/wine/dlls/kernelbase/loader.c: In function 'GetModuleHandleA': /home/eric/work/wine/dlls/kernelbase/loader.c:332:12: warning: 'ret' may be used uninitialized [-Wmaybe-uninitialized] 332 | return ret; | ^~~ /home/eric/work/wine/dlls/kernelbase/loader.c:329:13: note: 'ret' declared here 329 | HMODULE ret; | ^~~ So set module to NULL on all error codepaths in GetModuleHandleExA(). Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/978

2 2

[PATCH 0/1] MR1765: krnl386.exe16: Get rid of GCC 12 warning.
by eric pouech (＠epo) 06 Feb '23

06 Feb '23

Mark args local variable with volatile to tell GCC not to check for out of bounds access. Alternative fix: use an intermediate variable to store &fun as an integer. MingW/GCC 12 complains with: In file included from /home/eric/work/wine/dlls/krnl386.exe16/thunk.c:36: /home/eric/work/wine/dlls/krnl386.exe16/thunk.c: In function 'SSCall': /home/eric/work/wine/include/wine/debug.h:91:4: warning: array subscript 1 is outside array bounds of 'INT_PTR (__attribute__((stdcall)) *[1])(void)' {aka 'int (__attribute__((stdcall)) *[1])(void)'} [-Warray-bounds] 91 | wine_dbg_log( __dbcl, __dbch, __func__, __VA_ARGS__); } } while(0) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/eric/work/wine/include/wine/debug.h:88:8: note: in expansion of macro '__WINE_DBG_LOG' 88 | __WINE_DBG_LOG | ^~~~~~~~~~~~~~ /home/eric/work/wine/include/wine/debug.h:463:36: note: in expansion of macro '__WINE_DPRINTF' 463 | #define WINE_TRACE __WINE_DPRINTF(_TRACE,__wine_dbch___default) | ^~~~~~~~~~~~~~ /home/eric/work/wine/include/wine/debug.h:506:36: note: in expansion of macro 'WINE_TRACE' 506 | #define TRACE WINE_TRACE | ^~~~~~~~~~ /home/eric/work/wine/dlls/krnl386.exe16/thunk.c:996:32: note: in expansion of macro 'TRACE' 996 | for (i = 0; i < nr/4; i++) TRACE("0x%08lx,",args[i]); | ^~~~~ /home/eric/work/wine/dlls/krnl386.exe16/thunk.c:989:17: note: at offset 4 into object 'fun' of size 4 989 | FARPROC fun, /* [in] function to call */ | ~~~~~~~~^~~ Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1765

3 3

[PATCH v2 0/5] MR1756: ntdll: Various performance improvements to hash_short_file_name.
by Rémi Bernon 06 Feb '23

06 Feb '23

The function is called a lot, I believe something like this would improve its performance in general. -- v2: ntdll: Lookup extension from the end in hash_short_file_name. ntdll: Use invalid char lookup table in lookup_unix_name. ntdll: Use invalid char lookup table in nt_to_unix_file_name_no_root. ntdll: Use invalid char lookup table in is_legal_8dot3_name. ntdll: Use invalid char lookup table in is_invalid_dos_char. https://gitlab.winehq.org/wine/wine/-/merge_requests/1756

1 7