December 2022 - Wine-gitlab

[PATCH 0/1] MR1859: winex11: Raise owned windows before setting input focus.
by Rémi Bernon 06 Feb '23

06 Feb '23

Installers based on InnoSetup use invisible window owning the main installer window. When focus is given to the installer window popup, window managers sometimes do not raise it as their owner is invisible and it stays below other windows unless they are minimized. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49933 This is not a regression and it is arguably perhaps a window manager bug, but it is also extremely annoying for users as installer windows tend to disappear from the pager, as well as missing from the window selector and below all other windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1859

1 2

[PATCH 0/1] MR1498: ntdll: Use RTLD_NOLOAD to find already mapped modules.
by Rémi Bernon 06 Feb '23

06 Feb '23

This makes it possible to detect modules that weren't unmapped from dlclose, and that we should not fixup again. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49640 This usually happens with C++ winelibs, where some C++ symbols may be inlined into the winelib, then later resolved in preference over other symbol definitions when libstdc++ loads. This results in circular dependency between the winelib and libstdc++, making dlclose no-op. In this case, reloading the lib later and calling `map_so_dll` on it again will fixup the RVAs again, ending up with invalid addresses. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1498

3 6

[PATCH v14 0/2] MR1268: wininet: Partially implement InternetSetFilePointer
by Jason Kuo (＠j20001970) 03 Feb '23

03 Feb '23

-- v14: wininet: Partially implement InternetSetFilePointer wininet/tests: Add InternetSetFilePointer tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1268

3 9

[PATCH 0/1] MR1749: mshtml: Add head, title and body elements to about:blank.
by Santino Mazza (＠tati1454) 28 Jan '23

28 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1749

4 6

[PATCH v2 0/2] MR145: kernel32: Unstub MoveFileWithProgress, add test.
by James McDonnell (＠ElementalWarrior) 27 Jan '23

27 Jan '23

-- v2: kernel32/tests: Implement test calling CopyFileExA with progress callback kernel32: Unstub MoveFileTransactedW, Use MoveFileWithProgressW https://gitlab.winehq.org/wine/wine/-/merge_requests/145

4 22

[PATCH 0/1] MR1167: wevtapi: Add EvtCreateBookmark stub.
by Mohamad Al-Jaf (＠maljaf) 27 Jan '23

27 Jan '23

The launcher of Warhammer 40,000: Darktide calls this function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1167

2 2

[PATCH 0/1] MR993: ieframe/tests: Mark tests failing randomly on Windows as flaky.
by Francois Gouget (＠fgouget) 26 Jan '23

26 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/993

3 4

[PATCH 0/1] MR1855: makedep: Make output_filename more resilient
by Gerald Pfeifer (＠gerald) 26 Jan '23

26 Jan '23

In early November 2022 builds on FreeBSD 12/amd64 saw makedep core dump 1791 times due to it being invoked with a NULL pointer. Turns out it did not validate its input for being non-NULL, so add such a check and add a diagnostics. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1855

3 3

[PATCH v7 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync.
by Mohamad Al-Jaf (＠maljaf) 25 Jan '23

25 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53176 1) The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general. 2) The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files. 3) All the check_bool_async tests return a random async_id so I skipped them. Testbot example: https://testbot.winehq.org/JobDetails.pl?Key=127232&f208=exe32.report#k208 -- v7: cryptowinrt/tests: Add IKeyCredentialManagerStatics_IsSupportedAsync tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

3 13

[PATCH v8 0/3] MR1686: include/msvcrt: Add __WINE_(ALLOC_SIZE|DEALLOC|MALLOC) attributes to _strdup, _wcsdup, _aligned_malloc
by Brendan Shanks (＠bshanks) 25 Jan '23

25 Jan '23

-- v8: include/msvcrt: Add __WINE_(ALLOC_SIZE|DEALLOC) attributes to _recalloc. include/msvcrt: Add __WINE_(ALLOC_SIZE|DEALLOC|MALLOC) attributes to _aligned_malloc functions. include/msvcrt: Add __WINE_(DEALLOC|MALLOC) attributes to _strdup and _wcsdup. https://gitlab.winehq.org/wine/wine/-/merge_requests/1686

5 7