December 2022 - Wine-gitlab

[PATCH v3 0/4] MR1635: jscript: Implement a Garbage Collector to deal with circular references.
by Gabriel Ivăncescu 05 Dec '22

05 Dec '22

Implement a basic GC based on the mark-and-sweep algorithm, without requiring manually specifying "roots", which vastly simplifies the management. For now, it is triggered every 30 seconds since it last finished, on a new object initialization. Better heuristics could be used in the future. The comments in the code should hopefully understand the high level logic of this approach without boilerplate details. I've tested it on FFXIV launcher (along with other patches from Proton to have it work) and it stops the massive memory leak successfully by itself, so at least it does its job properly. The last patch in the MR is just an optimization for a *very* common case. For artificial testing, one could use something like: ```javascript function leak() { var a = {}, b = {}; a.b = b; b.a = a; } ``` which creates a circular ref and will leak when the function returns. It also introduces and makes use of a "heap_stack", which prevents stack overflows on long chains. -- v3: jscript: Create the source function's 'prototype' prop object on demand. jscript: Run the garbage collector every 30 seconds on a new object jscript: Implement CollectGarbage(). jscript: Implement a Garbage Collector to deal with circular references. https://gitlab.winehq.org/wine/wine/-/merge_requests/1635

2 7

[PATCH 0/1] MR1680: win32u: Use WMCHAR_MAP_SENDMESSAGE for NtUserSendMessage.
by Sven Baars (＠sbaars) 05 Dec '22

05 Dec '22

This fixes a regression introduced by d42888f07c6e3e491c99bb5c8b62b568264e990c. Before this commit SendMessage* also used WMCHAR_MAP_SENDMESSAGE. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52877 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1680

3 2

[PATCH 0/1] MR1685: wine.inf: Register winprint print processor.
by Piotr Caban (＠piotr) 05 Dec '22

05 Dec '22

I'm not sure what's the best way of registering print processor. The alternative is to register winprint in winspool when driver is added. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1685

3 2

[PATCH v2 0/3] MR1683: loader: Support GDB hooking, and expose ld.so and PE modules in a wine-specific link map.
by Rémi Bernon 05 Dec '22

05 Dec '22

This makes it possible to debug Wine application in GDB almost like any other Unix application. Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/1074. -- v2: ntdll: Maintain a PE module link map and expose it to GDB. loader: Expose a shadow copy of ld.so link map to GDB. https://gitlab.winehq.org/wine/wine/-/merge_requests/1683

2 5

[PATCH 0/2] MR1667: winevulkan: Get rid of direct Unix calls.
by Jacek Caban (＠jacek) 05 Dec '22

05 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1667

4 5

[PATCH 0/1] MR1646: comctl32: Annotate (Re)Alloc with __WINE_(DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 05 Dec '22

05 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1646

4 3

Re: [PATCH v4 0/1] MR1602: rpcrt4: Use standard C functions for memory allocation. - approved
by Huw Davies (＠huw) 05 Dec '22

05 Dec '22

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1602

1 0

Re: [PATCH v12 0/6] MR42: vkd3d-shader/hlsl: Some fixes.
by Giovanni Mascellani (＠giomasce) 05 Dec '22

05 Dec '22

Giovanni Mascellani (@giomasce) commented about tests/object-references.shader_test: > + Texture2D tex2; > + float3 aa; > +}; > + > +float4 main() : sv_target > +{ > + struct apple a = {tex, tex, 1.0, 2.0, 3.0}; > + > + a.aa += f; > + return a.aa.xyzx; > +} > + > +[test] > +uniform 0 float 10.0 > +todo draw quad > +todo probe (0, 0) rgba (11.0, 12.0, 13.0, 11.0) I just noticed that the the PE shader runner fails an assertion when running this test inside Wine, using `VKD3D_TEST_PLATFORM=windows` and native `d3dcompiler`: ``` Assertion failed: root_signature_desc.NumParameters <= ARRAY_SIZE(root_params), file ../vkd3d/tests/shader_runner_d3d12.c, line 227 ``` @fcasas, could you have a look? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/42#note_18636

1 0

[PATCH 0/3] MR1683: loader: Support GDB hooking, and expose ld.so and PE modules in a wine-specific link map.
by Rémi Bernon 05 Dec '22

05 Dec '22

This makes it possible to debug Wine application in GDB almost like any other Unix application. Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/1074. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1683

2 4

[PATCH v2 0/8] MR1628: Draft: ntdll: Implement Low Fragmentation Heap.
by Rémi Bernon 05 Dec '22

05 Dec '22

Not completely sure if it's worth having for 8.0, but opening this to share the target I'm trying to reach. -- v2: ntdll: Implement Low Fragmentation Heap. ntdll: Introduce per-thread free lists for heap blocks. ntdll: Introduce a new BLOCK_FLAG_SPLIT heap block flag. ntdll: Introduce a new subheap thread affinity field. ntdll: Introduce a new heap block_init_used helper. ntdll: Introduce a new heap free_list_init helper. ntdll: Count allocations and automatically enable LFH. ntdll: Implement HeapCompatibilityInformation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1628

2 9