August 2022 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR680: maintainers: Remove advice about Cc'ing patches.
by Huw Davies (＠huw) 19 Aug '22

19 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/680

2 1

[PATCH v7 0/2] MR628: win32u: Fix the second_name parsed wrong.
by Jiajin Cui (＠jin-king1) 19 Aug '22

19 Aug '22

When first parsed to names in english and other non-native languages, after parsing to names in native languages, this will result in second_name not corresponding to names in english. Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- v7: win32u: Don't allow a replaced font to be a replacement. win32u: Ensure that either the primary or secondary name is in English. https://gitlab.winehq.org/wine/wine/-/merge_requests/628

3 4

[PATCH 0/3] MR679: scrrun: Correct string length returned from GetTempName.
by Robert Wilhelm (＠sloper42) 19 Aug '22

19 Aug '22

You have to pass string length without terminal null to SysAllocStringLen. This fixes following vbscript code: Temp_Path = strSystemRoot & "\" & fso.GetTempName() & ".vbs" Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53569 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/679

3 4

Re: [PATCH v8 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext - approved
by Hans Leidekker (＠hans) 19 Aug '22

19 Aug '22

This merge request was approved by Hans Leidekker. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677

1 0

Re: [PATCH v7 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext
by Konstantin (＠IncubusRK) 19 Aug '22

19 Aug '22

On Fri Aug 19 08:54:40 2022 +0000, Hans Leidekker wrote: > In the patch title please replace one occurrence of > kerberos_SpAcceptLsaModeContext with kerberos_SpInitLsaModeContext. > Otherwise the patch looks good. Pushed. Sorry, I did not notice a repetition in title. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6535

1 0

Re: [PATCH v6 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext
by Hans Leidekker (＠hans) 19 Aug '22

19 Aug '22

On Fri Aug 19 08:46:28 2022 +0000, Konstantin wrote: > Pushed In the patch title please replace one occurrence of kerberos_SpAcceptLsaModeContext with kerberos_SpInitLsaModeContext. Otherwise the patch looks good. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6533

1 0

Re: [PATCH v6 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext
by Konstantin (＠IncubusRK) 19 Aug '22

19 Aug '22

On Fri Aug 19 08:38:54 2022 +0000, Hans Leidekker wrote: > Yes. Pushed -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6532

1 0

Re: [PATCH v4 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext
by Hans Leidekker (＠hans) 19 Aug '22

19 Aug '22

On Fri Aug 19 08:32:04 2022 +0000, Konstantin wrote: > Do you mean this? > ``` > if ( status == SEC_E_OK || status == SEC_I_CONTINUE_NEEDED ) > *new_context = create_context_handle( context_handle, > new_context_handle ); > if (!status) > { > *mapped_context = TRUE; > ``` Yes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6529

1 0

Re: [PATCH v4 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext
by Konstantin (＠IncubusRK) 19 Aug '22

19 Aug '22

On Fri Aug 19 08:20:50 2022 +0000, Hans Leidekker wrote: > The change should be minimal, so only change the condition for the > new_context update. Please put spaces around operators like in the rest > of the file. > Please also fix the patch title while you're at it :) Do you mean this? ``` if ( status == SEC_E_OK || status == SEC_I_CONTINUE_NEEDED ) *new_context = create_context_handle( context_handle, new_context_handle ); if (!status) { *mapped_context = TRUE; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6528

1 0

Re: [PATCH v4 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext
by Hans Leidekker (＠hans) 19 Aug '22

19 Aug '22

On Fri Aug 19 07:54:25 2022 +0000, Konstantin wrote: > Tested the changes, kerberos auth in our client application work fine. The change should be minimal, so only change the condition for the new_context update. Please put spaces around operators like in the rest of the file. Please also fix the patch title while you're at it :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6527

1 0