August 2022 - Wine-gitlab - list.winehq.org

[PATCH 0/2] MR648: winspool.drv: Fix DocumentProperties function when printer name and driver name differs
by Piotr Caban (＠piotr) 16 Aug '22

16 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/648

3 3

Re: [PATCH v2 0/5] MR635: Draft: Implement transform graph. Partically implement effect drawing.
by Ziqing Hui (＠zhui) 16 Aug '22

16 Aug '22

> Node manipulation might be fine, I haven't checked it in full. However my impression was that we don't really need it right now? I believe I saw some examples where ID2D1DrawTransform is implemented for \*Impl object directly, for which runtime presumably calls SetDrawInfo, letting effect set back shaders and resources. Yeah, ID2D1DrawTransform can be implemented for *Impl object, that's true. But we still need transfrom graph. Implementing ID2D1DrawTransform for *Impl doesn't means that it will be used automatically without doing anything else. We still need to regard it as a transform node, and add it to transfrom graph. And latter, runtime will call SetDrawInfo for it because it is in transform graph. > Regarding prototyped drawing, creating render target on every draw seems wrong. It's possible you'll have to recreate something, but only when when parameters or inputs have changed. You are right. We should recreate things only when things are changed. I ignore it in this draft just to make things look simpler. I'll take this into consideration. Nikolay, do you think I can submit first 3 patches in another MR to make you have a full reviewing in order to upstream them? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/635#note_6269

1 0

Re: [PATCH v2 0/5] MR635: Draft: Implement transform graph. Partically implement effect drawing.
by Nikolay Sivov (＠nsivov) 15 Aug '22

15 Aug '22

Node manipulation might be fine, I haven't checked it in full. However my impression was that we don't really need it right now? I believe I saw some examples where ID2D1DrawTransform is implemented for *Impl object directly, for which runtime presumably calls SetDrawInfo, letting effect set back shaders and resources. Regarding prototyped drawing, creating render target on every draw seems wrong. It's possible you'll have to recreate something, but only when when parameters or inputs have changed. I certainly don't have a full picture of how this works, but shouldn't we be using MapOutputRectToInputRects() at some point? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/635#note_6266

1 0

[PATCH v2 0/1] MR647: winex11.drv: Make last_cursor per-thread.
by Paul Gofman (＠gofman) 15 Aug '22

15 Aug '22

Cursor (both the cursor itself and its visibility) are per thread on Windows and Wine's implementation outside of winex11.drv seem to agree with that. Using global cursor variable in winex11.drv leads to wrong cursor being set or set visible for a window when the app sets a cursor from the other thread. -- v2: winex11.drv: Set correct cursor when setting cursor from another thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/647

2 2

Re: [PATCH v4 0/9] MR646: win32u: Window messages improvements and wow64 support. - approved
by Alexandre Julliard (＠julliard) 15 Aug '22

15 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/646

1 0

Re: [PATCH v2 0/7] MR645: mfsrcsnk: Partially implement WAVE format sink. - approved
by Alexandre Julliard (＠julliard) 15 Aug '22

15 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/645

1 0

Re: [PATCH v2 0/1] MR644: vkd3d: Fix the signature of vkd3d_spirv_build_op_type_image - approved
by Alexandre Julliard (＠julliard) 15 Aug '22

15 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/644

1 0

Re: [PATCH v2 0/1] MR643: configure: Downgrade -Wincompatible-function-pointer-types to a warning on ARM - approved
by Alexandre Julliard (＠julliard) 15 Aug '22

15 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/643

1 0

Re: [PATCH v2 0/2] MR642: msvcp: Fix _Fiopen implementation - approved
by Alexandre Julliard (＠julliard) 15 Aug '22

15 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/642

1 0

Re: [PATCH v2 0/2] MR640: Hnetcfg fw rule - approved
by Alexandre Julliard (＠julliard) 15 Aug '22

15 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/640

1 0