September 2022 - Wine-gitlab

[PATCH v2 0/2] MR907: secur32: Implement basic functionality for LsaGetLogonSessionData.
by Owen Rudge (＠orudge) 22 Sep '22

22 Sep '22

This basic implementation is sufficient to fix .NET applications that use System.Security.Principal.WindowsIdentity.AuthenticationType. -- v2: secur32: Implement basic functionality for LsaGetLogonSessionData. https://gitlab.winehq.org/wine/wine/-/merge_requests/907

3 6

[PATCH 0/1] MR897: oleauto: dereference VT_RECORD|VT_BYREF in place
by Kevin Puetz (＠puetzk) 22 Sep '22

22 Sep '22

VariantCopyInd allows pvargDest == pvargSrc in order to dereference in place To avoid confusing the source values and a partially-written destination, wine's implementation makes a shallow copy and uses that as pSrc. However, the call to VARIANT_CopyIRecordInfo did not use this, leading to it copying from the zeroed-out memory it just allocated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/897

3 2

[PATCH 0/4] MR902: d3d9: Use a separate draw texture for managed resources.
by Zebediah Figura (＠zfigura) 22 Sep '22

22 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/902

4 6

[PATCH v2 0/1] MR848: ntoskrnl: KeIpiGenericCall semi-stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 22 Sep '22

22 Sep '22

fixes bug #48989 based on a patch that was made in that issue -- v2: ntoskrnl: KeIpiGenericCall semi-stub https://gitlab.winehq.org/wine/wine/-/merge_requests/848

2 4

[PATCH v17 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 21 Sep '22

21 Sep '22

Apex Legends game periodically (every 30 seconds) calls this function with up to 22k virtual addresses. All but 1 of them is valid. Due to amount of queries addresses, and cost of seek+read, this causes this function to take up to about 50ms. So framerate drops from ~150 FPS to 20FPS for about a second. As far as I can see, returning 0 entries from this function, still makes Apex Legend work. But keep code correct, and optimise it by: 1. Opening pagemap file once, and never closing it. This eliminates repeated fopen/fseek/fread/fclose sequences, which helps even in queries with small amount of virtual addresses. 2. Using pread, instead of seek+read. 3. Only performing pagemap read when the address is valid. Future work might recognize continues pages in the query, and perform a batch read of multiple pagemap entries, instead one page at a time, but for now it is not necassary. This change get_working_set_ex peek wall clock runtime from 57ms to 0.29ms. Tested on Linux, but similar change done for the BSD part. `Signed-off-by: Witold Baryluk <witold.baryluk(a)gmail.com>` -- v17: ntdll: Keep pagemap file open after first use of NtQueryVirtualMemory(MemoryWorkingSetExInformation) https://gitlab.winehq.org/wine/wine/-/merge_requests/852

2 5

[PATCH v16 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 21 Sep '22

21 Sep '22

Apex Legends game periodically (every 30 seconds) calls this function with up to 22k virtual addresses. All but 1 of them is valid. Due to amount of queries addresses, and cost of seek+read, this causes this function to take up to about 50ms. So framerate drops from ~150 FPS to 20FPS for about a second. As far as I can see, returning 0 entries from this function, still makes Apex Legend work. But keep code correct, and optimise it by: 1. Opening pagemap file once, and never closing it. This eliminates repeated fopen/fseek/fread/fclose sequences, which helps even in queries with small amount of virtual addresses. 2. Using pread, instead of seek+read. 3. Only performing pagemap read when the address is valid. Future work might recognize continues pages in the query, and perform a batch read of multiple pagemap entries, instead one page at a time, but for now it is not necassary. This change get_working_set_ex peek wall clock runtime from 57ms to 0.29ms. Tested on Linux, but similar change done for the BSD part. `Signed-off-by: Witold Baryluk <witold.baryluk(a)gmail.com>` -- v16: ntdll: Keep pagemap file open after first use of NtQueryVirtualMemory(MemoryWorkingSetExInformation) https://gitlab.winehq.org/wine/wine/-/merge_requests/852

3 5

Re: [PATCH v15 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) 21 Sep '22

21 Sep '22

On Wed Sep 21 21:29:50 2022 +0000, Alexandre Julliard wrote: > > Code should be obvious, but question for the last commit: should I > open with `O_CLOEXEC` ? > Yes, you should. grep for O_CLOEXEC to see how this is handled in other > places when not supported. Makes sense. Done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/852#note_9007

1 0

[PATCH 0/2] MR901: crypt32: Implement a couple of missing bits in string conversion functions.
by Paul Gofman (＠gofman) 21 Sep '22

21 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/901

5 5

Re: [PATCH v9 0/1] MR824: ntoskrnl: Implement KeGetCurrentProcessorNumberEx - approved
by Alexandre Julliard (＠julliard) 21 Sep '22

21 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/824

1 0

Re: [PATCH v2 0/2] MR909: Client cert failures - approved
by Alexandre Julliard (＠julliard) 21 Sep '22

21 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/909

1 0