January 2023 - Wine-gitlab - list.winehq.org

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Zebediah Figura (＠zfigura) 22 Jan '23

22 Jan '23

On Sun Jan 22 22:25:54 2023 +0000, Thomas Csovcsity wrote: > source does not have wmemcpy and wcsncpy is defined as: > `#define wcsncpy(d,s,n) error do_not_use_wcsncpy_use_lstrcpynW_or_memcpy_instead` In this case you'd write "memcpy(save_str, url_scheme[pos], (len + 1) * sizeof(WCHAR))". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_21344

1 0

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 22 Jan '23

22 Jan '23

On Sun Dec 18 23:32:23 2022 +0000, Zebediah Figura wrote: > This comment doesn't seem to tell us anything more than the following > line does. Okay -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_21343

1 0

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 22 Jan '23

22 Jan '23

On Sun Dec 18 23:32:22 2022 +0000, Zebediah Figura wrote: > We use WCHAR, not wchar_t. > It'd also be nice to use a consistent style for all of variable names in > this function (wrt snake case vs camel case). In new code I think we > prefer snake case. Okay -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_21342

1 0

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 22 Jan '23

22 Jan '23

On Sun Dec 18 23:32:22 2022 +0000, Zebediah Figura wrote: > Can we use a helper function to fix up the scheme instead of using a > goto? This will probably also help make the function easier to follow, > by virtue of being less monolithic. Sure, that it can be done. Other parts of the code use goto too. I also used already goto in kernel and drivers. ATM i am not able to think about a function which would make it easier. If i use early return from function, i think it makes no difference, but i plan to use a helper function to keep UrlFixup shorter. Any suggestion about the structure is well come, because i think i am blind to other and better ways. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_21341

1 0

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 22 Jan '23

22 Jan '23

On Sun Dec 18 23:28:47 2022 +0000, Zebediah Figura wrote: > We already know it fits, so this can just be memcpy(). source does not have wmemcpy and wcsncpy is defined as: `#define wcsncpy(d,s,n) error do_not_use_wcsncpy_use_lstrcpynW_or_memcpy_instead` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_21340

1 0

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 22 Jan '23

22 Jan '23

On Sun Dec 18 23:24:34 2022 +0000, Zebediah Figura wrote: > These are constant arrays, so should be "static const WCHAR *const". > Also, it seems that one array is the same as the other without the final > colon; can we avoid defining two arrays? Yes, it is possible to avoid 2 arrays, that is an additional goal. The first goal for me was to avoid additional computation (string manipulation), but i will adjust. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_21339

1 0

[PATCH 0/1] MR1997: Draft: comctl32/header: Do not touch 'hwnd' field in HDM_LAYOUT.
by Nikolay Sivov (＠nsivov) 22 Jan '23

22 Jan '23

This should wait until after 8.0. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1997

2 1

[PATCH v3 0/1] MR1986: mountmgr.sys: Dont attempt to read from invalid media
by Alistair Leslie-Hughes (＠alesliehughes) 22 Jan '23

22 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49615 -- v3: mountmgr.sys: Dont attempt to read from invalid media https://gitlab.winehq.org/wine/wine/-/merge_requests/1986

2 1

[PATCH v6 0/1] MR1989: wininet: Allow UTC as a timezone.
by Etaash Mathamsetty (＠etaash.mathamsetty) 21 Jan '23

21 Jan '23

this should fix ubisoft connect outputting unknown timezone UTC in logs -- v6: wininet: Allow UTC as a timezone. https://gitlab.winehq.org/wine/wine/-/merge_requests/1989

2 2

[PATCH v6 0/12] MR1948: Draft: windows.media.speech: Recognition session work the second.
by Bernhard Kölbl 21 Jan '23

21 Jan '23

First relevant commit: windows.media.speech: Add a worker thread to the recognition session. -- v6: windows.media.speech: Store recorded audio in a temporary ringbuffer. windows.media.speech: Partially implement the speech recognizer state. windows.media.speech: Add an audio capturing system. windows.media.speech: Allow the recognition session worker to be paused. windows.media.speech/tests: Check if stopping the session resets the paused state. windows.media.speech: Add a worker thread to the recognition session. windows.media.speech/tests: Test starting, stopping, pausing and resuming the recognition session. windows.media.speech/tests: Test the recognizer state. windows.media.speech: Return IAsyncAction from session_PauseAsync. windows.media.speech: Return IAsyncAction from session_StopAsync. windows.media.speech: Do not force calling convention on internal callbacks. windows.media.speech: Move constraints vector to the recognition session. https://gitlab.winehq.org/wine/wine/-/merge_requests/1948

2 13