January 2023 - Wine-gitlab - list.winehq.org

[PATCH 0/5] MR1939: ntdll: Do not use extended context in RtlCopyContext() if extended state is not copied.
by Paul Gofman (＠gofman) 11 Jan '23

11 Jan '23

And fix some test failures on the way. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54289 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1939

2 5

[PATCH 0/1] MR1932: ddraw/tests: Do not create a fullscreen test window in test_window_position_cb().
by Zhiyi Zhang (＠zhiyi) 11 Jan '23

11 Jan '23

Some window managers have trouble moving fullscreen windows to another monitor. For example, KWin doesn't allow moving windows with _NET_WM_STATE_FULLSCREEN set. FVWM used by TestBots keeps the size for fullscreen windows after they are moved to another monitor and when the window is also fullscreen on the new monitor, which could be a bug in FVWM. But let's work around this in the tests as well. The changed tests don't need created windows being fullscreen at the start. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54172 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1932

4 3

[PATCH v5 0/3] MR59: vkd3d-shader/hlsl: Avoid infinite loop in copy propagation.
by Francisco Casas (＠fcasas) 11 Jan '23

11 Jan '23

copy_propagation_transform_object_load() currently retrieves true, which indicates that there was progress, even if the input dereference remains the same. This can happen repeatedly if an uninitialized object is copied onto itself, as in the tests added in this patch. This results on the compilation getting stuck on an endless loop. This patch checks if the deref didn't change, to retrieve false in that case. -- v5: vkd3d-shader/hlsl: Validate that referenced objects are uniform. tests: Test uninitialized object references. vkd3d-shader/hlsl: Avoid infinite loop in copy propagation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/59

2 3

[PATCH 0/1] MR1938: shell32/tests: Fix a test failure on Windows 11.
by Hans Leidekker (＠hans) 11 Jan '23

11 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1938

2 1

[PATCH 0/1] MR1937: kernelbase: Fix grouping repeat for number formatting.
by Gabriel Ivăncescu 11 Jan '23

11 Jan '23

LOCALE_SGROUPING's string and the `Grouping` field in NUMBERFMTW are confusingly different. The former, which is what is fixed here, treats a '0' as a repeat of the previous grouping. But a 0 at the end of the `Grouping` field prevents it from repeating (it repeats by default otherwise) so it's the opposite. Note that without a '0' in the LOCALE_SGROUPING string, it shouldn't even repeat in the first place. This fixes the typical "3;0" default grouping, for example. See: https://learn.microsoft.com/en-us/windows/win32/intl/locale-sgrouping -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1937

2 3

[PATCH v3 0/2] MR1931: ntdll: Conform to Windows 11 behavior in RtlIpv6StringToAddress().
by Hans Leidekker (＠hans) 11 Jan '23

11 Jan '23

Also fixes test failures on Windows 11. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54045 -- v3: ntdll: Conform to Windows 11 behavior in RtlIpv6StringToAddress(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1931

3 4

[PATCH v4 0/3] MR59: vkd3d-shader/hlsl: Avoid infinite loop in copy propagation.
by Francisco Casas (＠fcasas) 11 Jan '23

11 Jan '23

copy_propagation_transform_object_load() currently retrieves true, which indicates that there was progress, even if the input dereference remains the same. This can happen repeatedly if an uninitialized object is copied onto itself, as in the tests added in this patch. This results on the compilation getting stuck on an endless loop. This patch checks if the deref didn't change, to retrieve false in that case. -- v4: vkd3d-shader/hlsl: Validate that referenced objects are uniform. tests: Test uninitialized object references. vkd3d-shader/hlsl: Avoid infinite loop in copy propagation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/59

4 9

[PATCH 0/1] MR1933: wininet/tests: Pass INTERNET_FLAG_RELOAD in secure connection tests.
by Hans Leidekker (＠hans) 11 Jan '23

11 Jan '23

Avoids test failures when the URL is cached by other tests. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51227 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1933

3 2

[PATCH v2 0/2] MR1931: ntdll: Conform to Windows 11 behavior in RtlIpv6StringToAddress().
by Hans Leidekker (＠hans) 11 Jan '23

11 Jan '23

Also fixes test failures on Windows 11. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54045 -- v2: ntdll: Conform to Windows 11 behavior in RtlIpv6StringToAddress(). ws2_32/tests: Fix test failures on Windows 11. https://gitlab.winehq.org/wine/wine/-/merge_requests/1931

3 4

[PATCH v6 0/5] MR54: vkd3d-shader/hlsl: Initialize static variables to 0 by default.
by Francisco Casas (＠fcasas) 11 Jan '23

11 Jan '23

We are currently not initializing static values to zero by default. Consider the following shader: ```hlsl static float4 va; float4 main() : sv_target { return va; } ``` we get the following output: ``` ps_5_0 dcl_output o0.xyzw dcl_temps 2 mov r0.xyzw, r1.xyzw mov o0.xyzw, r0.xyzw ret ``` where r1.xyzw is not initialized. This patch solves this by assigning the static variable the value of an uint 0, and thus, relying on complex broadcasts. This seems to be the behaviour of the the native compiler, since it retrieves the following error on a shader that lacks an initializer on a data type with object components: ``` error X3017: cannot convert from 'uint' to 'struct <unnamed>' ``` -- v6: vkd3d-shader/hlsl: Allow uninitialized static objects. vkd3d-shader/hlsl: Validate that non-uniform objects are not referenced. tests: Add additional object references tests. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/54

6 14