October 2023 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR4143: uxtheme: Add ShouldAppsUseDarkMode.
by Zhiyi Zhang (＠zhiyi) 22 Oct '23

22 Oct '23

On Sun Oct 22 10:43:26 2023 +0000, Louis Lenders wrote: > >and a Wine-Bug: link in the commit message. > How do I do that? You can do 'git commit --amend', write 'Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55742' on the third line. Save. Then 'git push -f' on the same branch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4143#note_49563

1 0

[PATCH 0/4] MR424: tests: Introduce a stress tester for vkd3d-shader.
by Giovanni Mascellani (＠giomasce) 21 Oct '23

21 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/424

2 5

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Hans Leidekker (＠hans) 21 Oct '23

21 Oct '23

> Yeah, but this isn't necessarily about not trusting Windows apps, i.e. malice or malware, but rather that they can't be designed around it (since they assume Windows environment), so they would have privacy issues without even wanting to. At the very least maybe use Of course Windows apps can be designed around it. In the Windows environment they'd retrieve a real hardware ID that should be handled with the same care. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49556

1 0

[PATCH 0/1] MR4152: dnsapi: Handle IP address as DNS name in DnsQuery_UTF8().
by Paul Gofman (＠gofman) 21 Oct '23

21 Oct '23

Fixes Tekken 8 (early access) being unable to find other players for match. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4152

3 4

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Paul Gofman (＠gofman) 21 Oct '23

21 Oct '23

On Sat Oct 21 10:27:59 2023 +0000, Jinoh Kang wrote: > Okay, I've read the prior discussions regarding the rationale. > Still, I don't think you should change the System UUID for *existing* > prefixes. Perhaps we could use the registry to detect whether the > prefix is new, and use the new algorithm for new prefixes. We could > also record the UUID in the registry "permanently." Maintaining any way of backward compat on this ID doesn't look feasible. E. g., the current way with a bug reports bios hashtag in serial field on my desktop due to missing fields not being handled. This ID is already non-unique, and maintaining these algorithms backwards would take unreasonable amount of effort (with arguably no gains). Probably more important, /etc/machine-id can be changed anytime by user or system resintall, it is not true hardware id. If anything firmly relies on HW id to persist forever, it is broken already. Regarding the original discussion, I also don't really understand why we should necessarily obfuscate /etc/machine-id for uuid / serial reporting. App has access to the file anyway, and Wine neither sends the ID anywhere nor tracks the user, it is between the app and the user. On Windows fwiw it will get real motherboard serial and other information like that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49550

1 0

[PATCH 0/1] MR4156: ntdll/tests: Use win_skip() for missing APIs in test_query_process_debug_port_custom_dacl.
by Jinoh Kang (＠iamahuman) 21 Oct '23

21 Oct '23

A missing API is a todo in Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4156

2 1

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Jinoh Kang (＠iamahuman) 21 Oct '23

21 Oct '23

On Sat Oct 21 10:25:18 2023 +0000, Jinoh Kang wrote: > This changes the system GUID. Some DRMs and copy protections like to > assume that things like System UUIDs are permanent and never change. > Changing this will break such apps and the user might have to > reinstall/re-purchase them again. Okay, I've read the prior discussions regarding the rationale. Still, I don't think you should change the System UUID for *existing* prefixes. Perhaps we could use the registry to detect whether the prefix is new, and use the new algorithm for new prefixes. We could also record the UUID in the registry "permanently." -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49548

1 0

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Jinoh Kang (＠iamahuman) 21 Oct '23

21 Oct '23

Jinoh Kang (@iamahuman) commented about dlls/ntdll/unix/system.c: > system_args.version = system_version; > system_args.serial_len = get_smbios_string("/sys/class/dmi/id/product_serial", S(system_serial)); > system_args.serial = system_serial; > - get_system_uuid(&system_args.uuid); > + derive_machineid_to_uuid(&system_args.uuid); This changes the system GUID. Some DRMs and copy protections like to assume that things like System UUIDs are permanent and never change. Changing this will break such apps and the user might have to reinstall/re-purchase them again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49547

1 0

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Jinoh Kang (＠iamahuman) 21 Oct '23

21 Oct '23

Jinoh Kang (@iamahuman) commented about dlls/ntdll/unix/system.c: > close( fd ); > } > } > > +static void derive_machineid_to_uuid( GUID *uuid ) > +{ > + static unsigned char wine_uuid[16] = { 0xe8, 0x65, 0x52, 0x8d, 0x0a, 0xa2, 0x45, 0x27, > + 0xa8, 0x3b, 0x15, 0xed, 0x41, 0xb5, 0xd0, 0x91 }; > + GUID machine_uuid; > + unsigned char out256[32]; /* returning first 128 bits only */ > + > + read_machine_id( &machine_uuid ); > + > + hmac_sha256( wine_uuid, sizeof(wine_uuid), (const unsigned char *)&machine_uuid, sizeof(machine_uuid), out256 ); > + > + memset( &machine_uuid, 0, sizeof(machine_uuid) ); This write is unused and will be optimized out by the compiler. Are you looking for something like [`explicit_bzero(3)`](https://man7.org/linux/man-pages/man3/bzero.3.html)? In that case, why is machine UUID considered sensitive enough to warrant erasure? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49546

1 0

[PATCH v7 0/2] MR4054: mshtml: HTMLWindow behavior improvements.
by Gabriel Ivăncescu 21 Oct '23

21 Oct '23

-- v7: mshtml: Return proper errors when navigating with no browser. mshtml: Set outer window to uninitialized page when document obj is released. https://gitlab.winehq.org/wine/wine/-/merge_requests/4054

3 4