October 2023 - Wine-gitlab - list.winehq.org

[PATCH 0/2] MR4108: Improve DMI tables under Linux.
by eric pouech (＠epo) 17 Oct '23

17 Oct '23

This MR improves Wine's DMI tables by: - no longer exposing /etc/machine-id content. Current documentation of systemd strongly suggests to use a hash of it (with app dedicated key). (1) - generates DMI entries for files that are no longer user readable on Linux (like bios serial number). The values are derived from hashed value in step #1. (1) current implementation integrates into unix ntdll a bunch of sha 256 related code. It's basically a reimplementation of libsystemd's sd_id128_get_machine_app_specific(). We could alternatively dynamically link to libsystemd.so. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108

3 6

[PATCH v5 0/2] MR381: vkd3d-shader/tpf: Convert some of the semantic names to system values names when in compatibility mode.
by Nikolay Sivov (＠nsivov) 17 Oct '23

17 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v5: programs/vkd3d-compiler: Dynamically allocate options array. vkd3d-shader/tpf: Convert some of the semantic names to system values names when in compatibility mode. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/381

4 4

[PATCH v16 0/8] MR361: vkd3d-shader/hlsl: Initial support for 'switch' statement.
by Nikolay Sivov (＠nsivov) 17 Oct '23

17 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v16: vkd3d-shader/tpf: Write out 'switch' statements. vkd3d-shader/hlsl: Add a pass to validate switch cases blocks. vkd3d-shader/hlsl: Add a pass to remove unreachable code. vkd3d-shader/hlsl: Add copy propagation logic for switches. vkd3d-shader/hlsl: Validate break/continue context. vkd3d-shader/hlsl: Check for duplicate case statements. vkd3d-shader/hlsl: Add initial support for parsing 'switch' statements. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/361

4 16

[PATCH 0/1] MR4125: gdi32: Fix leak in GdiDeleteSpoolFileHandle.
by Piotr Caban (＠piotr) 17 Oct '23

17 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4125

3 2

[PATCH 0/1] MR4126: winex11.drv: Send missed KEYUP events on KeymapNotify.
by Arek Hiler (＠ivyl) 17 Oct '23

17 Oct '23

Full focus lost / focus gained events on the Windows side are not feasible for X11's FocusIn/FocusOut events generated by keyboard grabs (see XGrabKeyboard()) that are used for example for Atl+Tab handling. Using them would degrade user's experience by causing the window to minimize or flash multiple times depending on a game/window manager combo. Because of that the programs may miss on some KEYUP events that happen during the grab, and since there are no focus changes on the Windows side the state doesn't get resynced. This change attempts to improve user experience by syncing any missed key release events that happened while the window haven't had focus on the X11 side. There's no syncing of key presses as those are more problematic because of window manager quirks, e.g. on KDE it may end up syncing the Tab press portion of Alt+Tab. Luckily missing key events for keys that were pressed and not released while the WM had the keyboard grab is not nearly as confusing as stuck keys. For Warhammer: Chaosbane, theHunter: Call of the Wild, Far Cry Primal and many other games that end up with stuck Alt after Alt+Tabbing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4126

2 1

[PATCH 0/9] MR413: Draft: ci: Run the crosstests on Windows.
by Giovanni Mascellani (＠giomasce) 17 Oct '23

17 Oct '23

This depends on !412, and might need some finishing touches before being ready. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/413

2 9

Re: [PATCH v2 0/1] MR4107: wbemprox: Use correct string id.
by Hans Leidekker (＠hans) 17 Oct '23

17 Oct '23

Hans Leidekker (@hans) commented about dlls/wbemprox/builtin.c: > rec->manufacturer = get_bios_manufacturer( buf, len ); > rec->name = L"Default System BIOS"; > rec->releasedate = get_bios_releasedate( buf, len ); > - rec->serialnumber = get_bios_serialnumber( buf, len ); > + rec->serialnumber = L"Serial number"; You also need to remove COL_FLAG_DYNAMIC from the column definition otherwise free() will be called on a static string. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4107#note_48966

1 0

Re: [PATCH v2 0/1] MR4107: wbemprox: Use correct string id.
by Hans Leidekker (＠hans) 17 Oct '23

17 Oct '23

Hans Leidekker (@hans) commented about dlls/wbemprox/builtin.c: > { > const struct smbios_header *hdr; > - const struct smbios_baseboard *baseboard; > UINT offset; > > - if (!(hdr = find_smbios_entry( SMBIOS_TYPE_BASEBOARD, buf, len ))) return NULL; > + if (!(hdr = find_smbios_entry( type, buf, len ))) return NULL; > > - baseboard = (const struct smbios_baseboard *)hdr; > - offset = (const char *)baseboard - buf + baseboard->hdr.length; > - return get_smbios_string( id, buf, offset, len ); > + if (field_offset + sizeof(BYTE) > hdr->length) return NULL; > + > + offset = (const char *)hdr - buf + hdr->length; > + return get_smbios_string_internal( ((const BYTE*)hdr)[field_offset], buf, offset, len ); > } Please add a space before the asterisk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4107#note_48965

1 0

Re: [PATCH v2 0/1] MR4107: wbemprox: Use correct string id.
by Hans Leidekker (＠hans) 17 Oct '23

17 Oct '23

Hans Leidekker (@hans) commented about dlls/wbemprox/builtin.c: > return hdr; > } > > -static WCHAR *get_smbios_string( BYTE id, const char *buf, UINT offset, UINT buflen ) > +static WCHAR *get_smbios_string_internal( BYTE id, const char *buf, UINT offset, UINT buflen ) > { get_smbios_string_by_id() is a better name. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4107#note_48964

1 0

[PATCH 0/1] MR4112: mf/tests: Increase buffer to prevent stack corruption
by Fabian Maurer (＠DarkShadow44) 17 Oct '23

17 Oct '23

init_dmo_media_type_video uses head + extra bytes memory, and with MEDIASUBTYPE_RGB8 the extra bytes are already 1024. This leads to stack corruption. Note that not all of those are strictly necessary to prevent a crash, but I think it's safer in case it becomes relevant in the future. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4112

4 6