November 2023 - Wine-gitlab

[PATCH 0/2] MR4535: ntdll: Don't perform ASLR on XP and earlier
by Brendan McGrath (＠redmcg) 01 Dec '23

01 Dec '23

ASLR is supported only on Windows Vista and later -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4535

3 5

[PATCH v2 0/2] MR4554: gdi32/tests: Ensure ABC width and GGO_BITMAP gmCellIncX match
by Brendan McGrath (＠redmcg) 01 Dec '23

01 Dec '23

Also fix the reported width on existing tests -- v2: win32u: Fix reported metrics by using bitmap strikes https://gitlab.winehq.org/wine/wine/-/merge_requests/4554

4 8

[PATCH 0/3] MR4290: ntdll: A bit of KiUserExceptionDispatcher redesign.
by Paul Gofman (＠gofman) 30 Nov '23

30 Nov '23

An anticheat assumes some specific layout of KiUserExceptionDispatcher (in an 64 bit app). After checking two bytes (obviously instruction opcode) at (KiUserExceptionDispatcher + 1), it extracts memory address from this instruction and places its hook function address at that address, expecting that to be called on CPU exceptions (but not software raised exceptions). I tried to make something out of it so supporting this mechanics is not completely artificial and fits into our implementation. I don't know if that hook has really something to do with wow64 in Windows implementation (while I guess that's possible), but it seems to me in our implementation doing it this way is a bit more straightforward. Specifically, it seems to me a bit easier to follow when a single function (KiUserExceptionDispatcher) doesn't mix different unwind models (while having the same runtime function info). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4290

4 15

[PATCH v3 0/1] MR4414: server: Fully initialize pe mapping struct to avoid uninitialized memory when...
by Fabian Maurer (＠DarkShadow44) 30 Nov '23

30 Nov '23

When running wineserver under valgrind there is a bunch of uninitialised bytes warnings when sending the req_get_mapping_info reply. This warning can easily be reproduced by running `valgrind wineserver -f` and then `winecfg`. Tested using self compiled wine. Reason is the `pe_image_info_t` struct having bitfields: ``` unsigned char contains_code : 1; unsigned char wine_builtin : 1; unsigned char wine_fakedll : 1; ``` The last 5 bits are never initialized. This MR fixes this by zeroing the entire struct before it is filled. I hope "issues" like this are allowed to be fixed so valgrind has less false positives. Valgrind message for reference: ``` ==628662== 716 errors in context 3 of 3: ==628662== Syscall param writev(vector[1]) points to uninitialised byte(s) ==628662== at 0x49C3A87: writev (writev.c:26) ==628662== by 0x14C2F3: send_reply (request.c:268) ==628662== by 0x14C50F: call_req_handler (request.c:316) ==628662== by 0x14C5D2: read_request (request.c:339) ==628662== by 0x158F52: thread_poll_event (thread.c:388) ==628662== by 0x120FC9: fd_poll_event (fd.c:505) ==628662== by 0x1212A6: main_loop_epoll (fd.c:599) ==628662== by 0x121882: main_loop (fd.c:955) ==628662== by 0x12CBE0: main (main.c:238) ==628662== Address 0x53ec56e is 62 bytes inside a block of size 88 alloc'd ==628662== at 0x48416D4: malloc (vg_replace_malloc.c:431) ==628662== by 0x1348D0: mem_alloc (object.c:119) ==628662== by 0x14BEB9: set_reply_data_size (request.c:160) ==628662== by 0x1301C1: req_get_mapping_info (mapping.c:1291) ==628662== by 0x14C494: call_req_handler (request.c:305) ==628662== by 0x14C5D2: read_request (request.c:339) ==628662== by 0x158F52: thread_poll_event (thread.c:388) ==628662== by 0x120FC9: fd_poll_event (fd.c:505) ==628662== by 0x1212A6: main_loop_epoll (fd.c:599) ==628662== by 0x121882: main_loop (fd.c:955) ==628662== by 0x12CBE0: main (main.c:238) ==628662== Uninitialised value was created by a client request ==628662== at 0x134873: mark_block_uninitialized (object.c:110) ==628662== by 0x1348EA: mem_alloc (object.c:120) ==628662== by 0x134B87: alloc_object (object.c:199) ==628662== by 0x134F92: create_named_object (object.c:337) ==628662== by 0x12F12B: create_mapping (mapping.c:939) ==628662== by 0x12FFE9: req_create_mapping (mapping.c:1250) ==628662== by 0x14C494: call_req_handler (request.c:305) ==628662== by 0x14C5D2: read_request (request.c:339) ==628662== by 0x158F52: thread_poll_event (thread.c:388) ==628662== by 0x120FC9: fd_poll_event (fd.c:505) ==628662== by 0x1212A6: main_loop_epoll (fd.c:599) ==628662== by 0x121882: main_loop (fd.c:955) ``` -- v3: server: Fully initialize pe mapping struct to avoid uninitialized memory when sending req_get_mapping_info reply (valgrind) https://gitlab.winehq.org/wine/wine/-/merge_requests/4414

2 1

Re: [PATCH v2 0/1] MR4495: setupapi: Add stubs for SetupDiGetCustomDeviceProperty{A|W}(). - approved
by Alexandre Julliard (＠julliard) 30 Nov '23

30 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4495

1 0

Re: [PATCH v3 0/1] MR4548: vbscript: Sub argument has precedence over global const. - approved
by Alexandre Julliard (＠julliard) 30 Nov '23

30 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4548

1 0

Re: [PATCH v3 0/2] MR4559: gitlab: Add clang build. - approved
by Alexandre Julliard (＠julliard) 30 Nov '23

30 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4559

1 0

Re: [PATCH v5 0/5] MR4441: Adding tests for CreateProcess and std handles. - approved
by Alexandre Julliard (＠julliard) 30 Nov '23

30 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4441

1 0

Re: [PATCH v2 0/1] MR4564: vbscript: Implement TypeName(Nothing). - approved
by Alexandre Julliard (＠julliard) 30 Nov '23

30 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4564

1 0

Re: [PATCH v3 0/1] MR4530: d3drm: Suppress a use-after-free warning in d3drm_image_palettise (GCC). - approved
by Alexandre Julliard (＠julliard) 30 Nov '23

30 Nov '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4530

1 0