December 2023 - Wine-gitlab

[PATCH 0/1] MR4730: dbghelp/tests: Wait for child window to be up before testing.
by eric pouech (＠epo) 21 Dec '23

21 Dec '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4730

2 2

[PATCH 0/3] MR530: Draft: Add a few validation checks.
by Giovanni Mascellani (＠giomasce) 21 Dec '23

21 Dec '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/530

2 3

[PATCH 0/2] MR4729: dnsapi: Update the array ptr in the insufficient buffer case.
by Huw Davies (＠huw) 21 Dec '23

21 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4729

3 3

[PATCH 0/1] MR4728: winmm: Fill in pIOProc field in MMIOINFO.
by eric pouech (＠epo) 21 Dec '23

21 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55942 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4728

3 2

[PATCH v3 0/2] MR4676: server: Only update the global cursor if the pointer is inside the thread's windows.
by Rémi Bernon 21 Dec '23

21 Dec '23

We are preferring the thread input cursor over the global desktop cursor, but if the thread input has no cursor yet, for instance when thread is attached to another thread without a message queue yet, it will end up being invisible. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55961 -- v3: server: Change desktop cursor only when inside the thread's windows. server: Introduce a new get_desktop_cursor_thread_input helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/4676

1 3

[PATCH v3 0/1] MR4726: server: Always release internal hardware messages
by Brendan McGrath (＠redmcg) 21 Dec '23

21 Dec '23

This fixes an issue seen in Outlook 365 where the password prompt appears to lock up. Technically this fixes a regression introduced in 25906eedd8679fdb474976563f4a05a92e11bbd6, but I think Outlook had other issues that would have masked this one at the time. -- v3: server: Always release internal hardware messages https://gitlab.winehq.org/wine/wine/-/merge_requests/4726

3 3

Re: [PATCH v2 0/2] MR4726: server: Always release internal hardware messages
by Rémi Bernon 21 Dec '23

21 Dec '23

I'm not sure we need a test for that btw. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4726#note_56344

1 0

Re: [PATCH v2 0/2] MR4726: server: Always release internal hardware messages
by Rémi Bernon 21 Dec '23

21 Dec '23

Rémi Bernon (@rbernon) commented about server/queue.c: > > data->hw_id = msg->unique_id; > set_reply_data( msg->data, msg->data_size ); > - if (get_hardware_msg_bit( msg->msg ) == QS_RAWINPUT && (flags & PM_REMOVE)) > + if (get_hardware_msg_bit( msg->msg ) == QS_RAWINPUT && > + ((flags & PM_REMOVE) || is_internal_hardware_message( msg->msg ))) ```suggestion:-1+0 if ((get_hardware_msg_bit( msg->msg ) == QS_RAWINPUT && (flags & PM_REMOVE)) || is_internal_hardware_message( msg->msg ))) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4726#note_56343

1 0

Re: [PATCH v2 0/2] MR4726: server: Always release internal hardware messages
by Rémi Bernon 21 Dec '23

21 Dec '23

Rémi Bernon (@rbernon) commented about server/queue.c: > } > } > > +/* is this message an internal driver notification message */ > +static inline BOOL is_internal_hardware_message( unsigned int message ) > +{ > + return (message >= WM_WINE_CLIPCURSOR && message <= WM_WINE_LAST_DRIVER_MSG); I'd use the same range that's used for peeking the messages: ```suggestion:-0+0 return (message >= WM_WINE_FIRST_DRIVER_MSG && message <= WM_WINE_LAST_DRIVER_MSG); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4726#note_56342

1 0

[PATCH 0/1] MR4727: advapi32: Add TreeSetNamedSecurityInfoW stub.
by Alex Henrie (＠alexhenrie) 21 Dec '23

21 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56055 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4727

2 1