December 2023 - Wine-gitlab

Re: [PATCH v5 0/5] MR519: vkd3d-shader/dxil: Support minimum precision.
by Giovanni Mascellani (＠giomasce) 14 Dec '23

14 Dec '23

On Thu Dec 14 16:34:26 2023 +0000, Henri Verbeet wrote: > > ```diff > > -#if defined(SONAME_LIBDXCOMPILER) && !defined(VKD3D_CROSSTEST) > > +#if defined(SONAME_LIBDXCOMPILER) || defined(VKD3D_CROSSTEST) > > ``` > Should that just be "#if defined(SONAME_LIBDXCOMPILER)"? We could > perhaps consider defining SONAME_LIBDXCOMPILER to "dxcompiler.dll" if it > isn't already defined and we have VKD3D_CROSSTEST, but in principle I > don't think VKD3D_CROSSTEST needs special handling here. Defining `SONAME_LIBDXCOMPILER` when the dxcompiler library is not indeed available means that tests start failing. If no soname was specified or detected at configuration time, I don't think we should even try to use that library. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/519#note_55995

1 0

Re: [PATCH v3 0/3] MR524: tests/shader-runner: Check for 64-bit support in the d3d11 and Vulkan runners. - approved
by Henri Verbeet (＠hverbeet) 14 Dec '23

14 Dec '23

This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/524

1 0

Re: [PATCH v8 0/4] MR292: vkd3d: Write Vulkan descriptors in a worker thread. - approved
by Henri Verbeet (＠hverbeet) 14 Dec '23

14 Dec '23

This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/292

1 0

[PATCH 0/2] MR525: vkd3d-shader: Store vsir swizzles as uint32_t's.
by Henri Verbeet (＠hverbeet) 14 Dec '23

14 Dec '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/525

3 3

[PATCH v2 0/5] MR518: vkd3d-shader: Enable sm1 -> spirv compilation.
by Zebediah Figura (＠zfigura) 14 Dec '23

14 Dec '23

``` Datta: what have we given? My friend, blood shaking my heart The awful daring of a moment's surrender Which an age of prudence can never retract By this, and this only, we have existed Which is not to be found in our obituaries Or in memories draped by the beneficient spider Or under seals broken by the lean solicitor In our empty rooms ``` -- v2: vkd3d-shader: Allow compiling d3d bytecode to SPIR-V. tests: Avoid using "SV_Position" as a name for the vertex shader input. tests: Use struct vkd3d_shader_scan_signature_info to retrieve the VS input signature. vkd3d-shader: Do not scan DCL instructions which do not declare resources. vkd3d-shader: Do not scan the shader in vkd3d_shader_parser_compile() for assembly targets. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/518

3 8

[PATCH v4 0/7] MR490: Draft: vkd3d-shader: Int64 support.
by Conor McCarthy (＠cmccarthy) 14 Dec '23

14 Dec '23

Goes atop !489. The last 7 commits belong to this MR. Many of these patches are small, but the series can be split further if necessary. -- v4: vkd3d-shader/spirv: Handle ITOI and UTOU in spirv_compiler_map_alu_instruction(). vkd3d-shader/spirv: Support UINT64 source in spirv_compiler_emit_bool_cast(). vkd3d-shader/spirv: Support 64-bit sources in spirv_compiler_emit_int_div(). vkd3d-shader/spirv: Introduce a UINT64 component type. vkd3d-shader/spirv: Introduce a data_type_is_64_bit() helper function. vkd3d-shader/spirv: Use data_type_is_integer() in spirv_compiler_emit_neg(). vkd3d: Pass int64 capability info to vkd3d-shader. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/490

4 10

Re: [PATCH v3 0/3] MR524: tests/shader-runner: Check for 64-bit support in the d3d11 and Vulkan runners. - approved
by Giovanni Mascellani (＠giomasce) 14 Dec '23

14 Dec '23

This merge request was approved by Giovanni Mascellani. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/524

1 0

[PATCH v2 0/4] MR514: tests: Use the vulkan runner to run SM1 compilation tests.
by Francisco Casas (＠fcasas) 14 Dec '23

14 Dec '23

Recap: My previous proposals to extend the shader_runner to SM1 were focusing on separating compilation tests ([shader] directives) from execution tests ([test] directives), and let the generic shader_runner.c:compile_shader() in charge of the former. However, Henri was more inclined to aim for making the parser agnostic to the language of the tests so we can potentially extend the shader_runner tests to other languages such as d3d-asm. This means, removing the burden of compilation from the parser altogether, and moving it to the runners, probably through a runner->compile function pointer (even if most of them end up doing the same thing, compiling with vkd3d-shader or the native compiler, depending on availability). Agreeing with going in this general direction, this MR contains patches to do SM1 compilation calling run_shader_tests() for SM1 profiles from the Vulkan runner (skipping execution for now), and some improvements to the qualifiers syntax. Despite this, there are parallel discussions on: - Whether to name the shader models individually in the [require] directives or expressing the range of shader models where the test should pass. In the latter case, whether to run for all shader models, only the lowest one in the SM1, SM4, and SM6 groups, or to allow the runner to select a shader model within the range (I feel strongly against this now, I think the runner should just retrieve a boolean in runner->check_requirements). - Where to do the iteration across different shader models, if in run_shader_tests() or expect each runner to call run_shader_tests() several times as we do now. But there is no need to settle on something for these yet. --- Now, what may be the most noisy part of this MR is that even though we are calling run_shader_tests() through the Vulkan runner, this will result in calling shader_runner.c:compile_shader() instead of shader_runner_vulkan.c:compile_shader(), but if we follow the "making the parser agnostic" plan, we eventually should get rid of shader_runner.c:compile_shader() and introduce the runner->compile pointer instead. -- v2: tests: Use the vulkan runner to run SM1 compilation tests. tests/shader-runner: Call each runner only once. tests/shader-runner: Allow specifying multiple todo() qualifiers on test directives. tests/shader-runner: Support reading multiple model range args for qualifiers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/514

3 6

[PATCH v7 0/4] MR292: vkd3d: Write Vulkan descriptors in a worker thread.
by Conor McCarthy (＠cmccarthy) 14 Dec '23

14 Dec '23

-- v7: vkd3d: Co-locate all descriptor-related members. vkd3d: Rename the device mutex to pipeline_cache_mutex. vkd3d: Write Vulkan descriptors in a worker thread. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/292

2 4

[PATCH v2 0/3] MR524: tests/shader-runner: Check for 64-bit support in the d3d11 and Vulkan runners.
by Conor McCarthy (＠cmccarthy) 14 Dec '23

14 Dec '23

-- v2: tests/shader-runner: Check for int64 support in the Vulkan runner. tests/shader-runner: Check for float64 support in the Vulkan runner. tests/shader-runner: Check for float64 support in the d3d11 runner. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/524

2 3