December 2023 - Wine-gitlab

Re: [PATCH v10 0/6] MR4484: comctl32: Use selected font to determine default min tab width - approved
by Alexandre Julliard (＠julliard) 08 Dec '23

08 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4484

1 0

Re: [PATCH v2 0/2] MR4649: user32/tests: Add tests for word breaks before punctuation - approved
by Alexandre Julliard (＠julliard) 08 Dec '23

08 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4649

1 0

Re: [PATCH v3 0/6] MR4625: wined3d: Reduce command stream CPU usage, part 2 - approved
by Alexandre Julliard (＠julliard) 08 Dec '23

08 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4625

1 0

Re: [PATCH v3 0/1] MR4648: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) 08 Dec '23

08 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4648

1 0

[PATCH 0/5] MR4656: quartz: Implement VMR7 renderless mode.
by Zebediah Figura (＠zfigura) 08 Dec '23

08 Dec '23

This isn't all of what Rewrite needs, but it's the large and risky part that would be inappropriate for code freeze. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4656

2 5

[PATCH 0/1] MR4655: ntdll: loader_init() invoke breakpoint before loading dlls
by Dāvis Mosāns 08 Dec '23

08 Dec '23

While using [x64dbg](https://x64dbg.com/) I was experiencing incredibly strange issue - `int3` was swallowed and `KiUserExceptionDispatcher` was never invoked. Turns out that x64dbg ([TitanEngine](https://github.com/x64dbg/TitanEngine/blob/x64dbg/TitanEngine/…) expects system breakpoint to be first breakpoint that will be triggered and it always swallows it (it's hardcoded no setting to change it's behavior). That means if you have a DLL with `int3` for example ```c LONG ExceptionHandler(EXCEPTION_POINTERS *ExceptionInfo) { ExceptionInfo->ContextRecord->Rip++; return EXCEPTION_CONTINUE_EXECUTION; } BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) { if (fdwReason == DLL_PROCESS_ATTACH) { AddVectoredExceptionHandler(1, ExceptionHandler); asm("int $0x03; nop; nop;"); } return TRUE; } ``` That `int3` would be swallowed and `ExceptionHandler` never invoked when running under x64dbg. Now with this MR applied it works correctly and as expected (same as on Windows). Another interesting thing is that without this MR it wouldn't just swallow `int3` but even skip first `nop` aswell and RIP would end up on 2nd `nop`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4655

1 1

[PATCH v3 0/1] MR4620: kernel32: Implement GetProcessInformation(ProcessMachineTypeInfo).
by Nikolay Sivov (＠nsivov) 08 Dec '23

08 Dec '23

Marking as a draft for now, until !4605 is merged first. -- v3: kernel32: Implement GetProcessInformation(ProcessMachineTypeInfo). https://gitlab.winehq.org/wine/wine/-/merge_requests/4620

3 3

[PATCH 0/1] MR4630: explorer: Add an "Exit desktop" button to the Start menu.
by Alex Henrie (＠alexhenrie) 08 Dec '23

08 Dec '23

When running `wine explorer.exe /desktop=shell` as a full-screen app, there is no obvious way to close it and return to the Linux desktop. Remedy that problem by adding an "Exit desktop" button to the Start menu in the same place as the "Shut Down" button on Windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4630

3 2

[PATCH v9 0/6] MR4484: comctl32: Use selected font to determine default min tab width
by Brendan McGrath (＠redmcg) 08 Dec '23

08 Dec '23

This fixes the layout of the tabcontrol when a font other than the system font is used. -- v9: comctl32/tests: Modify test_width to try different fonts comctl32/tests: Check size initially and after changing padding only comctl32/tests: Fix tabcontrol tests to work with different fonts comctl32: Use selected font to determine default min tab width https://gitlab.winehq.org/wine/wine/-/merge_requests/4484

3 8

Re: [PATCH v4 0/1] MR4393: gdiplus: Boost performance of GdipDrawImagePointsRect.
by Esme Povirk (＠madewokherd) 08 Dec '23

08 Dec '23

I agree, there's no reason to essentially inline floorf here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4393#note_55554

1 0