December 2023 - Wine-gitlab

[PATCH v2 0/1] MR516: tests: Print the failing line numbers when a test fails.
by Petrichor Park (＠petrathekat) 11 Dec '23

11 Dec '23

Currently, if a probe fails, it will print the line number of the [test] block the probe is in, not the line number of the probe itself. This makes it somewhat difficult to debug. This commit makes it print the line number that a test fails at. This code was actually written by @hverbeet for my first attempt at fixing this, !499. CC @zfigura -- v2: tests: Print the failing line numbers when a test fails. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/516

3 2

[PATCH v2 0/9] MR4637: bcrypt DH improvements
by Hans Leidekker (＠hans) 11 Dec '23

11 Dec '23

Support for generating keys from known DH parameters is not included unfortunately because even the latest stable GnuTLS release doesn't have the necessary support. I have a patch that implements it using _gnutls_dh_generate_key() but that requires a special GnuTLS 3.8.2 build (--enable-fips140-mode). With that patch all included tests pass here. Paul, can you take a look? I included your tests so please approve this MR if you think it's okay. -- v2: bcrypt/tests: Add DH tests. bcrypt: Make sure key_asymmetric_derive_key() returns correct size. bcrypt: Add support for generating DH keys from known parameters. bcrypt: Reject DH keys smaller than 512 bits. bcrypt: Make DH blob size validation more strict in key_import_pair(). bcrypt: Add helpers to create a public/private key pair. bcrypt: Allow or disallow some operations based on whether keys are finalized. bcrypt: Add support for retrieving DH parameters. bcrypt: Add support for setting DH parameters. https://gitlab.winehq.org/wine/wine/-/merge_requests/4637

3 15

[PATCH 0/1] MR4668: winewayland.drv: Avoid deadlock when determining whether a window is managed.
by Alexandros Frantzis (＠afrantzis) 11 Dec '23

11 Dec '23

The is_window_managed function may acquire the (non-recursive) win_data lock internally (is_window_managed->has_owned_popups->is_managed), so do not call it with the win_data lock held. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55995 --- Note: WineX11 also calls `is_window_managed` with win_data locked, but its win_data mutex is recursive. I haven't found a compelling reason to use a recursive win_data mutex in the Wayland driver yet, hence this fix. --- A simple way to reproduce the deadlock is: 1. Run winecfg 2. Go to the "Desktop Integration" tab 3. Click on OK -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4668

2 1

[PATCH 0/4] MR504: ci: Validate the SPIR-V code.
by Giovanni Mascellani (＠giomasce) 11 Dec '23

11 Dec '23

In order to validate SPIR-V code we have to fix a little bug that causes us to emit invalid SPIR-V code in some cases. That's technically a bug, so it should be good to fix it in 1.10; unfortunately the way the bug is fixed right now is not ideal, because in some cases it causes many push constants to be wasted, potentially reaching the Vulkan implementation limit, so some application that used to work might stop working. Eventually we should implement a better allocator for push constants, and include an alternative path if the Vulkan implementation doesn't offer enough push constants. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/504

4 7

[PATCH 0/1] MR4660: gdiplus: Fix invalid pointer returned when failing to create font
by Hans Lehnert (＠hanslehnert) 11 Dec '23

11 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4660

4 4

[PATCH v2 0/1] MR4666: gdiplus: Prevent uninitializd memory access (Coverity)
by Fabian Maurer (＠DarkShadow44) 11 Dec '23

11 Dec '23

-- v2: gdiplus: Prevent uninitializd memory access (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/4666

3 3

[PATCH v3 0/1] MR4666: gdiplus: Prevent uninitializd memory access (Coverity)
by Fabian Maurer (＠DarkShadow44) 11 Dec '23

11 Dec '23

-- v3: gdiplus: Prevent uninitializd memory access (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/4666

3 2

[PATCH v2 0/1] MR4665: winegstreamer: In error case don't dereference null pointer (Coverity)
by Fabian Maurer (＠DarkShadow44) 10 Dec '23

10 Dec '23

-- v2: winegstreamer: In error case don't dereference null pointer (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/4665

2 2

[PATCH 0/1] MR4665: winegstreamer: In error case don't dereference null pointer (Coverity)
by Fabian Maurer (＠DarkShadow44) 10 Dec '23

10 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4665

3 5

[PATCH v3 0/2] MR4658: gidplus: Add GdipGetEffectParameterSize stub, fix GdipDeleteEffect and update test.
by Bartosz Kosiorek (＠gang65) 10 Dec '23

10 Dec '23

-- v3: gdiplus/test: Add GdipGetEffectParameterSize test. gdiplus: Add GdipGetEffectParameterSize stub and fix GdipDeleteEffect https://gitlab.winehq.org/wine/wine/-/merge_requests/4658

2 4