February 2023 - Wine-gitlab

[PATCH v2 0/2] MR2226: gdi32: Track ticks since draw start per window_surface.
by Alexandros Frantzis (＠afrantzis) 17 Feb '23

17 Feb '23

Track ticks since draw start per window_surface, instead of per DC as is currently the case. This change helps reduce visual glitches caused by badly timed flushes when drawing to the same window_surface from multiple DCs, e.g., child windows (see first commit), or in some special scenarios when the window_surface is updated (see second commit). (Much) more information about this issue and the rationale for the changes can be found in the commit messages. Note that since this is an inherently timing related issue, the visual glitches depend on the application specific draw patterns, drawing speed (and thus processor performance and load) etc. Here is a capture which exhibits the issue with the current implementation: [resizing-regedit-per-dc-ticks.mkv](/uploads/d7d30d009cc4db1337cbc3266df5ae17/resizing-regedit-per-dc-ticks.mkv) And here is a capture of the same scenario with the proposed changes applied, which shows the improvement: [resizing-regedit-per-surface-ticks.mkv](/uploads/6f878568862f5fb5157567341e4e452f/resizing-regedit-per-surface-ticks.mkv) -- v2: win32u: Reset draw_start_ticks for new window_surface. gdi32: Track ticks since draw start per window_surface. https://gitlab.winehq.org/wine/wine/-/merge_requests/2226

2 2

[PATCH v10 0/8] MR84: vkd3d-shader/spirv: Merge all shader IR fork and join phases into a single phase.
by Conor McCarthy (＠cmccarthy) 17 Feb '23

17 Feb '23

Normalise the incoming vkd3d_shader_instruction IR to the shader model 6 pattern where only one patch constant function is emitted. This allows generation of a single patch constant function in SPIR-V. -- v10: vkd3d-shader/normalise: Insert hull shader control point input declarations if no control point phase is defined. vkd3d-shader/spirv: Delete an unnecessary call to spirv_compiler_get_register_id(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/84

4 15

[PATCH v13 0/5] MR2091: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl 17 Feb '23

17 Feb '23

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v13: windows.media.speech: Implement Vosk create and release functions in the unixlib. windows.media.speech/tests: Allow the SpeechRecognizer creation to fail in Wine. windows.media.speech/tests: Get rid of duplicated hresult. windows.media.speech: Add unixlib stub. windows.media.speech: Add Vosk checks to autoconf. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

2 7

[PATCH 0/5] MR2159: winegstreamer: Stride and RGB formats, part 2/2.
by Zebediah Figura (＠zfigura) 17 Feb '23

17 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2159

5 11

[PATCH 0/2] MR2149: wineps: Use CRT functions for memory allocation on the process heap.
by Alex Henrie (＠alexhenrie) 17 Feb '23

17 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2149

4 6

[PATCH v5 0/6] MR1889: bthprops.cpl: Add BluetoothRegisterForAuthenticationEx stub.
by Mohamad Al-Jaf (＠maljaf) 17 Feb '23

17 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54112 -- v5: bluetoothapis: Add BluetoothUnregisterAuthentication stub. bluetoothapis: Add BluetoothRegisterForAuthenticationEx stub. include/bluetoothapis: Add BluetoothRegisterForAuthenticationEx prototype. irprops.cpl: Import implementations from bluetoothapis. bthprops.cpl: Import implementations from bluetoothapis. bthprops.cpl: Move implementations to bluetoothapis. https://gitlab.winehq.org/wine/wine/-/merge_requests/1889

3 8

[PATCH v5 0/2] MR2183: winecfg: Add an option to enable WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) 17 Feb '23

17 Feb '23

This is what it looks like: **v1** ![Screenshot_20230213_212244](/uploads/14156031c91d4da29fc49ed9831b599a/Screenshot_20230213_212244.png) **v2** ![winecfg](/uploads/f610908b8ed2fbece6ef09ee5bd4d13e/winecfg.png) -- v5: winecfg: Add an option to enable WinRT app dark theme. https://gitlab.winehq.org/wine/wine/-/merge_requests/2183

3 4

[PATCH v3 0/5] MR2177: win32u: Get monitor name from EDID when possible
by Paul Gofman (＠gofman) 17 Feb '23

17 Feb '23

There are two common ways I observe how games get monitor name to display: 1. Registry key under Enum/Display (also present in EnumDisplayDevicesA result for monitors). On Windows this key is derived from edid as 'Manufacturer ID' (3 letters) combined with "Manufacturer product code" (4 hex digits). We currently have 'Default_Display' there for all the displays; 2. DisplayConfigGetDeviceInfo(DISPLAYCONFIG_DEVICE_INFO_GET_TARGET_NAME). Windows sets friendlyNameFromEdid flag and returns a name from 'EDID Display Descriptor' with code 0xfc ("Display name"). As far as I could see by searching through the Windows registry this name doesn't seem to be explicitly present anywhere in registry (besides binary raw edid of course). The first patch removes name from the gdi driver's display structure. Now none of the drivers set anything genuine there. x11 and winemac always end up with "Generic Non-Pnp Monitor" string, wineandroid sets NULL there and "Generic Non-Pnp Monitor" is set in win32u in this case. That "Generic Non-Pnp Monitor" goes to "DeviceDesc" registry value. While our value doesn't match Windows string exactly, Windows also doesn't have any meaningful name under DeviceDesc (and contains "Generic Non-Pnp Monitor" as a part of it). So this patch is essentially a no-op currently. Going forward my idea is that we just want to have edid from drivers. If the raw one is not available we can generate fallback one ourselves based on the info about the monitor we might have from elsewhere in the drivers. My motivation is: - EDID is sometimes queried by apps directly, and it is better to provide a true one or a synthetic one with as much of accurate info as possible / reasonable; - There is more info in EDID, e. g., colorimetry for HDR support in d3d. As far as I can tell, there is no documented way to query HDR info on Windows besides dxgi interfaces (which in case on Wine are based on gdi drivers for such things and can hardly become a genine source of such info in Wine) and WinRT interface (for which I don't know where it takes the info on Windows but we probably don't want to make it a lower level source of such info in Wine). The alternative would be, instead of basing higher level win32u on EDID, parse EDID in drivers instead and add all the necessary info into gdi_monitor structure (instead of removing display name from there), but so far it seems less straightforward to me. -- v3: win32u: Get friendly monitor name from EDID in NtUserDisplayConfigGetDeviceInfo(). win32u: Return edidManufactureId and edidProductCodeId from NtUserDisplayConfigGetDeviceInfo(). win32u: Store EDID info in monitors cache. win32u: Use monitor ID from EDID when available. win32u: Remove monitor name from gdi driver monitor info. https://gitlab.winehq.org/wine/wine/-/merge_requests/2177

3 8

[PATCH v4 0/2] MR2183: winecfg: Add an option to enable WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) 17 Feb '23

17 Feb '23

This is what it looks like: **v1** ![Screenshot_20230213_212244](/uploads/14156031c91d4da29fc49ed9831b599a/Screenshot_20230213_212244.png) **v2** ![winecfg](/uploads/f610908b8ed2fbece6ef09ee5bd4d13e/winecfg.png) -- v4: winecfg: Add an option to enable WinRT app dark theme. https://gitlab.winehq.org/wine/wine/-/merge_requests/2183

3 5

[PATCH v16 0/2] MR2105: ddraw: Add local buffer in d3d_device7_DrawPrimitive()
by Steve Schnepp (＠steveschnepp) 17 Feb '23

17 Feb '23

Convert all consecutive calls to d7_DrawPrimitive(TRIANGLE_FAN) into a single call to d7_DrawPrimitive(TRIANGLE_LIST) with all the vertices. Note, it *increase* the number of vertices, but bandwith is much less costly than multiple calls. Note, only a very precise subset of the calls get buffered in order to ensure that the disruption is minimal. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33814 -- v16: ddraw: Also Buffer D3DPT_POINTLIST ddraw: Add a local buffer in d3d_device7_DrawPrimitive() https://gitlab.winehq.org/wine/wine/-/merge_requests/2105

2 2