February 2023 - Wine-gitlab

[PATCH 0/5] MR2192: Wined3d: move stubs out of state tables
by Max Figura (＠maxfigura) 17 Feb '23

17 Feb '23

Removing WINED3D_RS entries from state tables and moving stubs to wined3d_device_apply_stateblock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2192

4 7

[PATCH v14 0/6] MR2105: ddraw: Add local buffer in d3d_device7_DrawPrimitive()
by Steve Schnepp (＠steveschnepp) 17 Feb '23

17 Feb '23

Convert all consecutive calls to d7_DrawPrimitive(TRIANGLE_FAN) into a single call to d7_DrawPrimitive(TRIANGLE_LIST) with all the vertices. Note, it *increase* the number of vertices, but bandwith is much less costly than multiple calls. Note, only a very precise subset of the calls get buffered in order to ensure that the disruption is minimal. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33814 -- v14: ddraw: Convert buffer API to use d3d_device struct https://gitlab.winehq.org/wine/wine/-/merge_requests/2105

3 7

[PATCH v12 0/5] MR2091: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl 16 Feb '23

16 Feb '23

Second commit is to be removed. Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v12: windows.media.speech: Implement Vosk create and release functions in the unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

2 12

[PATCH 0/2] MR2215: winsock: Fix two connect() issues.
by Paul Gofman (＠gofman) 16 Feb '23

16 Feb '23

I was mainly after the issue fixed by the second patch but stomped on another one while testing that and that one looks even more unfortunate to me. 1. When connect() is used on blocking socket and fails for whatever reason, next connect() will make a new independent connection attempt (both on Windows and Unix). In non-blocking mode however (and Unix sockets are always in non-blocking mode in Wine) on Linux the next connect() will always return an error (unlike Windows which will make a new connect attempt if the previous one completed and failed). So in Wine now even for blocking socket connect() will fail if previous attempt failed and return WSAECONNABORTED. The error returned by Linux connect() will be ECONNABORTED if getsockopt(SO_ERROR) was called on the socket after connect completed with failure, and true connect() fail error if getsockopt wasn't called. 2. connect() on blocking socket times out after ~21sec on Windows and after ~130 sec on Linux. That is the case when peer doesn't actively reject connection but just never replies anything. That is, client sent SYN and never heard back. So much longer timeout leads to what is seen as hang on exit in one game, but probably more important that it affect much more in various apps provoking timeouts or huge delays not just on exit. I did not find a way to set connect() timeout for socket on Windows. That difference mostly corresponds to number of SYN send retries. That is 7 on Linux by default and 4 on Windows (the delay between attempts starts from 1s and is doubled on each next attempt). There is TCP_SYNCNT socket option (Linux specific now, unfortunately) which allows to set the number of retries. Setting that to 4 yields 32 sec timeout (vs 21 sec on Windows). The remaining difference is probably due to different amount of time waited after last SYN is sent. There is also TCP_USER_TIMEOUT parameter which allows to effectively set the delay exactly, but it might interfere with SO_KEEPALIVE somehow and I hope that 32 vs 21 is not that critical already as 130 vs 21 and probably we can avoid complicating the thing with it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2215

3 3

Re: [PATCH v3 0/1] MR2190: winspool: Initialize nt_ppd in add_printer_driver. - approved
by Alexandre Julliard (＠julliard) 16 Feb '23

16 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2190

1 0

Re: [PATCH v4 0/1] MR2214: vbscript: fix compile issue with non hex after concat without space - approved
by Alexandre Julliard (＠julliard) 16 Feb '23

16 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2214

1 0

Re: [PATCH v3 0/2] MR2158: ntdll: Fix compile error on ARM64 macOS. - approved
by Alexandre Julliard (＠julliard) 16 Feb '23

16 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2158

1 0

Re: [PATCH v2 0/2] MR2219: dinput: Forbid acquiring for other process windows and hook foreground window threads. - approved
by Alexandre Julliard (＠julliard) 16 Feb '23

16 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2219

1 0

Re: [PATCH v3 0/1] MR2212: riched20/tests: Add context to the EM_FORMATRANGE tests. - approved
by Alexandre Julliard (＠julliard) 16 Feb '23

16 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2212

1 0

Re: [PATCH v2 0/1] MR2211: riched20/tests: Check clipboard content after destroying the editor window. - approved
by Alexandre Julliard (＠julliard) 16 Feb '23

16 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2211

1 0