February 2023 - Wine-gitlab

[PATCH v3 0/4] MR2170: joy.cpl: Improve DInput display with many buttons.
by Rémi Bernon 13 Feb '23

13 Feb '23

-- v3: joy.cpl: Use the DIJOYSTATE2 user data format to support more buttons. joy.cpl: Improve the DInput button display with many buttons. joy.cpl: Refresh the DInput button display on device change. joy.cpl: Process messages while waiting for the input threads. https://gitlab.winehq.org/wine/wine/-/merge_requests/2170

1 4

[PATCH v2 0/4] MR2170: joy.cpl: Improve DInput display with many buttons.
by Rémi Bernon 13 Feb '23

13 Feb '23

-- v2: joy.cpl: Use the DIJOYSTATE2 user data format to support more buttons. joy.cpl: Improve the DInput button display with many buttons. joy.cpl: Refresh the DInput button display on device change. joy.cpl: Process messages while waiting for the input threads. https://gitlab.winehq.org/wine/wine/-/merge_requests/2170

1 4

[PATCH 0/2] MR2169: dinput: Check foreground every 100ms instead of a callwndproc hook.
by Rémi Bernon 13 Feb '23

13 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54431 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2169

1 2

[PATCH 0/1] MR2116: ntdll: Implement RtlAddressInSectionTable.
by eric pouech (＠epo) 13 Feb '23

13 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54432 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2116

2 2

[PATCH 0/3] MR2160: bcrypt: Update IV after AES encrypt / decrypt.
by Paul Gofman (＠gofman) 13 Feb '23

13 Feb '23

Fixes Age of Empires III not being able to find its servers / multiplayer games. That regressed with the following commit: ``` commit 745df5915cf4c7411d69b4fd2ba5d05a333f3947 Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Aug 31 09:42:11 2022 +0200 bcrypt: Force symmetric key reset if necessary. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52457 ``` The core problem is not in this commit though. The bit of the commit which regressed AoE is removing ```!is_zero_vector( vector, vector_len )``` condition in key_symmetric_set_vector() which was previously also forcing key reset (which was resetting key to the set value whenever the key is nonempty). That was apparently breaking other things, that's why it was probably removed. The actual culprit is that BCryptEncrypt() / BCryptEncrypt() modify init vector on output in AES CBC and CFB mode on Windows. So, to properly sync our gnutls key we need to return the value in IV parameter like Windows does and decide whether the key needs update or not based on comparison with the actual dynamic key state, not with the value set initially. The game sets the IV data over multiple encrypt or decrypt call (sets it with its own fixed value overwriting what Windows returns in those). Before the blamed commit that worked because key_symmetric_set_vector() was always pushing the given key to gnutls. But that was breaking apps which worked differently (which way is probably a more expected usage) which set IV with their only once initially and then either: - pass the same buffer, which on Windows has the updated IV and in Wine was always the same, thus the changed in blamed commit fixed the thing by keeping the internal state of gnutls key untouched; - pass NULL buffer; this case I suppose didn't work correctly neither before nor after the blamed commit but should be also fixed by this MR. Besides newly added tests (which cover IV output data plus some additional cases of encryption with auto-modified state) the MR is fixing a few rather unfortunate existing todo's. Now, the implementation. My first instinct was to try to extract that updated state from gnutls, but: 1. It seems like there is no exported function which would give this updated state. There is _gnutls_cipher_get_iv() used in tests but it doesn't even seem to work for AES / CBC; 2. The comment above _gnutls_cipher_get_iv() says: ``` * This is solely for validation purposes of our crypto * implementation. For other purposes, the IV can be typically * calculated from the initial IV value and the subsequent ciphertext * values. ``` So it doesn't look like gnutls is planning to export anything like that. Also, it is not apparent that "init vector" is generally equivalent to the dynamic cipher hash, and the fact that Windows returns that in the IV vector back look rather implementation specific. So, also given that the updated state hash value is the simply taken from the last encrypted data block (input on decrypt and output on encrypt) I hope it is ok to just code that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2160

3 4

Re: [PATCH 0/4] MR37: user32/tests: Fix message tests that fail on Vista, Win2003, or Win2008 - closed
by Alex Henrie (＠alexhenrie) 13 Feb '23

13 Feb '23

This merge request was closed by Alex Henrie. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/37

1 0

Re: [PATCH 0/4] MR37: user32/tests: Fix message tests that fail on Vista, Win2003, or Win2008
by Alex Henrie (＠alexhenrie) 13 Feb '23

13 Feb '23

Closing, see https://gitlab.winehq.org/wine/wine/-/merge_requests/2128#note_23873 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/37#note_23884

1 0

[PATCH 0/1] MR2167: user32/tests: Remove BroadcastSystemMessage() tess for WM_DEVICECHANGE.
by Zebediah Figura (＠zfigura) 13 Feb '23

13 Feb '23

These are not uninteresting, but not consistent either, and it is not at the moment behaviour that needs to be implemented. This partially reverts 8675cad31c66b6620150a897545f705c1d17a59f. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54477 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2167

2 1

[PATCH v6 0/6] MR2091: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl 12 Feb '23

12 Feb '23

Second commit is to be removed. Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v6: windows.media.speech: Implement Vosk create and release functions in the unixlib. windows.media.speech/tests: Allow the SpeechRecognizer creation to fail in Wine. windows.media.speech/tests: Get rid of duplicated hresult. windows.media.speech: Add unixlib stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

2 7

Re: [PATCH v2 0/1] MR2128: ntdll/tests: Remove some Vista broken broken(<constant>) calls.
by Alex Henrie (＠alexhenrie) 12 Feb '23

12 Feb '23

On Wed Feb 8 21:41:12 2023 +0000, Michael Stefaniuc wrote: > WTB might support XP and Vista but those aren't part of the default test set. > Nor are they shown on https://test.winehq.org/data/ . > The winetest/dissect utility though doesn't marks them as prediluvian. Thanks for the answer. From now on I will assume that we only care about testing with the OSes shown at <https://test.winehq.org/data/>. We should probably add a note to that effect to the wiki somewhere. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2128#note_23873

1 0