February 2023 - Wine-gitlab

[PATCH 0/1] MR1945: Draft: winegstreamer: Return correct format in stream_props_GetMediaType.
by Ziqing Hui (＠zhui) 13 Mar '23

13 Mar '23

This patch doesn't work now. Zebediah, I think I need your help. My goal is to get the original stream format in `stream_props_GetMediaType()`. For example, if I use wmreader to open a WMV3 stream, then this function should return WMV3 format as its result. I expect preferred_format to hold the format I need. But test shows that preferred_format is always RGB24 even if I open a WMV stream. I found that preferred_format is written in `wg_parser.c: sink_event_cb(): case GST_EVENT_CAPS`. So it means that the caps here is "video/x-raw", not "video/x-wmv" as I expected. So how could I get the stream format I want when I open a compressed stream using wmreader? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1945

3 9

[PATCH v3 0/2] MR626: Zooming fixes
by David Kahurani (＠kahurani) 10 Mar '23

10 Mar '23

Manipulating the font size results in the script_cache going stale. From MSDN[1] `The application should never pass the same handle for different fonts or different sizes.` This is however exactly what happens when the font size changes as a result of zooming(both in and out). ScriptShape and relative functions will only inspect the hardware device context only if the required data is not cached[2] and hence the data from a previous call to these functions is retrieved even though the font size has changed hence the bug where text both doesn't wrap and doesn't paint as it should. In patch one, I have tried to keep track of the script_cache objects alongside the relevant font. Patch two fixes an issue where the cursor doesn't scale after zooming until after one interacts with the editor. Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> 1. https://docs.microsoft.com/en-us/windows/win32/intl/caching 2. https://docs.microsoft.com/en-us/windows/win32/intl/script-cache -- v3: riched20: update caret on zooming riched20: Cache script_cache alongside font cache https://gitlab.winehq.org/wine/wine/-/merge_requests/626

3 4

[PATCH v2 0/3] MR1897: kernel32/tests: Call newer functions not on Windows XP or 2003 via function addresses (locale)
by Hugh McMaster (＠hmc) 09 Mar '23

09 Mar '23

There are times when it is useful to test changes on the Windows XP and 2003 VMs, but the direct use of functions not on those platforms makes this impossible. -- v2: kernel32/tests: Call CompareStringEx via function address (locale.c) kernel32/tests: Call LCIDToLocaleName via function address (locale.c) kernel32/tests: Call LCMapStringEx via function address (locale.c) https://gitlab.winehq.org/wine/wine/-/merge_requests/1897

2 4

[PATCH v14 0/6] MR1445: kernelbase: Some refactoring of the open_key() and create_key() functions.
by Sven Baars (＠sbaars) 09 Mar '23

09 Mar '23

This is in preparation of implementing all logic from the server in kernelbase, which is needed because Nt*Key ignores KEY_WOW64_32KEY. Unfortunately this requires a lot of server calls. The full branch can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-new The old approach that doesn't duplicate code to kernelbase can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-old I ran make_requests by the way, not sure if we should still leave that out with the gitlab workflow. -- v14: kernelbase: Restructure the create_key() loop. kernelbase: Add a fast path to create_key(). kernelbase: Move create_key() below open_key(). kernelbase: Factor opening a subkey out of open_key(). kernelbase: Always try to open the Wow6432Node in open_key(). kernelbase: Restructure the open_key() loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/1445

3 10

[PATCH v3 0/7] MR1964: Draft: dxgi: Catch nested SetFullscreenState invocations.
by Stefan Dösinger 09 Mar '23

09 Mar '23

FFXIV depends on this. It calls SetFullscreenState when it receives WM_WINDOWPOSCHANGED. Through luck the recursion aborts after two calls. The user-visible bug is that after leaving fullscreen, the game's window is still TOPMOST because we overwrite the stored pre-fullscreen window flags. -- v3: dxgi/tests: Test nested SetFullscreenState from the same thread. dxgi/tests: Test nested fullscreen application from different thread. dxgi: Catch nested SetFullscreenState invocations. dxgi: Unlock the wined3d mutex after storing the new target. dxgi/tests: Run test_swapchain_window_messages on d3d12. dxgi/tests: Run test_resize_target_wndproc on d3d12 too. dxgi/tests: Fix UnregisterClass call in test_resize_target_wndproc. https://gitlab.winehq.org/wine/wine/-/merge_requests/1964

4 15

[PATCH v5 0/5] MR2296: Always use the user images for the D3D12 swapchain
by Giovanni Mascellani (＠giomasce) 08 Mar '23

08 Mar '23

-- v5: dxgi: Reset the back buffer index to zero on ResizeBuffers(). dxgi/tests: Test that ResizeBuffers() resets the back buffer index to zero. dxgi: Always assume that a D3D12 swapchain always uses user images. dxgi: Immediately error out when creating a D3D12 swapchain on a non-immediate queue. d3d12/tests: Test that D3D12 swapchains can only be created on direct command queues. https://gitlab.winehq.org/wine/wine/-/merge_requests/2296

4 7

[PATCH 0/4] MR2252: Wow64 tests fixes on Windows 11.
by eric pouech (＠epo) 08 Mar '23

08 Mar '23

A couple of tests (ntdll, psapi, dbghelp) were failing when running on Windows 11 platform. These tests were creating a new process out of c:\windows\syswow64\notepad.exe and expecting a wow64 32bit child process. Under Windows 11, notepad has been migrated into the UWP framework and the operation above creates a 64bit process. This series replace all the cases above with msinfo32.exe which still have the properties we expected for such an application. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2252

3 7

[PATCH 0/1] MR2266: makedep: Support resource files for embedded TESTDLL.
by Rémi Bernon 08 Mar '23

08 Mar '23

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/2221, this would let us customize testdll version info. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2266

2 5

[PATCH v2 0/5] MR2298: winewinrt: Introduce new WinRT common module.
by Rémi Bernon 08 Mar '23

08 Mar '23

The idea I have is to use this module to declare class stubs until there is a good reason to split them to dedicated modules. WinRT modules aren't usually loaded directly, and instead the registry is queried to figure which module to load for which class. This would help avoiding unnecessary proliferation of stub WinRT modules, while at the same time allowing to factor WinRT foundation code (such as vector / async, etc...) between the modules that seem to deserve to be implemented separately. The relevant classes could then be split out to dedicated modules on a as-needed basis, when they get fleshed out. -- v2: winewinrt: Move Vector<HSTRING> from windows.media.speech. windows.media.speech: Use Vector<IInspectable> from winewinrt. winewinrt: Rename Vector<IInspectable> structs and methods. winewinrt: Move Vector<IInspectable> from windows.gaming.input. winewinrt: Introduce new WinRT common module. https://gitlab.winehq.org/wine/wine/-/merge_requests/2298

4 11

[PATCH v5 0/4] MR2258: winegstreamer: Support WMV DMO decoder.
by Ziqing Hui (＠zhui) 07 Mar '23

07 Mar '23

-- v5: winegstreamer: Implement ProcessInput and ProcessOutput for WMV decoder DMO. winegstreamer: Create wg_transform for WMV decoder. winegstreamer: Better handle framerate. winegstreamer: Add format field to wmv wg_format. https://gitlab.winehq.org/wine/wine/-/merge_requests/2258

5 13