February 2023 - Wine-gitlab

[PATCH v17 0/2] MR2100: ntdll: Do not send data to port 0.
by Jason Beetham (＠beef331) 09 Feb '23

09 Feb '23

On Windows it seems sending to port 0 does nothing and does not error. Presently sendmsg errors with EINVAL. This works around it, by checking if it's port 0 then skipping the data. -- v17: ntdll: Do not send data to port 0. https://gitlab.winehq.org/wine/wine/-/merge_requests/2100

2 2

[PATCH v3 0/3] MR84: vkd3d-shader/spirv: Normalise inputs and outputs to the Shader Model 6 pattern.
by Conor McCarthy (＠cmccarthy) 09 Feb '23

09 Feb '23

Multiple fork and join phases are eliminated. Signature elements are merged where required, and all input/output parameters are rewritten. -- v3: vkd3d-shader/spirv: Move the function declaration from spirv_compiler_begin_shader_phase() to spirv_compiler_enter_shader_phase(). vkd3d-shader/spirv: Remove the hull shader phase array. vkd3d-shader/spirv: Merge all shader IR fork and join phases into a single phase. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/84

4 5

[PATCH 0/1] MR2153: win32u: invalidate all cached keys after input
by Henry Goffin (＠AMZN-hgoffin) 09 Feb '23

09 Feb '23

This patch addresses an issue in Second Life and potentially other multi-threaded applications which process WM_KEYDOWN in one thread and then verify that the key is "still down" with GetAsyncKeyState from another thread. Wine uses a per-thread key cache, resulting in inconsistent views of key status. Caches are now invalidated when an input event is injected by the driver or via SendInput. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2153

2 2

[PATCH v3 0/1] MR2141: vbscript: Fix memory leak in owned safearray iterator
by Jason Millard (＠jsm174) 09 Feb '23

09 Feb '23

While running in XCode's profiler, I noticed memory leaks when safearrays were used in `For Each` statements. The following code would leak a safearray allocation: ``` For Each obj In vpDict.Keys : Debug.Print "Key" : Next ``` This following code does not leak: ``` Dim x x = vpDict.Keys For Each obj In x : Debug.Print "Key" : Next ``` Fixes: https://bugs.winehq.org/show_bug.cgi?id=54456 -- v3: vbscript: Fix memory leak in owned safearray iterator https://gitlab.winehq.org/wine/wine/-/merge_requests/2141

3 3

[PATCH v2 0/1] MR2142: vbscript: fix compile when colon follows Else on new line
by Jason Millard (＠jsm174) 09 Feb '23

09 Feb '23

I ran into a script where someone placed a `:` on a new line after an `Else` but before another statement: ``` Else : VelCoef = LinearEnvelope(BallPos, VelocityIn, VelocityOut) if Enabled then aBall.Velx = aBall.Velx*VelCoef if Enabled then aBall.Vely = aBall.Vely*VelCoef end if ``` I confirmed that this is allowed and works. I've updated the grammar, and replaced `NL` with `StSep_opt` as it seems to cover all the bases. Fixes: https://bugs.winehq.org/show_bug.cgi?id=54234 -- v2: vbscript: fix compile when colon follows Else on new line https://gitlab.winehq.org/wine/wine/-/merge_requests/2142

3 2

[PATCH v2 0/5] MR2098: mshtml: Implement synchronous XMLHttpRequests.
by Gabriel Ivăncescu 09 Feb '23

09 Feb '23

wine-gecko does actually support synchronous XMLHttpRequests, even if they are deprecated, but unfortunately it is very broken compared to IE or all the other major browsers (more details [here](https://bugzilla.mozilla.org/show_bug.cgi?id=697151)) Thankfully, it still provides us with the event message loop, which is enough to fix it on mshtml side and act like IE. For sync XHRs, send() is supposed to block all script code, except for notifications sent to the sync XHR. This is because when send() blocks, no other piece of code in the script should execute other than the sync XHR handlers. Unfortunately, that's not the case in Gecko's broken implementation, which can execute handlers as if they were APCs while it's "blocked" in send(). Note that it doesn't actually block, though, because we still process the message loop (non-event related tasks such as navigation, paints, and other stuff), and that's normal. Gecko doesn't block everything related to script events, only some things on the document and timers, but that's far from enough and not even enough for our purposes since we use our own timer tasks. And not even message events are blocked, even though we *also* use our own message event dispatchers (but it doesn't block Gecko ones either). So what we have to do is we need to track all the timers and events dispatched that result in script handlers being executed, while "blocking" inside of a sync XHR send(), and queue them up to defer them to be dispatched later, after send() unblocks. But this is easier said that done. There are many corner cases to consider here, for example: * Events dispatched *synchronously* from within a sync XHR handler or other piece of code called from it. * Nested sync XHR send() calls (called during handler of another sync XHR). * Async XHRs having their events dispatched during a blocking sync XHR send() are complicated. `readyStateChange` for example needs to have the async XHR's readyState at the time it was sent, **not** at the time it was actually dispatched, since we're going to delay it and dispatch it later. It's similar with other XHR states, such as responseText (which can be partial). * Aborts of async XHRs during such handlers. These patches hopefully should address all the issues and, on a high level, work like this: * Track the `readyState` and `responseText` length manually, so we can override / force them to specific values. * "Snapshot" the async XHR at the time we encounter an event for it, and queue this event with such information. When later dispatching this event (after being deferred), we temporarily set the state of the async XHR to the snapshot. * To deal with nested event dispatches, keep track of a "dispatch depth" (everytime we dispatch an event we increase the depth, and when it returns we decrease it). * For sync XHRs, we note the depth when send() is called, and defer events at that depth, since they're dispatched during the "blocked" message loop and need to be delayed (except for sync XHR events, which is a special case since it must be dispatched synchronously). When it returns, we restore the previous blocking depth. -- v2: mshtml: Send all readystatechange events for synchronous XHRs in IE9 mshtml: Implement synchronous XMLHttpRequest. mshtml: Track responseText's length in XHRs and report it manually. mshtml: Track readyState in XHRs and report it manually. mshtml: Pass optional args to XMLHttpRequest.open() correctly. https://gitlab.winehq.org/wine/wine/-/merge_requests/2098

3 14

[PATCH 0/1] MR2143: vbscript: add missing stubs for GetLocale and SetLocale builtins
by Jason Millard (＠jsm174) 09 Feb '23

09 Feb '23

I ran into a script that was calling `SetLocale`. I didn't realize this was a built in function as it was missing in the `global_props` array and I couldn't find it defined in the script. After some research, I found it here: https://www.oreilly.com/library/view/vbscript-in-a/0596004885/re172.html This just adds the stubs for `GetLocale` and `SetLocale` so they can hopefully be implemented later. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2143

3 2

[PATCH 0/1] MR2142: vbscript: fix compile when colon follows Else on new line
by Jason Millard (＠jsm174) 09 Feb '23

09 Feb '23

I ran into a script where someone placed a `:` on a new line after an `Else` but before another statement: ``` Else : VelCoef = LinearEnvelope(BallPos, VelocityIn, VelocityOut) if Enabled then aBall.Velx = aBall.Velx*VelCoef if Enabled then aBall.Vely = aBall.Vely*VelCoef end if ``` I confirmed that this is allowed and works. I've updated the grammar, and replaced `NL` with `StSep_opt` as it seems to cover all the bases. Fixes: https://bugs.winehq.org/show_bug.cgi?id=54234 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2142

3 2

[PATCH v2 0/1] MR2141: vbscript: Fix memory leak in owned safearray iterator
by Jason Millard (＠jsm174) 09 Feb '23

09 Feb '23

While running in XCode's profiler, I noticed memory leaks when safearrays were used in `For Each` statements. The following code would leak a safearray allocation: ``` For Each obj In vpDict.Keys : Debug.Print "Key" : Next ``` This following code does not leak: ``` Dim x x = vpDict.Keys For Each obj In x : Debug.Print "Key" : Next ``` Fixes: https://bugs.winehq.org/show_bug.cgi?id=54456 -- v2: vbscript: Fix memory leak in owned safearray iterator https://gitlab.winehq.org/wine/wine/-/merge_requests/2141

3 2

[PATCH v2 0/2] MR2151: ntdll: Look at CurrentMajor/MinorVersionNumber registry values before CurrentVersion.
by Hans Leidekker (＠hans) 09 Feb '23

09 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54463 -- v2: ntdll: Look at CurrentMajor/MinorVersionNumber registry values before CurrentVersion. ntdll: Initialize PEB version numbers with Windows 10 values. https://gitlab.winehq.org/wine/wine/-/merge_requests/2151

2 2