February 2023 - Wine-gitlab

[PATCH v3 0/1] MR2132: vbscript: Fix memory leak in interp_redim_preserve
by Jason Millard (＠jsm174) 08 Feb '23

08 Feb '23

While running in XCode's profiler, I noticed two memory leaks in `interp_redim_preserve`. After looking at `interp_redim`, the `bounds` structure is freed. I've updated `interp_redim_preserve` to free `bounds` when the array is NULL and not NULL. -- v3: vbscript: Fix memory leak in interp_redim_preserve https://gitlab.winehq.org/wine/wine/-/merge_requests/2132

3 3

Re: [PATCH v9 0/2] MR821: Replace obsolete RtlUniform tests that no longer work (currently skipped) since Windows Vista; update RtlUniform impl.
by Jinoh Kang (＠iamahuman) 08 Feb '23

08 Feb '23

Jinoh Kang (@iamahuman) commented about dlls/ntdll/rtl.c: > + * the 32-bit addition above to handle. > + * > + * This produces an integer in the range [0x7fffffe2, 0xfffffffe]. > + */ > + result = 0x7fffffffu * 2 - result; > + > + /* Perform the 2nd round of the modulus calculation. > + * This produces an integer in the range [0, 0x7fffffff]. > + */ > + result = (result & 0x7fffffffu) + (result >> 31); > + > + /* If result is 0x7fffffff, set it to 0. We avoid branching here so that > + * RtlUniform runs in near-constant time. This also avoids unexpected > + * performance hit due to polluted branch target buffer. > + */ > + result &= -((0x7fffffffu * 2 - result) >> 31); If we assume that the right shift operator is always defined as arithmetic shift, we can optimize it further: ```suggestion:-0+0 result &= (LONG)(0x7fffffffu * 2 - result) >> 31; ``` That said, GCC (https://godbolt.org/z/65od5ErMo) does this optimization already. Meanwhile clang (https://godbolt.org/z/46x8a8r9v) seems to recognize the trick and replace it with `inc + cmovns` (since `0x7fffffff + 1` is `0x80000000` which sets SF). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/821#note_23433

1 0

[PATCH v2 0/3] MR2130: Fix missing *out=NULL in (WMReader|unknown_inner)_QueryInterface
by Ivan Chikish (＠nekotekina) 08 Feb '23

08 Feb '23

QueryInterface should set *out to NULL on failure, as it seems to do in many different places. This seems to be a regression from !888. One old game started to crash on startup with this merge request. I bisected it and it pointed to the commit 131ada052a2dbec66df695ce536ca048a2bd9174. -- v2: wmvcore/tests: check out value in check_interface https://gitlab.winehq.org/wine/wine/-/merge_requests/2130

3 4

[PATCH 0/1] MR2132: vbscript: Fix memory leak in interp_redim_preserve
by Jason Millard (＠jsm174) 08 Feb '23

08 Feb '23

While running in XCode's profiler, I noticed two memory leaks in `interp_redim_preserve`. After looking at `interp_redim`, the `bounds` structure is freed. I've updated `interp_redim_preserve` to free `bounds` when the array is NULL and not NULL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2132

3 2

[PATCH v2 0/2] MR2136: Msdasql call sql driver connect w
by Alistair Leslie-Hughes (＠alesliehughes) 08 Feb '23

08 Feb '23

-- v2: msdasql: Use SQLDriverConnectW to connect to the ODBC driver https://gitlab.winehq.org/wine/wine/-/merge_requests/2136

2 2

[PATCH 0/1] MR2135: ole32: Avoid calling RtlInitUnicodeString on a static constant.
by Alex Henrie (＠alexhenrie) 08 Feb '23

08 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2135

3 2

[PATCH 0/2] MR2136: Msdasql call sql driver connect w
by Alistair Leslie-Hughes (＠alesliehughes) 08 Feb '23

08 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2136

3 3

[PATCH 0/1] MR1974: rpcrt4/tests: Remove a failing test.
by Huw Davies (＠huw) 08 Feb '23

08 Feb '23

A follow-up to !1807. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1974

4 3

[PATCH 0/2] MR2130: Fix missing *out=NULL in (WMReader|unknown_inner)_QueryInterface
by Ivan Chikish (＠nekotekina) 08 Feb '23

08 Feb '23

QueryInterface should set *out to NULL on failure, as it seems to do in many different places. This seems to be a regression from !888. One old game started to crash on startup with this merge request. I bisected it and it pointed to the commit 131ada052a2dbec66df695ce536ca048a2bd9174. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2130

3 3

Re: [PATCH v2 0/2] MR2114: kernelbase: Fix performance of beatmap search in osu! Stable.
by Torge Matthies (＠tmatthies) 08 Feb '23

08 Feb '23

On Wed Feb 8 01:17:39 2023 +0000, Torge Matthies wrote: > I can remove the second commit if desired, the first commit is enough to > make performance acceptable again. Also note that there are some more details about the commits in the commit message bodies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2114#note_23391

1 0