February 2023 - Wine-gitlab

[PATCH v3 0/8] MR2069: jscript/mshtml: Misc fixes and preparations.
by Gabriel Ivăncescu 01 Feb '23

01 Feb '23

Bunch of misc fixes and preparations for further improvements. The location changes are especially important later when we'll use outer windows everywhere we pass them to external callers (such as script engines, since inner windows are an implementation detail and all operations otherwise should go through the outer window "proxy"). -- v3: mshtml: Embed the HTMLLocation into the outer window. mshtml: Tie window.location to the outer window. mshtml: Simplify dynamic props unlinking. mshtml: Traverse and unlink builtin func disps. mshtml: Return undefined from window.XMLHttpRequest for uninitialized jscript: Pass the correct ServiceProvider when invoking external prop. mshtml: Use Scrollbar_Auto as default for vertical scrollbars. include/mshtml: Add the other IHTMLEventObj* interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/2069

2 9

[PATCH v2 0/6] MR2087: More winedump improvement over PDB dumping.
by eric pouech (＠epo) 01 Feb '23

01 Feb '23

Continueing PDB support in winedump: - stricter size checks (to protect against bogus files) - more bits of PDB files dumped (ranges, sections, OMF details...) - keeping cleaning up some internal fields names -- v2: winedump: Be stricter about sizes while walking module's list. winedump: Properly dump segment map information from PDB/DBI stream. winedump: Dump correctly ranges' part of DBI stream. winedump: Explain a bit more errors on hash header. winedump: Correctly dump PDB_STREAM_INDEX.segment. winedump: Introduce a helper to print PE section's characteristics. https://gitlab.winehq.org/wine/wine/-/merge_requests/2087

2 7

[PATCH 0/5] MR2087: More winedump improvement over PDB dumping.
by eric pouech (＠epo) 01 Feb '23

01 Feb '23

Continueing PDB support in winedump: - stricter size checks (to protect against bogus files) - more bits of PDB files dumped (ranges, sections, OMF details...) - keeping cleaning up some internal fields names -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2087

3 6

[PATCH v4 0/1] MR74: vkd3d-shader/hlsl: Support dot() for SM1.
by Nikolay Sivov (＠nsivov) 01 Feb '23

01 Feb '23

-- v4: vkd3d-shader/hlsl: Support dot() for SM1. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/74

2 2

Re: [PATCH v3 0/1] MR74: vkd3d-shader/hlsl: Support dot() for SM1.
by Giovanni Mascellani (＠giomasce) 01 Feb '23

01 Feb '23

Broadly this feels fine to me. Other that the few little leftover issues, this should probably be split in at least three commits (one for writing DOT, one for lowering DOT and another one for writing DP2ADD). -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/74#note_22630

1 0

Re: [PATCH v3 0/1] MR74: vkd3d-shader/hlsl: Support dot() for SM1.
by Giovanni Mascellani (＠giomasce) 01 Feb '23

01 Feb '23

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_sm1.c: > + break; > + > + default: > + vkd3d_unreachable(); > + } > + break; > + > + default: > + hlsl_fixme(ctx, &expr->node.loc, "SM1 %s dot expression.", dst_type_string->buffer); > + } > + break; > + > + case HLSL_OP3_DP2ADD: > + switch (dst_type->base_type) > + { > + case HLSL_TYPE_FLOAT: Same here, of course. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/74#note_22628

1 0

Re: [PATCH v3 0/1] MR74: vkd3d-shader/hlsl: Support dot() for SM1.
by Giovanni Mascellani (＠giomasce) 01 Feb '23

01 Feb '23

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_sm1.c: > write_sm1_unary_op(ctx, buffer, D3DSIO_FRC, &instr->reg, &arg1->reg, D3DSPSM_NONE); > break; > > + case HLSL_OP2_DOT: > + switch (dst_type->base_type) > + { > + case HLSL_TYPE_FLOAT: I think that SM1 basically only supports float, which is why all the other operations do not have this switch on the data type. I am not really confident on the details of this, but I guess that only float operations should arrive here anyway. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/74#note_22624

1 0

Re: [PATCH v3 0/1] MR74: vkd3d-shader/hlsl: Support dot() for SM1.
by Giovanni Mascellani (＠giomasce) 01 Feb '23

01 Feb '23

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_sm1.c: > struct hlsl_ir_expr *expr = hlsl_ir_expr(instr); > struct hlsl_ir_node *arg1 = expr->operands[0].node; > struct hlsl_ir_node *arg2 = expr->operands[1].node; > + struct hlsl_ir_node *arg3 = expr->operands[2].node; > + const struct hlsl_type *dst_type = expr->node.data_type; > + struct vkd3d_string_buffer *dst_type_string; > > assert(instr->reg.allocated); > > + if (!(dst_type_string = hlsl_type_to_string(ctx, dst_type))) This is never released. It should be passed to `hlsl_release_string_buffer()`. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/74#note_22620

1 0

[PATCH v2 0/7] MR2078: Fixes for debugging in new wow64 setup.
by eric pouech (＠epo) 01 Feb '23

01 Feb '23

This series brings some improvements for debugging support in the new wow64 environment: - detects and adapt to the new environement - fixes a couple of bugs appearing now - adds a couple of tests - extends winedbg to hide or display the modules when multiple machines are used in the same process -- v2: dbghelp: Identify a 32bit multi-arch wow64 debuggee as a live target. winedbg: Don't expose to gdb module which machine isn't the process' one. winedbg: Handle multi-machine process in command 'info share'. dbghelp: Filter on machine when searching for Wine system PE modules. dbghelp: Allow loading modules for different machines. dbghelp: Add tests about modules loading. dbghelp: Stop unwinding on potential 64bit frame for i386 cpu. https://gitlab.winehq.org/wine/wine/-/merge_requests/2078

2 8

[PATCH v2 0/6] MR2069: jscript/mshtml: Misc fixes and preparations.
by Gabriel Ivăncescu 01 Feb '23

01 Feb '23

Bunch of misc fixes and preparations for further improvements. The location changes are especially important later when we'll use outer windows everywhere we pass them to external callers (such as script engines, since inner windows are an implementation detail and all operations otherwise should go through the outer window "proxy"). -- v2: mshtml: Embed the HTMLLocation into the outer window. mshtml: Tie window.location to the outer window. mshtml: Return undefined from window.XMLHttpRequest for uninitialized jscript: Pass the correct ServiceProvider when invoking external prop. mshtml: Use Scrollbar_Auto as default for vertical scrollbars. include/mshtml: Add the other IHTMLEventObj* interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/2069

2 8