March 2023 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR2434: include: Add memory clobber to GCC asm statement in NtCurrentTeb().
by Jinoh Kang (＠iamahuman) 21 Mar '23

21 Mar '23

Today, NtCurrentTeb() has a single asm statement when compiling for the i386, x86-64, or ARM architecture with GCC. This single asm statement has neither the "volatile" qualifier nor the "memory" clobber. This can provoke undefined behavior if the current TEB changes between NtCurrentTeb() calls. This is because GCC assumes that the asm statement does not depend on memory or the thread-local register. In fact, given the same address of the "teb" variable, GCC assumes that the asm statement produces exactly the same value on every invocaton. This primarily causes issues when switching to another fiber from a thread that is different from the thread on which the fiber was last executed. Theoretically, however, this may also cause issues when the optimizer aliases the "teb" variable to another variable that is shared between threads, and perform global optimization that can work across multiple threads in runtime (if any). Fix this by adding the "memory" clobber to the asm statements that computes the current TEB address. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2434

4 9

[PATCH 0/1] MR2457: dinput/tests: Flush messages after creating the test_mouse_keyboard window.
by Rémi Bernon 21 Mar '23

21 Mar '23

Preventing spurious failures on some Windows 7 VMs. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54713 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2457

1 1

Re: [PATCH v2 0/1] MR2429: msvcrt100: Add stub implementation for _UnrealizedChore::CheckTaskCollection
by Piotr Caban (＠piotr) 21 Mar '23

21 Mar '23

Piotr Caban (@piotr) commented about dlls/concrt140/concrt140.spec: > @ stub -arch=arm ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QAAXXZ > @ stub -arch=i386 ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QAEXXZ > @ stub -arch=win64 ?_Cancel(a)_TaskCollection@details(a)Concurrency@@QEAAXXZ > -@ stub -arch=arm ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAAXXZ > -@ stub -arch=i386 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAEXXZ > -@ stub -arch=win64 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IEAAXXZ > +@ cdecl -arch=arm ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAAXXZ() UnrealizedChore_CheckTaskCollection > +@ cdecl -arch=i386 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IAEXXZ() UnrealizedChore_CheckTaskCollection > +@ cdecl -arch=win64 ?_CheckTaskCollection(a)_UnrealizedChore@details(a)Concurrency@@IEAAXXZ() UnrealizedChore_CheckTaskCollection The function uses `thiscall` calling convention. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2429#note_27393

1 0

[PATCH 0/2] MR2454: imm32/tests: Fix some test failures on Windows with Korean locale.
by Rémi Bernon 21 Mar '23

21 Mar '23

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54710 Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54711 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2454

1 2

[PATCH 0/5] MR2453: dinput: Always create device object properties.
by Rémi Bernon 21 Mar '23

21 Mar '23

In preparation to keep action map app data in there, for `SetActionMap`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2453

1 5

[PATCH 0/2] MR2450: wldap32: Handle null DN or null message in ldap_add* and ldap_modify* and add tests.
by Alex Henrie (＠alexhenrie) 21 Mar '23

21 Mar '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54702 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2450

3 3

[PATCH 0/1] MR2451: include: Add IDirectManipulationInteractionEventHandler declaration in directmanipulation.idl.
by Biswapriyo Nath (＠Biswa96) 21 Mar '23

21 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2451

2 1

[PATCH v2 0/3] MR2449: win32u: Add a few device GPU properties.
by Paul Gofman (＠gofman) 20 Mar '23

20 Mar '23

Diablo IV (closed beta) depends on DEVPKEY_Device_MatchingDeviceId being present for GPUs (once it is able to match GPU luid to the one obtained from dxgi). It also depends on the MatchingDeviceId conating "ven_" and "dev_" substrings. Without those it doesn't consider the gpu as valid, which currently results in the game complaining about no GPUs found. I guess that maybe it is trying to filter out software GPUs and such this way. As far as my testing goes, DEVPKEY_Device_MatchingDeviceId has this form with hardware GPUs only and maybe with the recent enough Win10 or Win11. The other two device properties being added are also queried by the game although they are not strictly needed for it. -- v2: win32u: Set DEVPKEY_Device_RemovalPolicy for GPUs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2449

3 5

[PATCH 0/3] MR2449: win32u: Add a few device GPU properties.
by Paul Gofman (＠gofman) 20 Mar '23

20 Mar '23

Diablo IV (closed beta) depends on DEVPKEY_Device_MatchingDeviceId being present for GPUs (once it is able to match GPU luid to the one obtained from dxgi). It also depends on the MatchingDeviceId conating "ven_" and "dev_" substrings. Without those it doesn't consider the gpu as valid, which currently results in the game complaining about no GPUs found. I guess that maybe it is trying to filter out software GPUs and such this way. As far as my testing goes, DEVPKEY_Device_MatchingDeviceId has this form with hardware GPUs only and maybe with the recent enough Win10 or Win11. The other two device properties being added are also queried by the game although they are not strictly needed for it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2449

4 5

Re: [PATCH v3 0/1] MR2443: include: Annotate LDAP allocation functions with __WINE_(DEALLOC|MALLOC). - approved
by Alexandre Julliard (＠julliard) 20 Mar '23

20 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2443

1 0