March 2023 - Wine-gitlab - list.winehq.org

[PATCH 0/5] MR2445: kernelbase: Some more open_key() and create_key() refactoring.
by Sven Baars (＠sbaars) 20 Mar '23

20 Mar '23

There is one more patch series of refactoring create_key() after this one, then I can start implementing things. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2445

3 6

[PATCH 0/1] MR2446: mscoree/tests: Avoid temporary directory name collisions.
by Francois Gouget (＠fgouget) 20 Mar '23

20 Mar '23

test_loadpaths_execute() was sometimes getting ERROR_ALREADY_EXISTS when creating its temporary directoryi. That was probably because GetTempFileNameW() only uses the low 16-bits of the 'random' LUID which goes over a wider range, potentially leading to collisions in the lower 16-bits. Avoid AllocateLocallyUniqueId() entirely and add a helper function to create a guaranteed new directory. Also try to use the current directory first as it is assumed to have been configured to ward off anti-virus programs (specifically Microsoft Defender) which is especially important when writing executables to that location. Only switch to the system's temporary directory if the current directory is not a writable location. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54560 --- There are a few other tests where I suspect occasional anti-virus interference. It may make sense to reuse this function in those. That said create_new_dir() uses entirely predictable sequenitial numbers which would be bad if attempting to create a secure directory. But the new directory does not even have special permissions and this type of attack shouldn't be an issue for the tests. Still, don't reuse this code in contexts where security matters. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2446

3 2

[PATCH 0/2] MR2443: include: Fix constness of arguments to LDAP functions and annotate with __WINE_(DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 20 Mar '23

20 Mar '23

I need the header to be correct before I start writing tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2443

4 5

[PATCH 0/5] MR2447: dinput: Fix IDirectInputDevice8_BuildActionFormat.
by Rémi Bernon 20 Mar '23

20 Mar '23

And begin some refactoring for `SetActionFormat`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2447

1 5

[PATCH 0/2] MR2436: d3dcompiler: Always initialize output shader blob pointer in D3DCompile2().
by Nikolay Sivov (＠nsivov) 20 Mar '23

20 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2436

3 3

[PATCH 0/5] MR2444: widl: More lexer simplification.
by Rémi Bernon 20 Mar '23

20 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2444

2 6

[PATCH 0/4] MR2437: d3d10/effect: Add support for a few more instructions in preshaders
by Nikolay Sivov (＠nsivov) 20 Mar '23

20 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2437

3 6

[PATCH 0/2] MR2433: ntdll: Open application manifest files with FILE_SHARE_DELETE.
by Jinoh Kang (＠iamahuman) 20 Mar '23

20 Mar '23

Today, RtlCreateActivationContext (CreateActCtxW) opens the source manifest file via NtOpenFile without the FILE_SHARE_DELETE sharing mode. This causes CreateActCtxW to fail if the source manifest file was created with the FILE_DELETE_ON_CLOSE flag. FILE_DELETE_ON_CLOSE is often used for temporary files that should be automatically deleted after use, even if the creator process crashes. Fix this by specifying FILE_SHARE_DELETE for sharing mode when opening the source manifest or module file. This allows the source manifest or module file to be marked as deleted while it is open. Note that concurrent deletion is not an issue for the following reasons: - The ability to read from an open file handle is unaffected by deletion of the corresponding file's name. - RtlCreateActivationContext does not open the source manifest or module file by the given filename (lpSource) more than once. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2433

4 4

[PATCH v2 0/1] MR129: tests: Read integer uniforms with strtol() and strtoul().
by Giovanni Mascellani (＠giomasce) 20 Mar '23

20 Mar '23

Because %i sscanf() converters are deprecated, and in practice clamp to [-2^31, 2^31) on 32 bit. -- v2: tests: Read integer uniforms with strtol() and strtoul(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/129

3 2

[PATCH v2 0/1] MR127: vkd3d: Add an internal reference to a heap when a resource is placed there.
by Conor McCarthy (＠cmccarthy) 20 Mar '23

20 Mar '23

Fixes a crash on exit in Horizon Zero Dawn (with SM 6.0 support added). The docs state it is required: https://learn.microsoft.com/en-us/windows/win32/api/d3d12/nf-d3d12-id3d12de… -- v2: vkd3d: Add an internal reference to a heap when a resource is placed there. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/127

4 4