April 2023 - Wine-gitlab - list.winehq.org

[PATCH v10 0/2] MR566: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) 24 Apr '23

24 Apr '23

Called by IE11. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> v4: Don't reimplement SHBindToParent. -- v10: shell32/tests: Add SHBindToFolderIDListParent tests. shell32: Implement SHBindToFolderIDListParent. https://gitlab.winehq.org/wine/wine/-/merge_requests/566

4 3

[PATCH 0/1] MR2696: ntdll: Avoid integer overflow in block_get_subheap().
by Paul Gofman (＠gofman) 24 Apr '23

24 Apr '23

'block->base_offset * REGION_ALIGN' overflows once WORD base_offset value reaches 0x8000, so block_get_subheap() returns wrong address. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2696

3 2

[PATCH 0/1] MR2686: ntdll: Mind LFH pending blocks in RtlDestroyHeap().
by Paul Gofman (＠gofman) 24 Apr '23

24 Apr '23

Pending block may be LFH block and freeing it with heap_free_block() crashes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2686

3 2

[PATCH 0/1] MR2697: winhttp: Support WINHTTP_OPTION_PARENT_HANDLE in request_query_option().
by Vova Mshanetskiy (＠vovams) 24 Apr '23

24 Apr '23

This is needed for mod.io integration in game "The Entropy Centre". Without support for this option the game hangs when trying to authenticate. Please note that i do not know how Wine works, and have very little understanding of what i am doing. I copied and adjusted code from `connect_query_option()` in the same file. The game does work with this patch though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2697

3 2

Re: [PATCH v6 0/1] MR2609: shlwapi: Implement StrFormatByteSizeEx
by David Kahurani (＠kahurani) 24 Apr '23

24 Apr '23

Hi, It looks like this has stalled. @nsivov Are you okay with this? I made changes to address your comment, just in case you have not looked at them already. @julliard It doesn't look like there's a designated reviewer on this front. Any suggestions on changes I could possibly make to improve the chances of this getting merged? It looks like there's an application using it and more importantly, it looks like someone might be in need of this... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2609#note_30976

1 0

[PATCH v2 0/1] MR1950: widl: Initialize __frame to a default value (Coverity)
by Alistair Leslie-Hughes (＠alesliehughes) 24 Apr '23

24 Apr '23

In the generate code, Converity is reporting __frame->code unitilized in the failed case. When we initialize the object, then __f will also point to a fully initizliaed structure. -- v2: widl: Suppress a coverity warning https://gitlab.winehq.org/wine/wine/-/merge_requests/1950

4 4

[PATCH v4 0/4] MR2688: tasklist: Add basic functionality.
by Zhiyi Zhang (＠zhiyi) 23 Apr '23

23 Apr '23

Company of Heroes: Battle of Crete needs a functioning tasklist.exe to exit properly. -- v4: tasklist: Partially support '/fi' option. tasklist: Support '/fo' option. tasklist: Support '/nh' option. tasklist: Add basic functionality. https://gitlab.winehq.org/wine/wine/-/merge_requests/2688

3 5

Re: [PATCH v5 0/1] MR2413: comctl32: Fix the problem that listview cannot display all files.
by Nikolay Sivov (＠nsivov) 22 Apr '23

22 Apr '23

On Fri Mar 24 02:49:18 2023 +0000, Zhao Yi wrote: > I have just updated my commit message and you can review it again. Again, MR description is what it should look like. What you have for commit message duplicates code changes. New paragraph in commit message mixes together unrelated things - it's talking about shellview case it seems, which is not something Listview is directly related to. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2413#note_30948

1 0

[PATCH v5 0/2] MR2618: ntdll: Increment offset by len in build_clr_surrogate_section.
by Alex Henrie (＠alexhenrie) 22 Apr '23

22 Apr '23

Instead of multiplying it by 2. I don't know how this ever worked. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54808 -- v5: ntdll: Increment offset by len in build_clr_surrogate_section. kernel32/tests: Check that lpSectionBase != NULL before dereferencing. https://gitlab.winehq.org/wine/wine/-/merge_requests/2618

4 5

[PATCH v9 0/1] MR135: vkd3d-shader/hlsl: Add support for sample index argument in Load().
by Nikolay Sivov (＠nsivov) 22 Apr '23

22 Apr '23

-- v9: vkd3d-shader/hlsl: Add support for sample index argument in Load(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/135

2 1