June 2023 - Wine-gitlab - list.winehq.org

[PATCH v2 0/5] MR250: vkd3d-shader/hlsl: Declare vars individually when parsing declarations.
by Francisco Casas (＠fcasas) 29 Jun '23

29 Jun '23

In a declaration with multiple variables, the variables must be created before the initializer of the next variable is parsed. This is required for initializers such as: ``` float a = 1, b = a, c = b + 1; ``` The solution is to parse the type information in the same rule as the first variable ('a' in this case) so that it can be declared before the parser reaches the initializer for the following variables. To initialize the following variables, the type information is passed along from the first variable's struct parse_variable_def to the next and so on. --- Solves https://bugs.winehq.org/show_bug.cgi?id=54484, pointed out by @nsivov. -- v2: vkd3d-shader/hlsl: Declare vars individually when parsing struct declarations. vkd3d-shader/hlsl: Declare vars individually when parsing regular declarations. vkd3d-shader/hlsl: Split declare_vars(). tests: Test multiple variable initializers. tests: Test semantics in uniform variables. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/250

4 9

[PATCH 0/2] MR3195: oleaut32: OaBuildVersion - Fix return for available windows versions
by Alistair Leslie-Hughes (＠alesliehughes) 29 Jun '23

29 Jun '23

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=54257 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3195

2 2

Re: [PATCH v2 0/1] MR3187: winemac.drv: Give Apple GPUs device IDs
by Huw Davies (＠huw) 29 Jun '23

29 Jun '23

This is also producing a build failiure on macOS 10.14 ``` gcc -m32 -c -o dlls/winemac.drv/cocoa_display.o dlls/winemac.drv/cocoa_display.m -Idlls/winemac.drv -Iinclude -D__WINESRC__ \ -DWINE_UNIX_LIB -Wall -pipe -fno-stack-protector -fno-strict-aliasing \ -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Winit-self -Wno-pragma-pack \ -Wstrict-prototypes -Wtype-limits -Wvla -Wwrite-strings -Wpointer-arith -gdwarf-4 -fPIC \ -fasynchronous-unwind-tables -O2 -g -Wno-deprecated-declarations -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 dlls/winemac.drv/cocoa_display.m:273:94: warning: instance method '-supportsFamily:' not found (return type defaults to 'id') [-Wobjc-method-access] if (!gpu->device_id && [device respondsToSelector:@selector(supportsFamily:)] && [device supportsFamily:MTLGPUFamilyApple1]) ^~~~~~~~~~~~~~ dlls/winemac.drv/cocoa_display.m:273:109: error: use of undeclared identifier 'MTLGPUFamilyApple1' if (!gpu->device_id && [device respondsToSelector:@selector(supportsFamily:)] && [device supportsFamily:MTLGPUFamilyApple1]) ^ dlls/winemac.drv/cocoa_display.m:275:9: error: use of undeclared identifier 'MTLGPUFamily' MTLGPUFamily highest = MTLGPUFamilyApple1; ^ dlls/winemac.drv/cocoa_display.m:279:13: error: use of undeclared identifier 'MTLGPUFamily' MTLGPUFamily next = highest + 1; ^ dlls/winemac.drv/cocoa_display.m:280:25: warning: instance method '-supportsFamily:' not found (return type defaults to 'id') [-Wobjc-method-access] if ([device supportsFamily:next]) ^~~~~~~~~~~~~~ dlls/winemac.drv/cocoa_display.m:280:40: error: use of undeclared identifier 'next' if ([device supportsFamily:next]) ^ dlls/winemac.drv/cocoa_display.m:281:17: error: use of undeclared identifier 'highest' highest = next; ^ dlls/winemac.drv/cocoa_display.m:281:27: error: use of undeclared identifier 'next' highest = next; ^ dlls/winemac.drv/cocoa_display.m:285:26: error: use of undeclared identifier 'highest'; did you mean 'sigset'? gpu->device_id = highest; ^~~~~~~ sigset /usr/include/signal.h:99:22: note: 'sigset' declared here void (* _Nullable sigset(int, void (* _Nullable)(int)))(int); ^ dlls/winemac.drv/cocoa_display.m:285:24: warning: incompatible pointer to integer conversion assigning to 'uint32_t' (aka 'unsigned int') from 'void (* _Nullable (int, void (* _Nullable)(int)))(int)' [-Wint-conversion] gpu->device_id = highest; ^ ~~~~~~~ ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3187#note_37303

1 0

[PATCH 0/1] MR3194: explorer: Fix command-line parameter parsing.
by Rémi Bernon 29 Jun '23

29 Jun '23

Fixes: 5b11157ecf787e545062000ab6afd1c55ee8dacc Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55141 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3194

1 1

[PATCH v2 0/3] MR251: vkd3d: Fix a few resource leaks here and there
by Giovanni Mascellani (＠giomasce) 29 Jun '23

29 Jun '23

-- v2: vkd3d: Release op data when destroying the queue. vkd3d: Always emit an error when failing to reserve for the op array. vkd3d: Release the op mutex on allocation failure. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/251

2 3

[PATCH v2 0/4] MR2822: wined3d: Recreate swapchain textures in wined3d_swapchain_resize_buffers().
by Zebediah Figura (＠zfigura) 29 Jun '23

29 Jun '23

-- v2: wined3d: Remove no longer used arguments from wined3d_texture_update_desc(). wined3d: Recreate swapchain textures in wined3d_swapchain_resize_buffers(). wined3d: Factor out a swapchain_create_texture() helper. dxgi: Do not create a d3d11 swapchain object for the implicit swapchain. https://gitlab.winehq.org/wine/wine/-/merge_requests/2822

3 5

[PATCH 0/5] MR3192: winegstreamer: More media source creation cleanup.
by Rémi Bernon 29 Jun '23

29 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3192

1 5

[PATCH v2 0/5] MR3162: Chromium sandbox fixes
by Zhiyi Zhang (＠zhiyi) 29 Jun '23

29 Jun '23

This series of patches enable Adobe PDF Reader 11 protected mode, which is essentially a Chromium sandbox, to work properly. -- v2: server: Allow creating a real explorer desktop window for invisible window stations. user32/tests: Test that an actual desktop window should be created on invisible window stations. win32u: Use the window station name to check if an application is running as a service. user32/tests: Test monitor information with an invisible window station. win32u: Create explorer with the thread effective access token. https://gitlab.winehq.org/wine/wine/-/merge_requests/3162

2 5

Re: [PATCH v2 0/1] MR3187: winemac.drv: Give Apple GPUs device IDs
by Chip Davis (＠cdavis5e) 29 Jun '23

29 Jun '23

Ah, dammit, I wish I had caught this sooner. MoltenVK has its own scheme for assigning a PCI device ID to the AGX GPUs. I wonder if it wouldn't be worth attempting to emulate that in case apps try to match the ID from Vulkan to this one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3187#note_37247

1 0

[PATCH v5 0/6] MR3007: Draft: ntdll: Avoid requests with null pointer but invalid size.
by Bernhard Übelacker 29 Jun '23

29 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51770 - v1: - https://www.winehq.org/pipermail/wine-devel/2021-December/202913.html - https://www.winehq.org/pipermail/wine-devel/2022-April/213866.html (resend) - v2: - https://www.winehq.org/pipermail/wine-devel/2022-April/214306.html - Validate pointer before calling wine_server_add_data. - v3: (d4a7440a) - https://www.winehq.org/pipermail/wine-devel/2022-May/218285.html - Move check to DeviceIoControl. - Always use fixed values for IOCTL_STORAGE_GET_DEVICE_NUMBER. - Remove warning at expected hang. - v4: (6a69c680) - Fix typo in commit message. - Modified format strings. - v5: (47784feb) - Move test to own test function. - Move check to wine_server_add_data. - v6: (8c641d09) - Move check to NtDeviceIoControlFile - Add (at least temporary) tests to compare with NtDeviceIoControlFile and NtFsControlFile. -- v5: kernel32/tests: Add test for IOCTL_STORAGE_GET_DEVICE_NUMBER. ntdll: Add validation for input and output buffers in NtDeviceIoControlFile. ntoskrnl.exe: Allow sending a null input buffer to the driver. ntoskrnl.exe: Add todo_wine_if to test_ioctl_buffers. ntoskrnl.exe: Remove buffer assignments in test_ioctl_buffers. ntoskrnl.exe: Add test_ioctl_buffers by Zebediah Figura. https://gitlab.winehq.org/wine/wine/-/merge_requests/3007

3 9