June 2023 - Wine-gitlab - list.winehq.org

Re: [PATCH v4 0/1] MR3182: include: Fix spelling error when define InterlockedDecrementSizeT(). - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3182

1 0

Re: [PATCH v2 0/1] MR52: configure: Allow linking against static SPIRV-Tools. - closed
by Zebediah Figura (＠zfigura) 28 Jun '23

28 Jun '23

This merge request was closed by Zebediah Figura. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/52

1 0

Re: [PATCH v2 0/1] MR52: configure: Allow linking against static SPIRV-Tools.
by Zebediah Figura (＠zfigura) 28 Jun '23

28 Jun '23

I hate Markdown. Again. Here's the error, in readable form: ``` elizabeth(a)ledyba:~/git/vkd3d64$ make make all-am make[1]: Entering directory '/home/elizabeth/git/vkd3d64' CCLD vkd3d-compiler /usr/bin/ld: warning: libSPIRV-Tools-shared.so, needed by ./.libs/libvkd3d-shader.so, not found (try using -rpath or -rpath-link) /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvContextCreate' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvContextDestroy' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvTextDestroy' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvDiagnosticDestroy' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvBinaryToText' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvValidateBinary' collect2: error: ld returned 1 exit status make[1]: *** [Makefile:1510: vkd3d-compiler] Error 1 make[1]: Leaving directory '/home/elizabeth/git/vkd3d64' make: *** [Makefile:1157: all] Error 2 ``` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/52#note_37198

1 0

Re: [PATCH v2 0/1] MR52: configure: Allow linking against static SPIRV-Tools.
by Zebediah Figura (＠zfigura) 28 Jun '23

28 Jun '23

> > Shared SPIRV-Tools is not shipped by Debian Bullseye, and is broken if built manually. > > Is that a regression? I'm using a build of shared SPIRV-Tools I made myself, and it seems to work fine, although it's an older (v2019.5) version. Okay, I think I remember / have reproduced the problem I was encountering. If I build spirv-tools with a prefix that doesn't put it in $PATH, and then try to build vkd3d, I get this: elizabeth(a)ledyba:~/git/vkd3d64$ make make all-am make[1]: Entering directory '/home/elizabeth/git/vkd3d64' CCLD vkd3d-compiler /usr/bin/ld: warning: libSPIRV-Tools-shared.so, needed by ./.libs/libvkd3d-shader.so, not found (try using -rpath or -rpath-link) /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvContextCreate' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvContextDestroy' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvTextDestroy' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvDiagnosticDestroy' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvBinaryToText' /usr/bin/ld: ./.libs/libvkd3d-shader.so: undefined reference to `spvValidateBinary' collect2: error: ld returned 1 exit status make[1]: *** [Makefile:1510: vkd3d-compiler] Error 1 make[1]: Leaving directory '/home/elizabeth/git/vkd3d64' make: *** [Makefile:1157: all] Error 2 I don't really understand linking enough to know whose fault this is, although I suspect it's the fault of spirv-tools, which is generally just a mess. Either way I don't think this patch is the right thing to do, so I'm going to close this. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/52#note_37197

1 0

Re: [PATCH v3 0/1] MR217: include: Use WIN32_LEAN_AND_MEAN to exlude non-required headers - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/217

1 0

Re: [PATCH v7 0/1] MR125: vkd3d: Print the thread id in trace messages. - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/125

1 0

Re: [PATCH v18 0/5] MR44: vkd3d-shader/dxil: Read and validate DXIL bitcode blocks. - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/44

1 0

Re: [PATCH v3 0/1] MR248: tests: Move HLSL tests to a subdirectory. - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/248

1 0

Re: [PATCH v3 0/1] MR233: vkd3d-shader: Unify static string arrays initialization pattern. - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/233

1 0

Re: [PATCH v6 0/5] MR230: hlsl: Replace bare list pointers with hlsl_block, part 1. - approved
by Alexandre Julliard (＠julliard) 28 Jun '23

28 Jun '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/230

1 0