July 2023 - Wine-gitlab - list.winehq.org

[PATCH v4 0/7] MR3328: sapi: Partially implement ISpVoice::Speak.
by Shaun Ren (＠shaunren) 19 Jul '23

19 Jul '23

-- v4: sapi: Introduce ISpTTSEngineSite stub. sapi: Implement synchronous ISpVoice::Speak. sapi: Partially implement ISpVoice::Speak SPF_ASYNC. sapi: Implement ISpVoice::Speak SPF_PURGEBEFORESPEAK. sapi: Reset empty event after queuing a task in async_queue_task. sapi: Handle queue not initialized in async_empty_queue. https://gitlab.winehq.org/wine/wine/-/merge_requests/3328

2 7

[PATCH v2 0/2] MR2853: win32u: Implement EVENT_SYSTEM_FOREGROUND
by Esme Povirk (＠madewokherd) 19 Jul '23

19 Jul '23

I expect this is going to be tricky to get in. I ran into the following issues: * test_ShowWindow behaves very strangely on Windows. It seems this isn't typical behavior, and is caused by an interaction with test_SetFocus, but I'm not sure exactly what it does to the thread state that causes this. * Many of the SetWindowPos flag combinations tested don't actually show the window on Windows, therefore they don't send EVENT_SYSTEM_FOREGROUND. I was able to reproduce this with a stand-alone test, so it seems to be normal behavior. * Windows can show a window without activating it, and Wine on X11 can't do that reliably for managed windows. * There are a couple of cases where Windows sends an event and Wine doesn't. I figure it's OK to not cover every case, but I can go back and investigate those if needed. This interacts with https://gitlab.winehq.org/wine/wine/-/merge_requests/2314, in that the tests don't really test much without it. I applied that MR for my own testing. -- v2: win32u: Implement EVENT_SYSTEM_FOREGROUND. user32: Run tests that notice focus changes early. https://gitlab.winehq.org/wine/wine/-/merge_requests/2853

3 11

[PATCH v3 0/4] MR3339: server: Cancel asyncs when the last handle in process is closed.
by Paul Gofman (＠gofman) 19 Jul '23

19 Jul '23

Supersedes !3329. -- v3: server: Cancel pipe asyncs when the last handle in process is closed. server: Cancel socket asyncs when the last handle in process is closed. ws2_32/tests: Add test for async cancel on socket's last process handle close. ntdll/tests: Add test for async cancel on pipe's last process handle close. https://gitlab.winehq.org/wine/wine/-/merge_requests/3339

2 5

[PATCH v2 0/4] MR260: vkd3d: Prepare for buffering of command list commands.
by Conor McCarthy (＠cmccarthy) 19 Jul '23

19 Jul '23

-- v2: vkd3d: Add a pending execution count to struct d3d12_command_signature. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/260

3 6

Re: [PATCH v4 0/75] MR3168: Release 8.0.2. - approved
by Alexandre Julliard (＠julliard) 19 Jul '23

19 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3168

1 0

[PATCH v2 0/2] MR3351: mfmediaengine: Implement RemoveAllEffects().
by Bernhard Kölbl 19 Jul '23

19 Jul '23

-- v2: mfmediaengine: Implement RemoveAllEffects(). mfmediaengine/tests: Add tests for RemoveAllEffects(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3351

3 8

[PATCH 0/1] MR3354: mshtml: Grab the binding while aborting it.
by Gabriel Ivăncescu 19 Jul '23

19 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3354

2 2

[PATCH 0/1] MR3356: riched20/tests: Make the editor paste test failures more informative and unique.
by Francois Gouget (＠fgouget) 19 Jul '23

19 Jul '23

Knowing the content of the edit field is more useful than knowing the strcmp() result. The text field may contain carriage returns and linefeeds so use wine_dbgstr_a() so they are clearly visible in the failure message. Also prefix the ok messages with a unique string to indicate which test_WM_PASTE() test failed. --- The old failure messages all look the same so one has to refer to the line number to know which test actually failed which is pretty tiresome. Thisis even more so when checking old reports on test.winehq.org or TestBot job results. It also prevents the TestBot from correctly identifying failure modes (i.e. all test_WM_PASTE() failures looked the same to it). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3356

3 2

[PATCH v2 0/1] MR2811: msvcrt/tests: Document why skip() is used for some missing APIs.
by Francois Gouget (＠fgouget) 19 Jul '23

19 Jul '23

Windows only provides the 32-bit API and using todo_wine win_skip() in the 64-bit case would imply Wine needs fixing. So it's simpler to use a plain skip(). Other schemes like picking between skip() and win_skip() based on bitness feel like they would be way overkill. -- v2: msvcrt/tests: Check that some functions are only available in 32-bit code. https://gitlab.winehq.org/wine/wine/-/merge_requests/2811

3 3

[PATCH v3 0/2] MR2809: user32/tests: Use win_skip() for missing APIs.
by Francois Gouget (＠fgouget) 19 Jul '23

19 Jul '23

A missing API is a todo in Wine. -- v3: uxtheme/tests: Use win_skip() for missing APIs. user32/tests: Use win_skip() for missing APIs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2809

3 4