July 2023 - Wine-gitlab - list.winehq.org

[PATCH 0/4] MR260: vkd3d: Prepare for buffering of command list commands.
by Conor McCarthy (＠cmccarthy) 18 Jul '23

18 Jul '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/260

4 8

Re: [PATCH v4 0/1] MR3353: Make Notepad properly get the DPI value.
by Jeffrey Smith (＠whydoubt) 18 Jul '23

18 Jul '23

On Tue Jul 18 18:38:06 2023 +0000, Brendan Shanks wrote: > Also, the commit title should start with `notepad:`, something like > `notepad: Use GetDpiForWindow()`. While changing the commit title, it might be worth-while to pare down the rest of the commit message. Specifically, while the last paragraph is relevant to the MR, I don't think it will serve any lasting value in the commit history. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3353#note_39330

1 0

Re: [PATCH v4 0/1] MR3353: Make Notepad properly get the DPI value.
by Brendan Shanks (＠bshanks) 18 Jul '23

18 Jul '23

Also, the commit title should start with `notepad:`, something like `notepad: Use GetDpiForWindow()`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3353#note_39329

1 0

Re: [PATCH v4 0/1] MR3353: Make Notepad properly get the DPI value.
by David Kahurani (＠kahurani) 18 Jul '23

18 Jul '23

With these changes, it doesn't look like `get_dpi` serves any purpose anymore. You might as well refactor it all out. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3353#note_39327

1 0

Re: [PATCH v4 0/1] MR3353: Make Notepad properly get the DPI value.
by Petrichor Park (＠petrathekat) 18 Jul '23

18 Jul '23

Sorry for all the hullabaloo; I've `git rebased` it to be under my Gitlab account now. (Previously it was inheriting my personal Github account information). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3353#note_39321

1 0

[PATCH 0/1] MR3353: Make Notepad properly get the DPI value.
by Petrichor Park (＠petrathekat) 18 Jul '23

18 Jul '23

Instead of querying the registry, just calls `GetDpiForWindow`. Winecfg's DPI slider sets `Control Panel\\Desktop\\LogPixels`. See `programs/winecfg/x11drvdlg.c` Notepad queries `Software\\Fonts\\LogPixels`, and so doesn't pick up on the change. I don't believe this changes how Notepad looks to the user, but it is necessary for a further MR I'm working on that adds more information to the status bar. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3353

4 4

[PATCH 0/2] MR3242: comctl32/tests: Add Korean IME specific test sequences.
by Zhiyi Zhang (＠zhiyi) 18 Jul '23

18 Jul '23

Windows with Korean locale has a different IME message sequence. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53890 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3242

3 3

[PATCH v6 0/1] MR3347: klist: Add a program that lists Kerberos tickets.
by Maxim Karasev (＠mxkrsv) 18 Jul '23

18 Jul '23

It's a clean-room reimplementation that mimics Windows 10 program's output format. It prints all the information that is available via KerbQueryTicketCacheMessage. Also tested to work on Windows if dynamically linked + built with winegcc. For further extension of the functonality, implementing KerbQueryTicketCacheEx{,2,3}Message is required. -- v6: klist: Add a program that lists Kerberos tickets. https://gitlab.winehq.org/wine/wine/-/merge_requests/3347

4 10

[PATCH v4 0/2] MR271: Introduce a GitLab pipeline for vkd3d
by Giovanni Mascellani (＠giomasce) 18 Jul '23

18 Jul '23

With this pipeline vkd3d automatically gets built on Linux (in an image based on Debian unstable), both in 32 and 64 bit mode. Both builds are tested with radv and llvmpipe. A number of caveats apply, though: * A number of tests currently fail in llvmpipe, so the llvmpipe jobs are marked as allowed to fail. Ideally we'll eventually fix our bugs and mark the llvmpipe ones in the tests, so that the CI tests completely pass and possible problems in the Vulkan driver are recorded at a better granularity (this is the reason why GitLab says that the pipeline is passed with warnings: the warnings are that there are jobs that failed, even if they were allowed to fail). * ~~The runners provided by the GitLab instance don't have a GPU available, so I configured my own computer (equipped with an AMD Radeon RX 5700 RX) to provide a runner with access to the GPU. This setup is not currently satisfying: for me, because I use that computer for other things and I don't like having random code submitted to it (it is theoretically sandboxed, but sandboxes are not always bullet-proof, especially if they have access to a GPU); for the users, because my computer might be unavailable at any time. I'll work on a better solution. For the time being I intend the runner to only accept jobs from the master branch; once a better solution is implemented I'd like to run the pipeline for MRs too.~~ **Fixed**, now there is a shared worker with an AMD GPU available. * While the `Dockerfile` and related assets do not necessarily need to be available in this repository, given that the CI accesses the binary image from the Docker hub anyway, I think it's still valuable to have them, so others can improve them (and for sure improvement opportunities are nowhere near missing). However, other ways to make them available can be found, if for some reason it is not liked to have them in this repository (they are not pretty!). * ~~One of the reason they are not pretty is that I have a custom hack to compile `widl` from the Wine sources without compiling (or installing from the distribution) the whole of Wine, in the interest of keeping the Docker image small (well, small-ish: Vulkan drivers, compilers and X libraries are not small anyway).~~ **A better solution was implemented** * Again on the subject of the Docker image, I am currently putting the binary image in my own namespace on the Docker hub. Using the GitLab container registry in the namespace of the Wine project would probably be better, so that I am not a bottleneck in the future. * ~~Even if we discount all the points above, this MR cannot be merged yet, because my runner is currently configured for my namespace only. I guess I need the intervention of a GitLab admin to fix that. However, I think there's already material enough for valuable feedback.~~ **Fixed too** -- v4: ci: Introduce a CI pipeline for GitLab. configure: Require widl >= 3.21. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/271

2 2

[PATCH v3 0/9] MR3300: jscript: WeakMap implementation.
by Gabriel Ivăncescu 18 Jul '23

18 Jul '23

-- v3: jscript: Properly set JS_E_WRONG_THIS as a TypeError. mshtml/tests: Add tests for WeakMap. jscript: Implement WeakMap.has(). jscript: Implement WeakMap.clear(). jscript: Implement WeakMap.delete(). jscript: Implement WeakMap.get(). jscript: Implement WeakMap.set(). jscript: Implement WeakMap instance stub and constructor. jscript: Convert unlink_props to a helper that unlinks the entire object. https://gitlab.winehq.org/wine/wine/-/merge_requests/3300

2 16