August 2023 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR3667: comctl32: Include HORZ_GAP in update region and invalidate if movement is verticle.
by Jacob Czekalla (＠Maaka00524) 29 Aug '23

29 Aug '23

Fixes a bug where the statusbar doesn't correctly paint when the parent window is resized. This can be seen in wine notepad. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3667

4 9

[PATCH v5 0/8] MR3245: mf/session: Test native MFT call pattern, and request more samples from upstream if necessary.
by Rémi Bernon 29 Aug '23

29 Aug '23

This is similar to https://gitlab.winehq.org/wine/wine/-/merge_requests/2684, https://gitlab.winehq.org/wine/wine/-/merge_requests/3004 or https://gitlab.winehq.org/wine/wine/-/merge_requests/3139 but it validates the session transform node behavior with tests. The tests are added after the changes because they otherwise don't pass and making them pass would be unnecessarily complicated. I also have some local tests for MF_TOPONODE_WORKQUEUE_ID attributes and how it is supposed to behave. It basically creates new serialized work queues for every source node and assign them to every node downstream. Any sample request or processing operation is done in the associated queue. When joining streams, queues are assigned downstream one after another and the last assigned queue is used when requesting samples upstream, but when samples are received and processed downstream it looks like the current queue of the source node is used for every downstream operations. The request behavior seems to be the same when work queues are used, with round robin input requests, and single ProcessInput call followed by ProcessOutput loop until it fails. This is yet not optimally efficient, and could be improved, for the following reasons: 1) All session operations are serialized together, even unrelated streams, and ProcessInput / ProcessOutput calls may be costly and stalling the pipeline. I believe that native probably allows parallel processing of unrelated stream requests, this needs to be confirmed. 2) MFT_MESSAGE_COMMAND_DRAIN message use isn't ideal, the message forces the transform to process all queued input synchronously, which can take a long time. I haven't checked exactly what native does but I believe it instead uses MFT_MESSAGE_NOTIFY_END_OF_STREAM messages, which would allow us to notify and drain the GStreamer decoder asynchronously. 3) MFT_MESSAGE_COMMAND_DRAIN also doesn't distinguish between input streams and needs to be sent globally. It's unclear how it should be used when multiple input streams are involved, and when one stream ends its segment then start a new segment while other streams don't have yet reached EOS. MFT_MESSAGE_NOTIFY_END_OF_STREAM messages have a stream ID parameter and would be more appropriate to handle separate input streams independently. -- v5: mf/session: Increase the request count when requests are already queued. mf/session: Request more samples from upstream when necessary. mf/session: Push transform input samples directly to ProcessInput. mf/session: Use helpers to push and pop samples for transform streams. mf/session: Drain remaining requests in transform_node_deliver_samples. mf/session: Drain transform node input streams individually. mf/session: Use a helper to deliver transform node requested samples. mf/session: Use local variables to access transform node streams. https://gitlab.winehq.org/wine/wine/-/merge_requests/3245

2 11

Re: [PATCH v2 0/5] MR3664: msvcr110: Add _Cancellation_beacon class implementation.
by Piotr Caban (＠piotr) 29 Aug '23

29 Aug '23

On Tue Aug 29 12:04:33 2023 +0000, Nikolay Sivov wrote: > One way would be to build some test against msvcr110, and see what > happens with the destructor. You don't need a game for that. It's unlikely that there's both inline destructor and export. Our Context/ExternalContextBase layout is not compatible with native (and _Cancellation_beacon ctor/dtor modifies it). So if there is inline version of the destructor it will not work. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3664#note_43676

1 0

Re: [PATCH v2 0/5] MR3664: msvcr110: Add _Cancellation_beacon class implementation.
by Nikolay Sivov (＠nsivov) 29 Aug '23

29 Aug '23

One way would be to build some test against msvcr110, and see what happens with the destructor. You don't need a game for that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3664#note_43675

1 0

Re: [PATCH v2 0/5] MR3664: msvcr110: Add _Cancellation_beacon class implementation.
by Torge Matthies (＠tmatthies) 29 Aug '23

29 Aug '23

I hope this is compatible with the destructor and whatever other functions may be compiled into the game. When I investigated cm3 the destructor call never showed up in logs. But maybe I'm blind, or maybe the game deliberately never calls the destructor. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3664#note_43671

1 0

[PATCH 0/1] MR3658: mmdevapi: Simplify load_driver_devices() by combining loops and removing unneeded allocation(s).
by Davide Beatrici (＠davidebeatrici) 29 Aug '23

29 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3658

3 2

[PATCH v2 0/1] MR3648: server: Set the default thread exit code to 1.
by Brendan Shanks (＠bshanks) 29 Aug '23

29 Aug '23

The default exit code is only used when a process is killed by the system or through a signal. These are exceptional cases where exit code 1 (killed by Task Manager) is more appropriate than the normal termination code of 0. Chromium does not restart helper processes that exit with code 0 (see [kill.h](https://source.chromium.org/chromium/chromium/src/+/main:base/proce…) with this fix they are restarted when killed by the system or by a signal. -- v2: server: Set the default thread exit code to 1. https://gitlab.winehq.org/wine/wine/-/merge_requests/3648

4 5

[PATCH v2 0/1] MR314: vkd3d-shader/hlsl: Add texCUBE() function.
by Nikolay Sivov (＠nsivov) 29 Aug '23

29 Aug '23

Included test is only to verify that function compiles, and is simple enough - using either texld or sample. -- v2: vkd3d-shader/hlsl: Add texCUBE() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/314

3 2

[PATCH v6 0/2] MR271: Introduce a GitLab pipeline for vkd3d
by Giovanni Mascellani (＠giomasce) 29 Aug '23

29 Aug '23

With this pipeline vkd3d automatically gets built on Linux (in an image based on Debian unstable), both in 32 and 64 bit mode. Both builds are tested with radv and llvmpipe. A number of caveats apply, though: * A number of tests currently fail in llvmpipe, so the llvmpipe jobs are marked as allowed to fail. Ideally we'll eventually fix our bugs and mark the llvmpipe ones in the tests, so that the CI tests completely pass and possible problems in the Vulkan driver are recorded at a better granularity (this is the reason why GitLab says that the pipeline is passed with warnings: the warnings are that there are jobs that failed, even if they were allowed to fail). * ~~The runners provided by the GitLab instance don't have a GPU available, so I configured my own computer (equipped with an AMD Radeon RX 5700 RX) to provide a runner with access to the GPU. This setup is not currently satisfying: for me, because I use that computer for other things and I don't like having random code submitted to it (it is theoretically sandboxed, but sandboxes are not always bullet-proof, especially if they have access to a GPU); for the users, because my computer might be unavailable at any time. I'll work on a better solution. For the time being I intend the runner to only accept jobs from the master branch; once a better solution is implemented I'd like to run the pipeline for MRs too.~~ **Fixed**, now there is a shared worker with an AMD GPU available. * While the `Dockerfile` and related assets do not necessarily need to be available in this repository, given that the CI accesses the binary image from the Docker hub anyway, I think it's still valuable to have them, so others can improve them (and for sure improvement opportunities are nowhere near missing). However, other ways to make them available can be found, if for some reason it is not liked to have them in this repository (they are not pretty!). * ~~One of the reason they are not pretty is that I have a custom hack to compile `widl` from the Wine sources without compiling (or installing from the distribution) the whole of Wine, in the interest of keeping the Docker image small (well, small-ish: Vulkan drivers, compilers and X libraries are not small anyway).~~ **A better solution was implemented** * ~~Again on the subject of the Docker image, I am currently putting the binary image in my own namespace on the Docker hub. Using the GitLab container registry in the namespace of the Wine project would probably be better, so that I am not a bottleneck in the future.~~ **Done** * ~~Even if we discount all the points above, this MR cannot be merged yet, because my runner is currently configured for my namespace only. I guess I need the intervention of a GitLab admin to fix that. However, I think there's already material enough for valuable feedback.~~ **Fixed too** -- v6: ci: Introduce a CI pipeline for GitLab. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/271

4 6

[PATCH 0/1] MR3612: wldap32: Report success when turning off LDAP_OPT_(ENCRYPT|ROOTDSE_CACHE|SIGN).
by Alex Henrie (＠alexhenrie) 29 Aug '23

29 Aug '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55459 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3612

3 2