August 2023 - Wine-gitlab - list.winehq.org

[PATCH v2 0/1] MR3678: mscoree/tests: Catch expected exception in loadpaths.exe.
by Esme Povirk (＠madewokherd) 29 Aug '23

29 Aug '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54202 I don't have a Windows 7 VM available to test (and I don't see them on Win11), but this should hopefully prevent the crash dialogs from popping up. -- v2: mscoree/tests: Catch expected exception in loadpaths.exe. https://gitlab.winehq.org/wine/wine/-/merge_requests/3678

2 2

[PATCH 0/1] MR3678: mscoree/tests: Catch expected exception in loadpaths.exe.
by Esme Povirk (＠madewokherd) 29 Aug '23

29 Aug '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54202 I don't have a Windows 7 VM available to test (and I don't see them on Win11), but this should hopefully prevent the crash dialogs from popping up. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3678

3 4

[PATCH 0/5] MR3643: windows.applicationmodel: Add stub DLL and packaged application execution tests.
by Rémi Bernon 29 Aug '23

29 Aug '23

This can then be used to run tests in an appx context, for instance for https://gitlab.winehq.org/wine/wine/-/merge_requests/3548 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3643

4 11

Re: [PATCH v3 0/4] MR3657: gdiplus: GdipCreateBitmapFromHICON fixes part 2/2
by Jinoh Kang (＠iamahuman) 29 Aug '23

29 Aug '23

On Tue Aug 29 15:46:15 2023 +0000, Jinoh Kang wrote: > We should have a test covering this so we know we don't have a > regression here. Specifically, the test should check if Windows indeed does *not* ignore hbmMask even if we have semitransparent icons. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3657#note_43720

1 0

Re: [PATCH v3 0/4] MR3657: gdiplus: GdipCreateBitmapFromHICON fixes part 2/2
by Jinoh Kang (＠iamahuman) 29 Aug '23

29 Aug '23

Jinoh Kang (@iamahuman) commented about dlls/gdiplus/image.c: > > - screendc = CreateCompatibleDC(0); > - GetDIBits(screendc, iinfo.hbmColor, 0, height, lockeddata.Scan0, (BITMAPINFO*)&bih, DIB_RGB_COLORS); > - > - if (bm.bmBitsPixel == 32) > + bits = heap_alloc(height * stride); > + if (!bits) > { > - has_alpha = FALSE; > - > - /* If any pixel has a non-zero alpha, ignore hbmMask */ > - src = (DWORD*)lockeddata.Scan0; > - for (y=0; y<height && !has_alpha; y++) > - for (x=0; x<width && !has_alpha; x++) > - if ((*src++ & 0xff000000) != 0) > - has_alpha = TRUE; We should have a test covering this so we know we don't have a regression here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3657#note_43719

1 0

[PATCH v8 0/6] MR283: vkd3d-shader/dxil: Implement DX instruction StoreOutput.
by Conor McCarthy (＠cmccarthy) 29 Aug '23

29 Aug '23

-- v8: vkd3d-shader/dxil: Implement DX instruction StoreOutput. vkd3d-shader/dxil: Declare shader outputs. vkd3d-shader/dxil: Implement the DXIL CALL instruction. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/283

3 17

[PATCH 0/1] MR3132: vbscript: Coerce to VT_BOOL when evaluating jump conditions.
by Nikolay Sivov (＠nsivov) 29 Aug '23

29 Aug '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3132

4 10

[PATCH v8 0/4] MR3554: mmdevapi: fixes for Yousician
by David McFarland (＠corngood) 29 Aug '23

29 Aug '23

Since Yousician's last update, it was throwing an error when initialising audio output. Unfortunately I don't have access to the old version, but they seem to have dropped win<10 support, and are using only IAudioClient3_InitializeSharedAudioStream. They also use IDeviceTopology to get the type of the first output connector. This is the bare minimum I needed to get it working. -- v8: mmdevapi: add stub for IDeviceTopology mmdevapi/tests: add test for IDeviceTopology mmdevapi: implement IAudioClient3_InitializeSharedAudioStream mmdevapi/tests: add test for AudioClient3_InitializeSharedAudioStream https://gitlab.winehq.org/wine/wine/-/merge_requests/3554

4 9

[PATCH 0/4] MR3675: dmsynth/tests: Test the synthesizer components and render some samples from MIDI.
by Rémi Bernon 29 Aug '23

29 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3675

2 6

[PATCH v7 0/2] MR271: Introduce a GitLab pipeline for vkd3d
by Giovanni Mascellani (＠giomasce) 29 Aug '23

29 Aug '23

With this pipeline vkd3d automatically gets built on Linux (in an image based on Debian unstable), both in 32 and 64 bit mode. Both builds are tested with radv and llvmpipe. A number of caveats apply, though: * A number of tests currently fail in llvmpipe, so the llvmpipe jobs are marked as allowed to fail. Ideally we'll eventually fix our bugs and mark the llvmpipe ones in the tests, so that the CI tests completely pass and possible problems in the Vulkan driver are recorded at a better granularity (this is the reason why GitLab says that the pipeline is passed with warnings: the warnings are that there are jobs that failed, even if they were allowed to fail). * ~~The runners provided by the GitLab instance don't have a GPU available, so I configured my own computer (equipped with an AMD Radeon RX 5700 RX) to provide a runner with access to the GPU. This setup is not currently satisfying: for me, because I use that computer for other things and I don't like having random code submitted to it (it is theoretically sandboxed, but sandboxes are not always bullet-proof, especially if they have access to a GPU); for the users, because my computer might be unavailable at any time. I'll work on a better solution. For the time being I intend the runner to only accept jobs from the master branch; once a better solution is implemented I'd like to run the pipeline for MRs too.~~ **Fixed**, now there is a shared worker with an AMD GPU available. * While the `Dockerfile` and related assets do not necessarily need to be available in this repository, given that the CI accesses the binary image from the Docker hub anyway, I think it's still valuable to have them, so others can improve them (and for sure improvement opportunities are nowhere near missing). However, other ways to make them available can be found, if for some reason it is not liked to have them in this repository (they are not pretty!). * ~~One of the reason they are not pretty is that I have a custom hack to compile `widl` from the Wine sources without compiling (or installing from the distribution) the whole of Wine, in the interest of keeping the Docker image small (well, small-ish: Vulkan drivers, compilers and X libraries are not small anyway).~~ **A better solution was implemented** * ~~Again on the subject of the Docker image, I am currently putting the binary image in my own namespace on the Docker hub. Using the GitLab container registry in the namespace of the Wine project would probably be better, so that I am not a bottleneck in the future.~~ **Done** * ~~Even if we discount all the points above, this MR cannot be merged yet, because my runner is currently configured for my namespace only. I guess I need the intervention of a GitLab admin to fix that. However, I think there's already material enough for valuable feedback.~~ **Fixed too** -- v7: ci: Introduce a CI pipeline for GitLab. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/271

2 3