August 2023 - Wine-gitlab - list.winehq.org

Re: [PATCH v3 0/1] MR3491: winegstreamer: Leave media source critical section before unlocking workqueue.
by Zebediah Figura (＠zfigura) 04 Aug '23

04 Aug '23

> It doesn't matter much if the handle is invalid, as the PutWorkItem call will just fail. But the handle could in theory be reallocated for a different queue. Also, if queues are supposed to be refcounted, it looks quite wrong that a thread which doesn't have a reference to a handle is accessing it; that's the sort of thing that generally causes memory errors. It might be the case that our current implementation is preventing any of this from being a problem in practice, but it's fragile and unidiomatic, and it is rather confusing to anyone reading the code; it looks like an error. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3491#note_41425

1 0

Re: [PATCH v3 0/1] MR3491: winegstreamer: Leave media source critical section before unlocking workqueue.
by Bernhard Kölbl 04 Aug '23

04 Aug '23

On Fri Aug 4 19:58:51 2023 +0000, Zebediah Figura wrote: > Not sure why I wasn't added as reviewer, but this looks wrong, and I > think this doesn't fully solve the problem, either. > As far as I can tell, if there's something else [what?] that pushes to > the queue executing concurrently with Shutdown(), it'll end up pushing > to an invalid queue handle after Shutdown() returns. This was already > the case, but now it's worse, because you can't just fix it by setting > source->async_commands_queue to NULL. 1. You were added as reviewer. 2. It doesn't matter much if the handle is invalid, as the PutWorkItem call will just fail. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3491#note_41424

1 0

[PATCH 0/1] MR3469: d3dx11_43/tests: Add a trailing '\n' to ok() calls.
by Alistair Leslie-Hughes (＠alesliehughes) 04 Aug '23

04 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3469

3 2

[PATCH 0/4] MR3514: sapi: CoInitializeEx fix and trace improvement.
by Shaun Ren (＠shaunren) 04 Aug '23

04 Aug '23

This MR fixes a bug in Far Cry 6 where the necessary objects cannot be initialized in its speech synthesis thread. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3514

3 5

[PATCH v2 0/1] MR3507: win32u: Copy an incoming CB_GETCOMBOBOXINFO when packing it for the client.
by Tim Clem (＠tclem) 04 Aug '23

04 Aug '23

The only important field at this point is cbSize, but if it's zero, the message will not be processed. --- The other option would be to zero the buffer and then do the equivalent of `((COMBOBOXINFO *)buffer)->cbSize = sizeof(COMBOBOXINFO)`, rather than copying the incoming lparam. That doesn't seem better to me, but I'm no expert. -- v2: win32u: Copy an incoming COMBOBOXINFO when packing CB_GETCOMBOBOXINFO for clients. https://gitlab.winehq.org/wine/wine/-/merge_requests/3507

3 4

Re: [PATCH v3 0/5] MR3498: d3d tests: Use compare_uint() in compare_float() instead of abs(). - approved
by Zebediah Figura (＠zfigura) 04 Aug '23

04 Aug '23

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3498

1 0

Re: [PATCH v3 0/1] MR3491: winegstreamer: Leave media source critical section before unlocking workqueue.
by Zebediah Figura (＠zfigura) 04 Aug '23

04 Aug '23

Not sure why I wasn't added as reviewer, but this looks wrong, and I think this doesn't fully solve the problem, either. As far as I can tell, if there's something else [what?] that pushes to the queue executing concurrently with Shutdown(), it'll end up pushing to an invalid queue handle after Shutdown() returns. This was already the case, but now it's worse, because you can't just fix it by setting source->async_commands_queue to NULL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3491#note_41413

1 0

[PATCH v7 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Alistair Leslie-Hughes (＠alesliehughes) 04 Aug '23

04 Aug '23

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v7: ntoskrnl.exe: Add FltBuildDefaultSecurityDescriptor test fltmgr.sys: Create import library fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor https://gitlab.winehq.org/wine/wine/-/merge_requests/414

4 6

[PATCH 0/1] MR3513: include: Add IXAudio2Extension in xaudio2.idl.
by Biswapriyo Nath (＠Biswa96) 04 Aug '23

04 Aug '23

Required for rpcs3 project. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3513

3 3

[PATCH 0/1] MR3508: d3d11/tests: Add basic tests for keyed mutexes.
by Paul Gofman (＠gofman) 04 Aug '23

04 Aug '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3508

4 3