September 2023 - Wine-gitlab

Re: [PATCH v5 0/5] MR3792: Fill in some VMR9 stubs
by Francois Gouget (＠fgouget) 14 Sep '23

14 Sep '23

This MR causes quartz:vmr9 to crash on all Windows versions: https://test.winehq.org/data/patterns.html#quartz:vmr9 The TestBot actually detected those but somehow the corresponding report was lost: https://www.winehq.org/mailman3/hyperkitty/list/wine-gitlab(a)winehq.org/me… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3792#note_45321

1 0

[PATCH 0/2] MR3832: user32: Map WM_CHAR wparam in ASCII to Unicode in IsDialogMessageA() for CJK locales.
by Zhiyi Zhang (＠zhiyi) 14 Sep '23

14 Sep '23

Fix displaying Chinese characters as "??" in some applications with Chinese locale. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3832

3 3

[PATCH v4 0/1] MR3785: d3drm: Correct D3DRMIMAGE validation
by Alistair Leslie-Hughes (＠alesliehughes) 14 Sep '23

14 Sep '23

-- v4: d3drm: Correct D3DRMIMAGE validation https://gitlab.winehq.org/wine/wine/-/merge_requests/3785

4 3

[PATCH 0/10] MR3820: mshtml: Traverse and unlink elements using the dispex vtbl, part 1.
by Gabriel Ivăncescu 14 Sep '23

14 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3820

2 11

[PATCH 0/2] MR3779: d3d9/tests:kwin fixes
by Stefan Dösinger 14 Sep '23

14 Sep '23

kwin resizes hidden windows most of the time. I see the existing flaky markers triggered on Windows 11 occasionally. This MR makes the ddraw-d3d9 tests run reliably on kwin (I tested version 5.27.7) in Xephyr and a real display. This makes the !WS_VISIBLE tests fairly weak since we ignore the random failures we get on Windows and Wine. According to https://marc.info/?l=wine-patches&m=141642450913299&w=2 , the mail to wine-patches behind commit f4d520d6e2, which added this test, those tests intended to cover some differences between d3d9 and d3d9ex, not a specific game behavior. I vaguely remember that I did run into something that needed this behavior, but I can't find out any more what this might have been. The memory of those 9 year old patches is getting blurry. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3779

4 5

[PATCH v2 0/5] MR3757: Fix Windows XP d3d test crashes
by Stefan Dösinger 14 Sep '23

14 Sep '23

This series fixes a few bugs in the d3d tests that cause them to crash on my Windows XP laptop with the r200 GPU (dx8 era). There are plenty more problems on this GPU on Windows. d3d8:visual hangs the entire system. d3d9:device has some failing tests. d3d9:visual crashes, which is probably good because otherwise it would also cause a kernel panic. -- v2: d3d9/tests: Fix skipping ATI2N in test_resource_access. d3d8/tests: Fix skipping ATI2N in test_resource_access. d3d9/tests: Request a 3 mip level cube texture in test_getdc(). d3d8/tests: Zero stride tests crash on Windows XP, r200 GPU. d3d9/tests: Zero stride tests crash on Windows XP, r200 GPU. https://gitlab.winehq.org/wine/wine/-/merge_requests/3757

4 8

Re: [PATCH v8 0/6] MR3636: winegstreamer: Implement wg_muxer.
by Ziqing Hui (＠zhui) 14 Sep '23

14 Sep '23

On Thu Sep 14 07:06:18 2023 +0000, Ziqing Hui wrote: > This was added because mp4mux is requiring it: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/main/subprojects/… > Without codec_data set, mp4mux element fails. And according to my test, > setting codec_data to MF_MT_MPEG_SEQUENCE_HEADER is OK, becuase I > finally successfully generate a mp4 file which is able to be played by > video player. I didn't dig into how mp4mux element handle h264 codec_data. But the truth is it do accpet MF_MT_MPEG_SEQUENCE_HEADER. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3636#note_45304

1 0

Re: [PATCH v8 0/6] MR3636: winegstreamer: Implement wg_muxer.
by Ziqing Hui (＠zhui) 14 Sep '23

14 Sep '23

On Thu Sep 14 07:06:18 2023 +0000, Zebediah Figura wrote: > Hi Ziqing, I've been doing some research, and I believe patch 2/6 > (committed as 320383c594c4) is incorrect. GStreamer's "codec-data" field > is an AVCDecoderConfigurationRecord, as defined by ISO/IEC 14496-15 > (which you can see at [1]). MF_MT_MPEG_SEQUENCE_HEADER, on the other > hand, seems to contain the raw SPS/PPS NALUs, start codes and all. > Since Microsoft uses Annex B everywhere, it shouldn't need the > codec-data anyway, so I'm curious now why this was added—was there a > need for it, or did you just add it on the assumption that the two > attributes mapped to each other? > [1] https://doc-kurento.readthedocs.io/en/latest/knowledge/h264.html#gstreamer-… This was added because mp4mux is requiring it: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/main/subprojects/… Without codec_data set, mp4mux element fails. And according to my test, setting codec_data to MF_MT_MPEG_SEQUENCE_HEADER is OK, becuase I finally successfully generate a mp4 file which is able to be played by video player. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3636#note_45303

1 0

[PATCH 0/1] MR3821: dsound: Get rid of DSOUND_capturers and related lock.
by Arek Hiler (＠ivyl) 14 Sep '23

14 Sep '23

Ever since dcaeb6b4fdf8 ("dsound: Allow multiple buffers to capture from the same device.") it's not used for anything. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3821

3 3

[PATCH 0/2] MR3831: msvcp110: Add _Throw_C_error implementation.
by Piotr Caban (＠piotr) 14 Sep '23

14 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3831

2 2