October 2024 - Wine-gitlab - list.winehq.org

[PATCH v2 0/1] MR6728: explorer: Prevent apps from showing Wine specific shell tray window with no icons.
by Paul Gofman (＠gofman) 03 Dec '24

03 Dec '24

-- v2: explorer: Prevent apps from showing Wine specific shell tray window with no icons. https://gitlab.winehq.org/wine/wine/-/merge_requests/6728

3 9

[PATCH 0/3] MR5712: winewayland.drv: Update key state from Wayland information.
by Alexandros Frantzis (＠afrantzis) 01 Dec '24

01 Dec '24

Recent changes allowed the Wayland driver to properly deal with numpad keys depending on numlock status. This MR ensures that numlock and other lock state is properly synced, and concludes the fix for https://bugs.winehq.org/show_bug.cgi?id=56397. This MR also syncs the key press state when a window gains keyboard focus, including any modifier press state. Note that we currently ignore the modifier press information from the `modifier` event, since: 1. it doesn't differentiate between left-right keys, 2. mod press state changes will be normally preceded by a matching key event, so we are able to sync properly. However, if we find that we need to handle mod press state changes without corresponding key events, we will need to implement some sensible way to sync these, too. Although I would like for the driver work exclusively in terms of scancodes, I still needed to use vkeys in this case, since this is how wineserver expresses keyboard state at the moment. This means that I had to introduce/duplicate some extra scan->vkey logic in the driver (e.g., numpad keys based on numlock state) to get things right. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5712

5 15

[PATCH v2 0/3] MR698: d2d1: Implement transform graph.
by Ziqing Hui (＠zhui) 01 Dec '24

01 Dec '24

-- v2: d2d1: Implement nodes connection for ID2D1TransformGraph. d2d1: Implement nodes adding and removal for ID2D1TransformGraph. d2d1/tests: Add more tests for ID2D1TransformGraph. https://gitlab.winehq.org/wine/wine/-/merge_requests/698

2 6

[PATCH v2 0/1] MR6438: winewayland: Delay setting user driver functions.
by Aida Jonikienė 28 Nov '24

28 Nov '24

This fixes segfaults and explorer.exe being stuck when this driver fails to load. -- v2: winewayland: Delay setting user driver functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/6438

1 5

[PATCH v2 0/11] MR5085: jscript: Implement Typed Arrays.
by Gabriel Ivăncescu 28 Nov '24

28 Nov '24

-- v2: jscript: Implement Uint8ClampedArray. jscript: Implement 'set' for Typed Arrays. jscript: Implement 'subarray' for Typed Arrays. jscript: Implement Typed Array construction from objects. jscript: Implement ArrayBuffer.isView. jscript: Implement Typed Array construction on ArrayBuffers. jscript: Add initial implementation of Typed Arrays. jscript: Use DISP_E_UNKNOWNNAME when looking up a prop that doesn't exist. jscript: Avoid allocating props for indexed props unless necessary. jscript: Move the indexed prop idx lookup into a helper. mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5085

3 20

[PATCH 0/1] MR3226: comctl32/edit: Scroll caret on Ctrl+A.
by Vladislav Timonin (＠vt) 28 Nov '24

28 Nov '24

Every other use of `EDIT_EM_SetSel` updates caret position by calling `EDIT_EM_ScrollCaret` or `EDIT_SetCaretPos`. Fixes caret blinking in the middle when selecting all text. ![changes](/uploads/019bce6c12e0378d391e1253ecbaf9c6/changes.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3226

4 6

[PATCH v9 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu 28 Nov '24

28 Nov '24

-- v9: jscript: Remove PROP_IDX dispex props by handling them in object prop methods. jscript: Move filling the PROTREF into a helper. jscript: Simplify get_flags to only check whether it's enumerable. jscript: Get rid of on_put in the object vtbl. jscript: Inline prop_put. jscript: Inline prop_get. jscript: Inline invoke_prop_func and invoke PROTREFs using their vtbl method. jscript: Inline delete_prop. jscript: Use mandatory methods in the object vtbl to operate on props found jscript: Use mandatory methods in the object vtbl to operate on props mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

2 14

[PATCH 0/1] MR1121: winhttp: Fix missing reference upcount
by Yuan Yao (＠yaoyuan.0553) 28 Nov '24

28 Nov '24

The reference count of host is supposed to go up by one in netconn_create. The missing ref increment causes error handling paths where netconn_close or release_host is called to prematurely decrement the ref count of host to zero. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1121

4 6

[PATCH v6 0/4] MR4761: ntdll: Implement NtContinueEx()
by Dāvis Mosāns 27 Nov '24

27 Nov '24

This MR implements `NtContinueEx(PCONTEXT, PCONTINUE_OPTIONS)` which was added in Windows 10 20H1. Also added basic test reusing existing `test_continue()` (included from !4720) League of Legends game hooks `NtContinue()` and `NtContinueEx()` by putting `jmp` instruction in front of it. Note that LoL doesn't actually use `NtContinueEx()` itself and game will work fine without it but if game doesn't find `NtContinueEx()` it will permanently ban your account due to detecting "scripting program" -- v6: ntdll/tests: Implement APC test for NtContinue() ntdll/tests: Add basic test for NtContinueEx() ntdll: Implement NtContinueEx() https://gitlab.winehq.org/wine/wine/-/merge_requests/4761

3 11

[PATCH v5 0/2] MR3718: dwrite: Fix incorrect position of glyph when using BitmapRenderTarget in HiDPI
by Tingzhong Luo (＠tzluo) 26 Nov '24

26 Nov '24

The "GdiInterop" is a sample application (source code is avaiable in [Github][source_code], relative guide in [MSDN][msdn_guide]) that demostracts how to display DirectWrite text on a GDI surface. After set dpi to 168 in `winecfg`, and run sample application with wine, the font size is normal, but the position of glyph is incorrect. | Dpi: 96 | Dpi: 168 | |:----------------:|:-----------------:| | ![ss1][sc_96dpi] | ![ss2][sc_168dpi] | There is the sample application after compile: [Release_x64.tar.gz](/uploads/c70e32824efcaa5d16ab39bbb4b86e30/Release_x64.tar.gz) After change transform matrix that pass to `IDWriteFactory7_CreateGlyphRunAnalysis`, it can display glyph correctly. [source_code]: https://github.com/microsoft/Windows-classic-samples/blob/main/Samples/Win7… [msdn_guide]: https://learn.microsoft.com/en-us/windows/win32/directwrite/render-to-a-gdi… [sc_96dpi]: /uploads/59cc343cfaa025f4ff4c32a84ab8cfeb/图片.png [sc_168dpi]: /uploads/938be653362bb6ac58471b69ab66099a/图片.png -- v5: dwrite: Fix incorrect position of glyph when rendering with BitmapRenderTarget in HiDPI dwrite: Return render bounds if text not intersect to BitmapRenderTarget https://gitlab.winehq.org/wine/wine/-/merge_requests/3718

3 5