October 2024 - Wine-gitlab - list.winehq.org

[PATCH v2 0/2] MR4794: comctl32/combo: Add tests for keypresses showing search functionality
by Fabian Maurer (＠DarkShadow44) 16 Nov '24

16 Nov '24

In preparation to fix https://bugs.winehq.org/show_bug.cgi?id=56104 and https://bugs.winehq.org/show_bug.cgi?id=42898 -- v2: comctl32/listbox: Add tests for keypresses showing search functionality comctl32/combo: Add tests for keypresses showing search functionality https://gitlab.winehq.org/wine/wine/-/merge_requests/4794

3 11

[PATCH 0/1] MR5232: rundll32: Allow DLL name and entrypoint to be separated by any combination of spaces/commas.
by Aida Jonikienė 15 Nov '24

15 Nov '24

This is one of the two rundll32 changes required for GeForce NOW installer to work (the other one is too hacky to upstream without major changes) This commit was originally found on https://github.com/aabgrall/wine-base-geforcenow (but the author never bothered to send it to the ML/GitLab) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5232

3 4

[PATCH v5 0/4] MR5759: comctl32 & user32: Mark radio buttons at selected when focused
by Fabian Maurer (＠DarkShadow44) 15 Nov '24

15 Nov '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56109 -- v5: user32: Send parent BN_CLICKED notification when a radio button get focused comctl32: Send parent BN_CLICKED notification when a radio button get focused user32/tests: Add tests for radio button WM_SETFOCUS comctl32/tests: Add tests for radio button WM_SETFOCUS https://gitlab.winehq.org/wine/wine/-/merge_requests/5759

4 8

[PATCH v16 0/4] MR4551: Server-side thread priorities implementation (Part 1)
by Marc-Aurel Zent (＠mzent) 15 Nov '24

15 Nov '24

This is the current proton thread priority implementation by @rbernon rebased for upstream with a few `#ifdef`s added since AFAIK Linux is the only operating system where threads have a unique PID which can be used to set niceness on. ~~I also ran `./tools/make_requests` on https://gitlab.winehq.org/mzent/wine/-/commit/6705d3481be0409f7e971c1d2c7a3… as well and `autoconf` on https://gitlab.winehq.org/mzent/wine/-/commit/d7bafe40c411753662b2ad97148a6… (which does blow up the line count a bit).~~ A few tiny changes ~~(with the ready variable for example)~~ are in anticipation for Part 2, which also adds Mach thread priorities and recalculates thread priorities on process priority change. Since this is a rather large MR, I hope the split here is appropriate ~~(with the second part being slightly smaller)~~, but I think logically it makes the most sense here. -- v16: server: Check wineserver privileges on init with -20 niceness. server: Use setpriority to update thread niceness when safe. ntdll: Set RLIMIT_NICE to its hard limit. server: Introduce new set_thread_priority helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/4551

4 6

[PATCH v8 0/47] MR6623: Draft: include/winnt.h: Add support for thread safety annotation attributes.
by Vibhav Pant (＠vibhavp) 14 Nov '24

14 Nov '24

This MR introduces support for [thread safety annotations,](https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#conditi… currently supported by Clang. The feature is similar to `__WINE_MALLOC` attributes, allowing functions, data members and global variables to be optionally annotated with synchronization details. As a proof of concept, I have annotated `RTL_CRITICAL_SECTION` and `dlls/ntdll`. Because the feature was designed as a C++ extension first, a bit of stubbing is required to annotate struct fields about what lock they are guarded by. The macros `WINE_DECLARE_LOCK_FIELD_STUB` and `WINE_DEFINE_LOCK_FIELD_STUB` take care of that. For instance, in `dlls/ntdll/threadpool.c`: ```c WINE_DECLARE_LOCK_FIELD_STUB(threadpool_group, CRITICAL_SECTION, cs); struct threadpool_group { LONG refcount; BOOL shutdown; CRITICAL_SECTION cs; /* list of group members, locked via .cs */ struct list members __WINE_FIELD_GUARDED_BY(threadpool_group, cs); }; WINE_DEFINE_LOCK_FIELD_STUB(threadpool_group, CRITICAL_SECTION, cs); ``` Clang will therefore warn if `members` is accessed without holding `cs`. Note that the analyzer does not support conditional locking. For that reason, functions that hold and release a lock conditionally have been marked with `__WINE_NO_THREAD_SAFETY_ANALYSIS` to pre-empt false positives from Clang. -- v8: configure: Enable -Wthread-safety-analysis, -Wthread-safety-attributes warnings. dlls/ntoskrnl.exe: Add thread safety annotations. dlls/combase: Add thread safety annotations. dlls/imm32: Add GUARDED_BY attribute to the struct ime's refcount field. dlls/crypt32: Annotate CRYPT_CollectionAdvanceEnum indicating that the caller should hold the collection store's lock. dlls/amstream/tests: Disable thread safety analysis for testfilter_wait_state. dlls/winhttp: Add thread safety annotations. dlls/mmdevapi: Add thread safety annotations for session_lock and sessions_unlock. dlls/mfplat: Add thread safety annotations. dlls/msi: Add thread safety annotations for msiobj_lock and msiobj_unlock. dlls/xaudio2_7: Add thread safety annotations. dlls/wmvcore: Add thread safety annotations for async_reader_wait_pts, async_reader_deliver_sample, and callback_thread_run. dlls/wininet: Disable thread safety annotations for HTTPREQ_ReadFile and HTTPREQ_QueryDataAvailable. dlls/winegstreamer: Add thread safety annotation for GST_Seeking_SetPositions. dlls/dwrite: Add thread safety annotations for factory_lock and factory_unlock. dlls/wined3d: Add thread safety annotations. lib/vkd3d: Build with WINE_NO_THREAD_SAFETY_ANALYSIS defined. dlls/d2d1: Add thread safety annotations. dlls/xaudio2_7: Disable thread safety analysis for IXAudio2Impl_CreateSourceVoice. dlls/xinput1_3: Add thread safety annotations for controller_lock and controller_unlock. dlls/ucrtbase/tests: Only release &fp.iobuf->_crit if the previous lock was successful (Clang). dlls/netio.sys: Add thread safety annotations for lock_sock and unlock_socket. dlls/msvcirt/tests: Release &sb.lock only if the previous lock was successful (Clang). dlls/wbemprox: Add thread safety annotations. libs/strmbase: Annotate BaseRenderer_Receive to indicate the caller needs to hold the underlying filter lock. dlls/rpcrt4: Add thread safety annotations for AllocateContextHandle, FindContextHandle, ReleaseContextHandle. dlls/wined3d: Add thread safety annotations for allocator locking helpers. dlls/mfreadwrite: Indicate calling source_reader_read_sample requires holding &reader->cs. dlls/mapi32: Add thread safety annotations for GetValue, AddValue, Lock, Unlock. dlls/kernel32/tests: Add thread safety annotations. dlls/combase: Add thread safety annotations programs/services: Add thread safety annotations. dlls/winmm: Add thread safety annotations. dlls/vcomp: Add thread safety annotations. dlls/user32: Add thread safety annotations. dlls/odbc32: Add thread safety annotations. dlls/krnl386.exe16: Add thread safety annotations. dlls/msvcirt: Add thread safety annotations. dlls/msvcp90: Add thread safety annotations. dlls/msvcrt: Add thread safety annotations. dlls/kernelbase: Add thread safety annotations. include/wine/winbase16: Add thread safety annotations for _Enter/LeaveSysLevel dlls/kernelbase: Release console_section in case of an allocation failure in alloc_console. include/winbase.h: Add thread safety annotations for Enter/LeaveCriticalSection, SleepConditionVariableCS and TryEnterCriticalSection. dlls/ntdll: Add thread safety annotations. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6623

1 1

[PATCH v2 0/2] MR6301: Introduce a new WINE_VIDEO_DRIVER variable.
by Aida Jonikienė 13 Nov '24

13 Nov '24

This variable is the Wine's equivalent of the SDL_VIDEODRIVER/ SDL_VIDEO_DRIVER variable in SDL 2 and 3 (it explicitly selects a list of graphics/video drivers to be used). -- v2: man: Add documentation for the WINE_VIDEO_DRIVER variable. explorer: Introduce a new WINE_VIDEO_DRIVER variable. https://gitlab.winehq.org/wine/wine/-/merge_requests/6301

4 12

[PATCH v2 0/1] MR5582: explorer: Finish wide-string literal migration.
by Aida Jonikienė 13 Nov '24

13 Nov '24

-- v2: explorer: Finish wide-string literal migration. https://gitlab.winehq.org/wine/wine/-/merge_requests/5582

3 4

[PATCH 0/5] MR6721: mshtml: Fix deletion of global window props.
by Gabriel Ivăncescu 13 Nov '24

13 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6721

2 17

[PATCH v13 0/21] MR6505: wlanapi: Implement several methods on top of NetworkManager.
by Vibhav Pant (＠vibhavp) 13 Nov '24

13 Nov '24

This MR adds a unixlib component to wlanapi containing DBus + NetworkManager implementations for * WlanEnumInterfaces * WlanGetAvailableNetworkList * WlanGetNetworkBssList * WlanScan * WlanSetProfile * WlanConnect * WlanGetProfileList * WlanDisconnect -- v13: wlanapi: Add NetworkManager backed implementation for WlanDisconnect. wlanapi/tests: Add unit tests for WlanDisconnect. wlanapi: Add NetworkManager backed implementation for WlanSetProfile. wlanapi/tests: Add tests for WlanSetProfile. wlanapi: Add stub for WlanSetProfile. wlanapi: Add stub for WlanDisconnect. wlanapi: Add an initial NetworkManager backed implementation for WlanConnect. wlanapi/tests: Add unit tests for WlanConnect. wlanapi: Add stub for WlanConnect. wlanapi: Add NetworkManager backed implementation for WlanGetProfileList. wlanapi/tests: Add unit tests for WlanGetProfileList. wlanapi: Add stub for WlanGetProfileList. wlanapi: Add NetworkManager backed implementation for WlanScan. wlanapi/tests: Add unit tests for WlanScan. wlanapi: Add NetworkManager backed implementation for WlanGetNetworkBssList. wlanapi/tests: Add unit test for test_WlanGetNetworkBssList. wlanapi: Add stub for WlanGetNetworkBssList. wlanapi: Add NetworkManager backed implementation for WlanGetAvailableNetworkList. wlanapi/tests: Add unit test for WlanGetAvailableNetworkList. wlanapi: Add NetworkManager backed implementation for WlanEnumInterfaces. wlanapi: Add a basic unixlib implementation. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6505

1 4

[PATCH 0/8] MR6731: winex11: Replace win data iconic/mapped/net_wm_state flags.
by Rémi Bernon 13 Nov '24

13 Nov '24

Using the window style and the new tracker pending_state/current_state to decide on the necessary changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6731

1 10