November 2024 - Wine-gitlab

[PATCH v3 0/3] MR6715: Draft: Draft: Support separated debug information for PE images.
by eric pouech (＠epo) 30 Nov '24

30 Nov '24

This serie is a first attempt to provide a solution to bug 57308 [1](https://bugs.winehq.org/show_bug.cgi?id=57308). Basically, Arch distro is looking for Wine support in distributing debug information for Wine PE modules separated from image. A quick overview of distro (Debian, Fedora, Arch) situation i (I may have missed a couple of items), but: - no distro ship separate debug information for PE modules (they do it for ELF ones though) - at best, they ship unstripped PE modules. IMO, we need to help them pave the way to what should be the best expected situation (in Wine and wrt distros) to support separate debug information for PE images. First, I believe we need to use a (solid) key to bind the stripped image and the file holding the debug information. In ELF format, this is typically done by inserting a .note.gnu.build-id section (in both stripped image and debug information file) which contains the key. This key is used to either search in fixed location (eg /usr/lib/.debug), or as key to download the debug information from a remote server (debuginfod). The key is generally made of a hash of (some sections of) the image file. This allows (esp. in the case of downloading the debug information from a debugger) to discriminate between several versions of the same module. I think we should target this kind of solution instead of storing the debug information alongside the module (usually done as ntdll.dll.debug). This wouldn't let debuggers download the expected debug info upon request. Fortunately, gcc and clang provide a build-id option (when generating PE images) which stores this key in the PE image. What this serie does: - fixes & improves dbghelp in the support of the build-id information from gcc/mingw & clang, - improves Wine's configure script so that clang can be used to generate dwarf debug information and build-id information in PE builds, - adds a couple of additional search locations for debug information files, It takes the following assumptions for the storage: - debug information files for PE images are stored in same hierarchy as debug information files for ELF images (eg /usr/lib/.debug) - naming of such files is done as ELF, ie by using the hex string generated from the binary blob of the key. This is _NOT_ the usual way how the GUID will be printed (because the first 3 integers of the GUID are stored in little-endian format). (Note: I had to make a choice here. I don't have strong arguments one way or the other, but we need to agree on the convention here). What distro should do to support separate debug info: - configure Wine with --enable-build-id - adapt at least the packaging tool to extract the key out of unstripped image \[2\], - if binutils isn't compiled with PE support (this is apparently the Arch case), adapt the scripts to use x86_64-objcopy instead of objcopy (and friends). I marked this MR as draft for now, as: - I still need to polish some items (like the default location for looking up debug information files), - wait for feedback on this proposal (it does make a couple of assumptions that need sharing IMO), Further steps: - the steps above are mainly targetted to have a solution for packaged download of debug information files, - this should be integrated in debuginfod (server side: ingestion of PE files and client side: ensure gdb, lldb are compatible; implement debuginfod in winedbg). Feed back welcomed! \[2\]: The least invasive readelf replacement (assuming binutils is compiled with PE support). (otherwise, use x86_64-objdump) ``` BUILDID=`objdump -p "$INPUT" | sed -n "/RSDS signature / {s/.*signature //; s/ age.*//p; q;}"` BUILDID=${BUILDID:6:2}${BUILDID:4:2}${BUILDID:2:2}${BUILDID:0:2}${BUILDID:10:2}${BUILDID:8:2}${BUILDID:14:2}${BUILDID:12:2}${BUILDID:16} ``` Additional note: gcc/mingw puts the desired debug entry inside a dedicated section (.buildid), while clangs keeps it in .rdata (as msvc does). So, this invalidates any attempt to get information from the .buildid section (as stated in bug report). -- v3: configure.ac: Ensure dwarf debug sections are kept with clang with build-id enabled. dbghelp: Search debug info with buildid for RSDS debug entry w/o filenames. dbghelp: Extend search for buildid in system directories. https://gitlab.winehq.org/wine/wine/-/merge_requests/6715

4 8

[PATCH v3 0/5] MR6917: windows.networking.connectivity: Implement IConnectionProfile::GetNetworkConnectivityLevel().
by Mohamad Al-Jaf (＠maljaf) 30 Nov '24

30 Nov '24

Needed by Just Cause 4. -- v3: windows.networking.connectivity: Implement IConnectionProfile::GetNetworkConnectivityLevel(). windows.networking.connectivity/tests: Add INetworkInformationStatics::GetInternetConnectionProfile() tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/6917

3 8

[PATCH v2 0/5] MR6917: windows.networking.connectivity: Implement IConnectionProfile::GetNetworkConnectivityLevel().
by Mohamad Al-Jaf (＠maljaf) 30 Nov '24

30 Nov '24

Needed by Just Cause 4. -- v2: windows.networking.connectivity: Implement IConnectionProfile::GetNetworkConnectivityLevel(). windows.networking.connectivity/tests: Add INetworkInformationStatics::GetInternetConnectionProfile() tests. windows.networking.connectivity: Implement INetworkInformationStatics::GetInternetConnectionProfile(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6917

2 7

[PATCH 0/7] MR6931: win32u: Move surface and swapchain wrappers from winevulkan.
by Rémi Bernon 30 Nov '24

30 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6931

1 7

[PATCH 0/3] MR6878: dinput: Fix a couple of regressions.
by Paul Gofman (＠gofman) 29 Nov '24

29 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6878

4 25

[PATCH v2 0/2] MR6929: kernelbase: Properly return 0 from EnumSystemFirmwareTable on error.
by Evan Tang (＠etang-cw) 29 Nov '24

29 Nov '24

6d1df55bf3b6051ad61e9c7cb7d63f13c1b9771f changed `NtQuerySystemInformation(SystemFirmwareTableInformation, ...)` to return 0 on error, which left `get_firmware_table` returning -16 This would be interpreted as a very large number by applications, breaking them. -- v2: kernelbase: Add test for EnumSystemFirmwareTables on missing provider. https://gitlab.winehq.org/wine/wine/-/merge_requests/6929

3 3

Re: [PATCH v3 0/1] MR6923: ntdll: Add NtFlushBuffersFileEx() semi-stub. - approved
by Alexandre Julliard (＠julliard) 29 Nov '24

29 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6923

1 0

Re: [PATCH v6 0/4] MR6927: mshtml: Implement proper prototype chain for documents. - approved
by Alexandre Julliard (＠julliard) 29 Nov '24

29 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6927

1 0

Re: [PATCH v2 0/1] MR6928: mscoree: Update Wine Mono to 9.4.0. - approved
by Alexandre Julliard (＠julliard) 29 Nov '24

29 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6928

1 0

Re: [PATCH v2 0/5] MR6858: wined3d: FFP HLSL shaders, part 2/3. - approved
by Alexandre Julliard (＠julliard) 29 Nov '24

29 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6858

1 0