November 2024 - Wine-gitlab

[PATCH v5 0/4] MR6927: mshtml: Implement proper prototype chain for documents.
by Gabriel Ivăncescu 29 Nov '24

29 Nov '24

-- v5: mshtml: Don't expose some props from document prototype depending on mode. mshtml: Expose the right props from document fragments. mshtml: Use DocumentPrototype as the document's prototype for modes prior mshtml: Move HTMLDocument prototype props to the Document prototype. https://gitlab.winehq.org/wine/wine/-/merge_requests/6927

2 5

Re: [PATCH v4 0/4] MR6927: mshtml: Implement proper prototype chain for documents.
by Jacek Caban (＠jacek) 29 Nov '24

29 Nov '24

On Fri Nov 29 17:14:34 2024 +0000, Gabriel Ivăncescu wrote: > This seems to give me test failures about not finding "title" element, > only on wine. I assume we lack something to automatically put a title if > missing. What should I do? Ah, that's one of those parser differences with Gecko. Let's leave it as you did for now then. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6927#note_89251

1 0

Re: [PATCH v4 0/4] MR6927: mshtml: Implement proper prototype chain for documents.
by Gabriel Ivăncescu 29 Nov '24

29 Nov '24

On Fri Nov 29 17:00:58 2024 +0000, Jacek Caban wrote: > Let's try to avoid adding more strings here. You could change > `test_docfrag` to use `set_body_html` and then use the existing `doc_blank`/`doc_blank_ie9`. This seems to give me test failures about not finding "title" element, only on wine. I assume we lack something to automatically put a title if missing. What should I do? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6927#note_89250

1 0

Re: [PATCH v4 0/4] MR6927: mshtml: Implement proper prototype chain for documents.
by Jacek Caban (＠jacek) 29 Nov '24

29 Nov '24

Jacek Caban (@jacek) commented about dlls/mshtml/mshtml_private.h: > > /* Used by objects that want to delay their compat mode initialization until actually needed */ > HTMLInnerWindow *(*get_script_global)(DispatchEx*); > + dispex_static_data_t *(*get_dispex_data)(DispatchEx*); Could we just extend `get_script_global` instead? Other than document objects, it's used only for windows anyways. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6927#note_89248

1 0

Re: [PATCH v4 0/4] MR6927: mshtml: Implement proper prototype chain for documents.
by Jacek Caban (＠jacek) 29 Nov '24

29 Nov '24

Jacek Caban (@jacek) commented about dlls/mshtml/tests/dom.c: > static const char emptydiv_str[] = > "<html><head><title>emptydiv test</title></head>" > "<body><div id=\"divid\"></div></body></html>"; > +static const char emptydiv_ie9_str[] = > + "<html><head><meta http-equiv=\"x-ua-compatible\" content=\"IE=9\"/><title>emptydiv test</title></head>" > + "<body><div id=\"divid\"></div></body></html>"; Let's try to avoid adding more strings here. You could change `test_docfrag` to use `set_body_html` and then use the existing `doc_blank`/`doc_blank_ie9`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6927#note_89249

1 0

Re: [PATCH v4 0/4] MR6927: mshtml: Implement proper prototype chain for documents.
by Gabriel Ivăncescu 29 Nov '24

29 Nov '24

Sorry for the noise, I fixed temporary regression in patch 3 till patch 4. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6927#note_89247

1 0

[PATCH v3 0/4] MR6927: mshtml: Implement proper prototype chain for documents.
by Gabriel Ivăncescu 29 Nov '24

29 Nov '24

-- v3: mshtml: Don't expose some props from document prototype depending on mode. mshtml: Expose the right props from document fragments. mshtml: Use DocumentPrototype as the document's prototype for modes prior mshtml: Move HTMLDocument prototype props to the Document prototype. https://gitlab.winehq.org/wine/wine/-/merge_requests/6927

1 4

[PATCH v2 0/4] MR6927: mshtml: Implement proper prototype chain for documents.
by Gabriel Ivăncescu 29 Nov '24

29 Nov '24

-- v2: mshtml: Don't expose some props from document prototype depending on mode. mshtml: Expose the right props from document fragments. mshtml: Use DocumentPrototype as the document's prototype for modes prior mshtml: Move HTMLDocument prototype props to the Document prototype. https://gitlab.winehq.org/wine/wine/-/merge_requests/6927

1 4

[PATCH 0/5] MR6858: wined3d: FFP HLSL shaders, part 2/3.
by Elizabeth Figura (＠zfigura) 29 Nov '24

29 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6858

3 6

[PATCH 0/3] MR6927: mshtml: Implement proper prototype chain for documents.
by Gabriel Ivăncescu 29 Nov '24

29 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6927

2 5