November 2024 - Wine-gitlab

[PATCH v2 0/1] MR6698: wined3d: Check that format_id is >= 0 before assuming it's an index.
by Rémi Bernon 12 Nov '24

12 Nov '24

Some FOURCC values such as 0xdeadbeef will en up being negative when cast to the enum type, and may cause a random crash later on. This happens randomly in the ddraw tests, depending on the compiler being used. -- v2: wined3d: Cast format_id when comparing it to the last format index. https://gitlab.winehq.org/wine/wine/-/merge_requests/6698

1 2

[PATCH 0/1] MR6781: dinput: Keep the module around while input thread is running.
by Yuxuan Shui (＠yshui) 12 Nov '24

12 Nov '24

So we don't crash if the application unloads dinput. This can only happen if the application didn't release all dinput objects before unloading the module, which we have observed the Yakuza games to do. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6781

3 3

[PATCH 0/1] MR6800: winegstreamer: Lock the media source critical section while using the event queue.
by Conor McCarthy (＠cmccarthy) 12 Nov '24

12 Nov '24

These changes are the documented way to implement IMFMediaEventGenerator for a media source. Avoiding using a destroyed event queue is the only reason to lock the CS that I can find. On top of !6783 it seems to resolve hanging while switching characters in Killsquad (not decisively proven though). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6800

3 3

[PATCH v25 0/7] MR6766: dlls/wintypes: Add stubs for Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) 12 Nov '24

12 Nov '24

-- v25: wintypes: Add stubs for IKeyValuePair<HSTRING, IInspectable *>. wintypes: Add stubs for IIterator<IKeyValuePair<HSTRING, IInspectable *>>. wintypes: Add stubs for IMapView<HSTRING, IInspectable *>. wintypes: Add stubs for IMap<HSTRING, IInspectable *>, IObservableMap<HSTRING, IInspectable *>, IIterable<IKeyValuePair<HSTRING, IInspectable *>> to PropertySet implementation. wintypes: Add stub for Windows.Foundation.Collections.PropertySet. wintypes/test: Add conformance tests for Windows.Foundation.Collections.PropertySet. include: Add Windows.Foundation.Collections.PropertySet runtime class. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

5 19

[PATCH v5 0/4] MR6767: WriteProcessMemory() without PROCESS_QUERY_INFORMATION access right.
by eric pouech (＠epo) 12 Nov '24

12 Nov '24

This is an alternate solution to MR 6761 [1] (actually is based on comment in that MR). WriteProcessMemory() should succeed when process handle doesn't have PROCESS_QUERY_INFORMATION access right set (test attached). Plus some additional cleanup in test for ReadProcessMemory(). Feedback from Proton says that this patch solves the reported game issue. [1] https://gitlab.winehq.org/wine/wine/-/merge_requests/6761 -- v5: server: Amend process rights mapping. advapi32: Test some other cases of process access rights mapping. advapi32/tests: Fix typo in manifest constant. kernel32/tests: Don't hardcode page size in buffer size. https://gitlab.winehq.org/wine/wine/-/merge_requests/6767

3 6

[PATCH 0/1] MR6802: user32: Add GetDpiAwarenessContextForProcess stub.
by Alistair Leslie-Hughes (＠alesliehughes) 12 Nov '24

12 Nov '24

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=57169 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6802

3 2

[PATCH 0/6] MR6803: Cmd engine rewrite (part XXVIII)
by eric pouech (＠epo) 12 Nov '24

12 Nov '24

This is part XXVIII of cmd engine rewrite. It mainly contains bug fixes in various areas, and also a functional improvement (Unix 'touch' equivalent in COPY command). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6803

3 7

[PATCH v3 0/3] MR6680: msvcp140: Use current locale to convert path in _Fiopen.
by Daniel Lehman (＠dlehman25) 12 Nov '24

12 Nov '24

-- v3: msvcp140: Handle utf-8 path in _Fiopen. msvcp140/tests: Add tests for _Fiopen. msvcp120/tests: Add tests for _Fiopen. https://gitlab.winehq.org/wine/wine/-/merge_requests/6680

3 8

[PATCH v8 0/3] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Alanas (＠BZZZZ) 12 Nov '24

12 Nov '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57178 This makes [7-zip file manager](https://www.7-zip.org/) pressing enter while editing path work: * before: * [Icon near path becomes dark (7-zip file manager doesn't go to path).](https://old.reddit.com/r/winehq/comments/16ah3ze/7zip_cant_enter_pa…) * after: * 7-zip file manager goes to path. * Path input displays incorrect path (shouldn't happen, bug in wine's comboboxex unrelated to toolbar). -- v8: comctl32/toolbar: Forward unhandled WM_NOTIFY. comctl32: Move WM_NOTIFY unicode -> ansi converting code from pager.c to commctrl.c. comctl32/tests: Test WM_NOTIFY forwarding in toolbar. https://gitlab.winehq.org/wine/wine/-/merge_requests/6737

4 7

[PATCH v2 0/3] MR6797: winhttp: Add support WinHttpRequestOption_SslErrorIgnoreFlags in IWinHttpRequest_{get,put}_Option.
by Haoyang Chen (＠chenhaoyang) 12 Nov '24

12 Nov '24

-- v2: winhttp: Add support WinHttpRequestOption_SslErrorIgnoreFlags in IWinHttpRequest_get_Option. winhttp: Add support WinHttpRequestOption_SslErrorIgnoreFlags in IWinHttpRequest_put_Option. winhttp/tests: Add some tests for WinHttpRequestOption_SslErrorIgnoreFlags in IWinHttpRequest_{put,get}_Option. https://gitlab.winehq.org/wine/wine/-/merge_requests/6797

4 8