November 2024 - Wine-gitlab

[PATCH 0/2] MR482: advapi32/tests: Test kernel object security with the primary token as well.
by Jinoh Kang (＠iamahuman) 09 Nov '24

09 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/482

2 3

[PATCH 0/1] MR474: server: Default the token owner to the token user.
by Jinoh Kang (＠iamahuman) 09 Nov '24

09 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/474

2 3

[PATCH 0/5] MR6776: d3dx9: D3DXSaveSurfaceToFileInMemory() refactoring, part 1.
by Connor McAdams (＠cmcadams) 09 Nov '24

09 Nov '24

This is the first of 3 planned MRs reworking how `D3DXSaveSurfaceToFileInMemory()` functions, starting with DDS files. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6776

3 17

Re: [PATCH v2 0/1] MR6789: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) 08 Nov '24

08 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6789

1 0

Re: [PATCH v6 0/1] MR6790: ntdll: use __wine_unix_spawnvp() to invoke unmount command. - approved
by Alexandre Julliard (＠julliard) 08 Nov '24

08 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6790

1 0

Re: [PATCH v2 0/3] MR6762: Implement RoGetAgileReference - approved
by Alexandre Julliard (＠julliard) 08 Nov '24

08 Nov '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6762

1 0

[PATCH 0/1] MR6791: msvcrt: Do not create in newer msvcrt versions a separate heap. (ASan)
by Bernhard Übelacker 08 Nov '24

08 Nov '24

A llvm-mingw built winver.exe with ASan enabled shows below error when exiting the application. This seems to be caused by libc++ using register_onexit_function before ASan has all function hooks in place, therefore allocates memory with plain calloc function. On process exit ASan uses in asan_allocator.cpp/Deallocate the function HeapValidate, which fails if msvcrt does not use the heap returned by GetProcessHeap(). ``` wine64 winver_asan.exe ================================================================= ==292==ERROR: AddressSanitizer: attempting free on address which was not malloc()-ed: 0x7ffffea05a10 in thread T0 0130:fixme:file:server_get_file_info Unsupported info class e #0 0x6ffffa809fe1 in free .../llvm-mingw/llvm-project/compiler-rt\lib/asan/asan_malloc_win.cpp:71:3 #1 0x6ffffeb048c5 in execute_onexit_table /home/bernhard/wine/dlls/msvcrt\exit.c:141:5 #2 0x6ffffbfb109e in _CRT_INIT .../llvm-mingw/mingw-w64/mingw-w64-crt/build-x86_64\../crt\crtdll.c:130:11 #3 0x6ffffbfb1316 in __DllMainCRTStartup .../llvm-mingw/mingw-w64/mingw-w64-crt/build-x86_64\../crt\crtdll.c:196:6 #4 0x6fffffc6d223 in call_dll_entry_point (C:\windows\system32\ntdll.dll+0x17002d223) #5 0x6fffffc71fdd in MODULE_InitDLL /home/bernhard/wine/dlls/ntdll\loader.c:1720:16 #6 0x6fffffc72601 in process_detach /home/bernhard/wine/dlls/ntdll\loader.c:1866:13 #7 0x6fffffc726f5 in RtlExitUserProcess /home/bernhard/wine/dlls/ntdll\loader.c:3893:5 #8 0x6fffffa8b899 in ExitProcess /home/bernhard/wine/dlls/kernel32\process.c:207:5 #9 0x6ffffeb054a7 in exit /home/bernhard/wine/dlls/msvcrt\exit.c:383:3 #10 0x000140001338 in mainCRTStartup /home/bernhard/wine/dlls/msvcrt\crt_main.c:60:5 #11 0x6fffffa98d58 in BaseThreadInitThunk /home/bernhard/wine/dlls/kernel32\thread.c:61:5 #12 0x6fffffc95afa in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x170055afa) Address 0x7ffffea05a10 is a wild pointer inside of access range of size 0x000000000001. SUMMARY: AddressSanitizer: bad-free /home/bernhard/wine/dlls/msvcrt\exit.c:141:5 in execute_onexit_table ==292==ABORTING ``` Please provide some guidance if this needs to be separated commits per msvcrt version, and if they are all needed (or more)? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6791

3 5

[PATCH v5 0/5] MR7: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) 08 Nov '24

08 Nov '24

This fixes https://bugs.winehq.org/show_bug.cgi?id=52094. -- v5: ntdll: Properly track refcount with forwarded exports. ntdll: Don't re-add a module dependency if it already exists. ntdll: Remove some NULL checks for current_importer. ntdll: Update current importer in LdrGetProcedureAddress(). ntdll: Wrap current_modref variable in a new structure. https://gitlab.winehq.org/wine/wine/-/merge_requests/7

3 6

[PATCH 0/3] MR6762: Implement RoGetAgileReference
by Zhiyi Zhang (＠zhiyi) 08 Nov '24

08 Nov '24

For React Native apps. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6762

3 4

[PATCH v7 0/7] MR6788: dlls/structuredquery: Introduce new DLL, add stubs.
by Vibhav Pant (＠vibhavp) 08 Nov '24

08 Nov '24

structuredquery is required to support AQS filters in Windows.Devices.Enumeration's `FindAllAsync` methods, and this stubs adds a basic set of stubs to get the ball rolling. -- v7: dlls/structuredquery: Add stubs for IQueryParserManager. dlls/structuredquery/tests: Add basic conformance tests for IQueryParserManager. include/structuredquery.idl: Add IQueryParserManager. dlls/structuredquery: Add stubs for QueryParser. dlls/structuredquery/tests: Add basic conformance tests for QueryParser. dlls/structuredquery: Add stub. include: Add structuredquery.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/6788

2 7